superreview requested: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 306928] Make the delete button work in all places

Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 419379: delete message doesn't work if focus in header of message preview
pane
https://bugzilla.mozilla.org/show_bug.cgi?id=419379

Attachment 306928: Make the delete button work in all places
https://bugzilla.mozilla.org/attachment.cgi?id=306928&action=edit

------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de>
I forgot the standalone message window before (thx Karsten for spotting), so
the patch is v1 + the change in messageWindow.js
0
bugzilla
3/2/2008 10:16:46 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
746 Views

Similar Articles

[PageSpeed] 42

Reply:

Similar Artilces:

superreview granted: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 306928] Make the delete button work in all places
neil@parkwaycc.co.uk <neil@httl.net> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 419379: delete message doesn't work if focus in header of message preview pane https://bugzilla.mozilla.org/show_bug.cgi?id=419379 Attachment 306928: Make the delete button work in all places https://bugzilla.mozilla.org/attachment.cgi?id=306928&action=edit ...

superreview requested: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 305846] Make delete button work again v1
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 419379: delete message doesn't work if focus in header of message preview pane https://bugzilla.mozilla.org/show_bug.cgi?id=419379 Attachment 305846: Make delete button work again v1 https://bugzilla.mozilla.org/attachment.cgi?id=305846&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> The patch brings back the button_delete command removed in bug 391701 and also introduces button_shiftD...

superreview granted: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 305846] Make delete button work again v1
neil@parkwaycc.co.uk <neil@httl.net> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 419379: delete message doesn't work if focus in header of message preview pane https://bugzilla.mozilla.org/show_bug.cgi?id=419379 Attachment 305846: Make delete button work again v1 https://bugzilla.mozilla.org/attachment.cgi?id=305846&action=edit ...

superreview requested: [Bug 282164] Deleting last message doesn't reset message pane and window title : [Attachment 177283] Possible patch
Mark Banner <mark@standard8.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 282164: Deleting last message doesn't reset message pane and window title https://bugzilla.mozilla.org/show_bug.cgi?id=282164 Attachment 177283: Possible patch https://bugzilla.mozilla.org/attachment.cgi?id=177283&action=edit ------- Additional Comments from Mark Banner <mark@standard8.demon.co.uk> This patch fixes both this and the thunderbird one (bug 218779). The reasoning behind it is that currentIndex may be -1 if a range is selected - tha...

superreview requested: [Bug 310844] shift+space doesn't scroll message pane up unless message pane has focus : [Attachment 201109] Explicitly allow shift key
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 310844: shift+space doesn't scroll message pane up unless message pane has focus https://bugzilla.mozilla.org/show_bug.cgi?id=310844 Attachment 201109: Explicitly allow shift key https://bugzilla.mozilla.org/attachment.cgi?id=201109&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Previously to bug 295288 we automatically ignored the shift key. ...

superreview requested: [Bug 189174] MAPISendMail does not copy file attachment to message before returning (WinZip 'Zip and e-mail' doesn't work) : [Attachment 166809] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 189174: MAPISendMail does not copy file attachment to message before returning (WinZip 'Zip and e-mail' doesn't work) https://bugzilla.mozilla.org/show_bug.cgi?id=189174 Attachment 166809: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=166809&action=edit ...

superreview requested: [Bug 270418] Delete item from context menu doesn't corresponds to the toolbar button : [Attachment 176767] Observe button delete for delete item on popup
Mark Banner <mark@standard8.demon.co.uk> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 270418: Delete item from context menu doesn't corresponds to the toolbar button https://bugzilla.mozilla.org/show_bug.cgi?id=270418 Attachment 176767: Observe button delete for delete item on popup https://bugzilla.mozilla.org/attachment.cgi?id=176767&action=edit ------- Additional Comments from Mark Banner <mark@standard8.demon.co.uk> One line patch to get the delete item on the popup menu to observe the button_delete command correctly and hence d...

superreview cancelled: [Bug 282164] Deleting last message doesn't reset message pane and window title : [Attachment 177283] Possible patch
Mark Banner <mark@standard8.demon.co.uk> has cancelled Mark Banner <mark@standard8.demon.co.uk>'s request for superreview: Bug 282164: Deleting last message doesn't reset message pane and window title https://bugzilla.mozilla.org/show_bug.cgi?id=282164 Attachment 177283: Possible patch https://bugzilla.mozilla.org/attachment.cgi?id=177283&action=edit ------- Additional Comments from Mark Banner <mark@standard8.demon.co.uk> Cancelling review as this doesn't work in the case neil mentioned. ...

superreview requested: [Bug 232321] Control-backspace doesn't delete words in URL bar : [Attachment 140950] Make word break pref work
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 232321: Control-backspace doesn't delete words in URL bar http://bugzilla.mozilla.org/show_bug.cgi?id=232321 Attachment 140950: Make word break pref work http://bugzilla.mozilla.org/attachment.cgi?id=140950&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I basically copied code from nsImageFrame.cpp ;-) ...

superreview requested: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 249378] adjust unread counts for message headers we don't
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 298737: newsgroups periodically lose unread count for messages whose headers haven't been downloaded https://bugzilla.mozilla.org/show_bug.cgi?id=298737 Attachment 249378: adjust unread counts for message headers we don't have, but just once for any given header https://bugzilla.mozilla.org/attachment.cgi?id=249378&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> this keeps track of the range of headers we'v...

superreview granted: [Bug 310844] shift+space doesn't scroll message pane up unless message pane has focus : [Attachment 201109] Explicitly allow shift key
David Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 310844: shift+space doesn't scroll message pane up unless message pane has focus https://bugzilla.mozilla.org/show_bug.cgi?id=310844 Attachment 201109: Explicitly allow shift key https://bugzilla.mozilla.org/attachment.cgi?id=201109&action=edit ...

superreview requested: [Bug 203818] Bookmark window doesn't hide it's toolbar when the toolbar button is clicked : [Attachment 179484] Make collapsible toolbar widget work
Stefan <stefan_h@hem.utfors.se> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 203818: Bookmark window doesn't hide it's toolbar when the toolbar button is clicked https://bugzilla.mozilla.org/show_bug.cgi?id=203818 Attachment 179484: Make collapsible toolbar widget work https://bugzilla.mozilla.org/attachment.cgi?id=179484&action=edit ------- Additional Comments from Stefan <stefan_h@hem.utfors.se> This will hide both toolbars when hitting the collapse toolbar button. ...

superreview granted: [Bug 189174] MAPISendMail does not copy file attachment to message before returning (WinZip 'Zip and e-mail' doesn't work) : [Attachment 166809] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 189174: MAPISendMail does not copy file attachment to message before returning (WinZip 'Zip and e-mail' doesn't work) https://bugzilla.mozilla.org/show_bug.cgi?id=189174 Attachment 166809: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=166809&action=edit ...

superreview granted: [Bug 270418] Delete item from context menu doesn't corresponds to the toolbar button : [Attachment 176767] Observe button delete for delete item on popup
Scott MacGregor <mscott@mozilla.org> has granted Mark Banner <mark@standard8.demon.co.uk>'s request for superreview: Bug 270418: Delete item from context menu doesn't corresponds to the toolbar button https://bugzilla.mozilla.org/show_bug.cgi?id=270418 Attachment 176767: Observe button delete for delete item on popup https://bugzilla.mozilla.org/attachment.cgi?id=176767&action=edit ...

Web resources about - superreview requested: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 306928] Make the delete button work in all places - mozilla.dev.super-review

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/15/2016 11:39:43 AM