superreview requested: [Bug 416233] Add sanitize (clear private data) option for SeaMonkey : [Attachment 305568] patch v3: more review comments, working tests

Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net>
for superreview:
Bug 416233: Add sanitize (clear private data) option for SeaMonkey
https://bugzilla.mozilla.org/show_bug.cgi?id=416233

Attachment 305568: patch v3: more review comments, working tests
https://bugzilla.mozilla.org/attachment.cgi?id=305568&action=edit

------- Additional Comments from Robert Kaiser <kairo@kairo.at>
Here's the updated patch for the rest of the review comments. Additionally, I
got the browser chrome test to run now, with some mochitest tweaks (will
probably be filed by ajschult) and some fixes to the test. Running browser
chrome tests (which look for browser_*.js so we need to stick with that) now
results in 31 passing tests for this patch :)
0
bugzilla
2/25/2008 8:32:26 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
505 Views

Similar Articles

[PageSpeed] 35

Reply:

Similar Artilces:

superreview canceled: [Bug 416233] Add sanitize (clear private data) option for SeaMonkey : [Attachment 305568] patch v3: more review comments, working tests
Robert Kaiser <kairo@kairo.at> has canceled Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 416233: Add sanitize (clear private data) option for SeaMonkey https://bugzilla.mozilla.org/show_bug.cgi?id=416233 Attachment 305568: patch v3: more review comments, working tests https://bugzilla.mozilla.org/attachment.cgi?id=305568&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This new patch addresses the comments for v3, carrying forward r+, requesting sr? one more time. ...

superreview requested: [Bug 416233] Add sanitize (clear private data) option for SeaMonkey : [Attachment 305769] patch v3.1: address comments from v3
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 416233: Add sanitize (clear private data) option for SeaMonkey https://bugzilla.mozilla.org/show_bug.cgi?id=416233 Attachment 305769: patch v3.1: address comments from v3 https://bugzilla.mozilla.org/attachment.cgi?id=305769&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This new patch addresses the comments for v3, carrying forward r+, requesting sr? one more time. ...

superreview denied: [Bug 416233] Add sanitize (clear private data) option for SeaMonkey : [Attachment 303655] patch v2: address review comments
neil@parkwaycc.co.uk <neil@httl.net> has denied Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 416233: Add sanitize (clear private data) option for SeaMonkey https://bugzilla.mozilla.org/show_bug.cgi?id=3D416233 Attachment 303655: patch v2: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=3D303655&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+libs:: $(_SUITE_FILES)=0D >+ $(INSTALL) $(foreach f,$^,"$f") $(DEPTH)/_tests/testing/mochitest/suite/$(relsrcdir)=0D Needs...

superreview granted: [Bug 416233] Add sanitize (clear private data) option for SeaMonkey : [Attachment 305769] patch v3.1: address comments from v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 416233: Add sanitize (clear private data) option for SeaMonkey https://bugzilla.mozilla.org/show_bug.cgi?id=3D416233 Attachment 305769: patch v3.1: address comments from v3 https://bugzilla.mozilla.org/attachment.cgi?id=3D305769&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Almost there, but I noticed some new nits... sr=3Dme with them fixed:=0D =0D >+# DEFINES for preprocessing=0D >+# once we support ...

superreview requested: [Bug 416233] Add sanitize (clear private data) option for SeaMonkey : [Attachment 306053] add new entries to makefiles.sh
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 416233: Add sanitize (clear private data) option for SeaMonkey https://bugzilla.mozilla.org/show_bug.cgi?id=416233 Attachment 306053: add new entries to makefiles.sh https://bugzilla.mozilla.org/attachment.cgi?id=306053&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> Shortly after checkin, I realized I forgot to add the new Makefiles to makefiles.sh, which causes no actual problem, but should be fixed. Here's the patch for that. ...

superreview granted: [Bug 416233] Add sanitize (clear private data) option for SeaMonkey : [Attachment 306053] add new entries to makefiles.sh
neil@parkwaycc.co.uk <neil@httl.net> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 416233: Add sanitize (clear private data) option for SeaMonkey https://bugzilla.mozilla.org/show_bug.cgi?id=416233 Attachment 306053: add new entries to makefiles.sh https://bugzilla.mozilla.org/attachment.cgi?id=306053&action=edit ...

superreview requested: [Bug 342677] select.options.add(null) crashes [@ JS_GetClass] : [Attachment 227145] patch answering review comments
Alex Vincent <ajvincent@gmail.com> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 342677: select.options.add(null) crashes [@ JS_GetClass] https://bugzilla.mozilla.org/show_bug.cgi?id=342677 Attachment 227145: patch answering review comments https://bugzilla.mozilla.org/attachment.cgi?id=227145&action=edit ------- Additional Comments from Alex Vincent <ajvincent@gmail.com> Sorry it took me so long to post the new patch; I wanted to test it first. smaug: I don't mind your comments one bit; I probably know less about this code than you d...

superreview requested: [Bug 322169] Clear Private Data does not clear JS Console : [Attachment 223285] trunk patch (updated to comments)
Darin Fisher (Google) <darin@meer.net> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 322169: Clear Private Data does not clear JS Console https://bugzilla.mozilla.org/show_bug.cgi?id=322169 Attachment 223285: trunk patch (updated to comments) https://bugzilla.mozilla.org/attachment.cgi?id=223285&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: toolkit/components/console/content/consoleBindings.xml >+ if (msg.message) >+ this.appendMessage(msg.message); >+ else // observed a null...

superreview requested: [Bug 233721] Port of Firefox bug 182928 to Seamonkey (Add confirmation for Set As Wallpaper) : [Attachment 141129] Addressed review comments
timeless@myrealbox.com (working) <timeless@bemail.org> has asked tor@acm.org for superreview: Bug 233721: Port of Firefox bug 182928 to Seamonkey (Add confirmation for Set As Wallpaper) http://bugzilla.mozilla.org/show_bug.cgi?id=233721 Attachment 141129: Addressed review comments http://bugzilla.mozilla.org/attachment.cgi?id=141129&action=edit ...

superreview requested: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 180129] Cleaned up patch, moving review requests
Torben <torben@despammed.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 90918: RFE: Add url in "comments" field of the "get info" window when download file. https://bugzilla.mozilla.org/show_bug.cgi?id=90918 Attachment 180129: Cleaned up patch, moving review requests https://bugzilla.mozilla.org/attachment.cgi?id=180129&action=edit ...

superreview granted: [Bug 352704] Should clear DOM storage when Clear Private Data is used : [Attachment 238642] Always enable clear all cookies options in Clear Private Data and Cookies dialogs
Daniel Veditz <dveditz@cruzio.com> has granted superreview: Bug 352704: Should clear DOM storage when Clear Private Data is used https://bugzilla.mozilla.org/show_bug.cgi?id=352704 Attachment 238642: Always enable clear all cookies options in Clear Private Data and Cookies dialogs https://bugzilla.mozilla.org/attachment.cgi?id=238642&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> sr=dveditz ...

superreview granted: [Bug 342677] select.options.add(null) crashes [@ JS_GetClass] : [Attachment 227145] patch answering review comments
Johnny Stenback <jst@mozilla.org> has granted Alex Vincent <ajvincent@gmail.com>'s request for superreview: Bug 342677: select.options.add(null) crashes [@ JS_GetClass] https://bugzilla.mozilla.org/show_bug.cgi?id=342677 Attachment 227145: patch answering review comments https://bugzilla.mozilla.org/attachment.cgi?id=227145&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview requested: [Bug 339543] microsummaries trigger bookmarked files to be downloaded : [Attachment 225855] patch v3: addresses review comments
Myk Melez <myk@mozilla.org> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 339543: microsummaries trigger bookmarked files to be downloaded https://bugzilla.mozilla.org/show_bug.cgi?id=339543 Attachment 225855: patch v3: addresses review comments https://bugzilla.mozilla.org/attachment.cgi?id=225855&action=edit ------- Additional Comments from Myk Melez <myk@mozilla.org> Thanks Christian; requesting super-review from mconnor in case your review doesn't suffice. ...

superreview requested: [Bug 304147] progressmeter in undetermined mode does not work in Mac OS X : [Attachment 312480] Fix v3.2: address review comments
Markus Stange <mstange@themasta.com> has asked Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 304147: progressmeter in undetermined mode does not work in Mac OS X https://bugzilla.mozilla.org/show_bug.cgi?id=304147 Attachment 312480: Fix v3.2: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=312480&action=edit ...

Web resources about - superreview requested: [Bug 416233] Add sanitize (clear private data) option for SeaMonkey : [Attachment 305568] patch v3: more review comments, working tests - mozilla.dev.super-review

Resources last updated: 1/15/2016 10:19:05 AM