superreview requested: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) : [Attachment 292260] patch

Gavin Sharp <gavin.sharp@gmail.com> has asked Christian :Biesinger
<cbiesinger@gmx.at> for superreview:
Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a
URI's port to it's default value by setting .spec)
https://bugzilla.mozilla.org/show_bug.cgi?id=407538

Attachment 292260: patch
https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit

------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com>
I'm not sure about the XXX comment in the test - seems like we should probably
fix that, too, but I'm not sure how feasible that is.
0
bugzilla
12/9/2007 12:44:58 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
1522 Views

Similar Articles

[PageSpeed] 58

Reply:

Similar Artilces:

superreview requested: [Bug 237228] pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js : [Attachment 158389] patch, add UnregisterPrefCallback
Ginn Chen <ginn.chen@sun.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 237228: pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js http://bugzilla.mozilla.org/show_bug.cgi?id=237228 Attachment 158389: patch, add UnregisterPrefCallback http://bugzilla.mozilla.org/attachment.cgi?id=158389&action=edit ...

superreview requested: [Bug 378544] General's Default Feed Viewer's " =?UTF-8?Q?Select=E2=80=A6?=" doesn't use real elipsis
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 378544: General's Default Feed Viewer's "Select=E2=80=A6" doesn't use r= eal elipsis https://bugzilla.mozilla.org/show_bug.cgi?id=3D378544 Attachment 264750: changed https://bugzilla.mozilla.org/attachment.cgi?id=3D264750&action=3Dedit= ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview requested: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Louie Zhao <Louie.Zhao@sun.com> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ...

superreview granted: [Bug 237228] pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js : [Attachment 158389] patch, add UnregisterPrefCallback
Robert O'Callahan <roc@ocallahan.org> has granted Ginn Chen <ginn.chen@sun.com>'s request for superreview: Bug 237228: pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js http://bugzilla.mozilla.org/show_bug.cgi?id=237228 Attachment 158389: patch, add UnregisterPrefCallback http://bugzilla.mozilla.org/attachment.cgi?id=158389&action=edit ...

superreview granted: [Bug 378544] General's Default Feed Viewer's " =?UTF-8?Q?Select=E2=80=A6?=" doesn't use real elipsis
Mike Pinkerton <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 378544: General's Default Feed Viewer's "Select=E2=80=A6" doesn't use r= eal elipsis https://bugzilla.mozilla.org/show_bug.cgi?id=3D378544 Attachment 264750: changed https://bugzilla.mozilla.org/attachment.cgi?id=3D264750&action=3Dedit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> rs=3Dpink= ...

superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...

superreview requested: [Bug 403173] Change "it's" to "it is" in Empty Cache dialog : [Attachment 294624] No more " =?UTF-8?Q?it=E2=80=99s?=" in the cache
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has ask= ed Mark Mentovai <mark@moxienet.com> for superreview: Bug 403173: Change "it's" to "it is" in Empty Cache dialog https://bugzilla.mozilla.org/show_bug.cgi?id=3D403173 Attachment 294624: No more "it=E2=80=99s" in the cache https://bugzilla.mozilla.org/attachment.cgi?id=3D294624&action=3Dedit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> (In reply to comment #3)=0D > This should probably be ano...

superreview requested: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293607] fix assert
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293607: fix assert https://bugzilla.mozilla.org/attachment.cgi?id=293607&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> This patch creates nsBlockFrame* nsLayoutUtils::GetAsBlock wh...

superreview requested: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293637] reflow captions with unconstrained height
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293637: reflow captions with unconstrained height https://bugzilla.mozilla.org/attachment.cgi?id=293637&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> Fixes the assertion independen...

superreview requested: [Bug 338103] regression: document.dir is "" unless it's set manually : [Attachment 222194] patch
Simon Montagu <smontagu@smontagu.org> has asked for superreview: Bug 338103: regression: document.dir is "" unless it's set manually https://bugzilla.mozilla.org/show_bug.cgi?id=338103 Attachment 222194: patch https://bugzilla.mozilla.org/attachment.cgi?id=222194&action=edit ...

superreview granted: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Henry Jia <Henry.Jia@sun.com> has granted Louie Zhao <Louie.Zhao@sun.com>'s request for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ------- Additional Comments from Henry Jia <Henry.Jia@sun.com> sr=Henry ...

superreview requested: [Bug 338103] regression: document.dir is "" unless it's set manually : [Attachment 222194] patch #2
Simon Montagu <smontagu@smontagu.org> has asked Boris Zbarsky (gone May 17 -- May 29) <bzbarsky@mit.edu> for superreview: Bug 338103: regression: document.dir is "" unless it's set manually https://bugzilla.mozilla.org/show_bug.cgi?id=338103 Attachment 222194: patch https://bugzilla.mozilla.org/attachment.cgi?id=222194&action=edit ...

superreview requested: [Bug 382331] [l10n] Default browser dialogue's "set" button does not resize well : [Attachment 303045] fix
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> for superreview: Bug 382331: [l10n] Default browser dialogue's "set" button does not resize well https://bugzilla.mozilla.org/show_bug.cgi?id=382331 Attachment 303045: fix https://bugzilla.mozilla.org/attachment.cgi?id=303045&action=edit ...

superreview requested: [Bug 303521] !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" : [Attachment 191706] fix spelling
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 303521: !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" https://bugzilla.mozilla.org/show_bug.cgi?id=303521 Attachment 191706: fix spelling https://bugzilla.mozilla.org/attachment.cgi?id=191706&action=edit ...

Web resources about - superreview requested: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) : [Attachment 292260] patch - mozilla.dev.super-review

Resources last updated: 12/27/2015 11:26:02 AM