superreview requested: [Bug 401559] GetFirst/LastChild doesn' t ensure contents generated

Smaug <Olli.Pettay@gmail.com> has asked Johnny Stenback (:jst)
<jst@mozilla.org> for superreview:
Bug 401559: GetFirst/LastChild doesn't ensure contents generated
https://bugzilla.mozilla.org/show_bug.cgi?id=401559

Attachment 286564: proposed patch
https://bugzilla.mozilla.org/attachment.cgi?id=286564&action=edit
0
bugzilla
10/29/2007 4:50:36 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
449 Views

Similar Articles

[PageSpeed] 1

Reply:

Similar Artilces:

superreview granted: [Bug 401559] GetFirst/LastChild doesn' t ensure contents generated
Johnny Stenback (:jst) <jst@mozilla.org> has granted Smaug <Olli.Pettay@gmail.com>'s request for superreview: Bug 401559: GetFirst/LastChild doesn't ensure contents generated https://bugzilla.mozilla.org/show_bug.cgi?id=401559 Attachment 286564: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=286564&action=edit ...

superreview requested: [Bug 257690] CreateGeneratedFrameFor() doesn't add the generated content as anonymous content : [Attachment 157641] diff -w for review
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> for superreview: Bug 257690: CreateGeneratedFrameFor() doesn't add the generated content as anonymous content http://bugzilla.mozilla.org/show_bug.cgi?id=257690 Attachment 157641: diff -w for review http://bugzilla.mozilla.org/attachment.cgi?id=157641&action=edit ...

superreview requested: [Bug 257690] CreateGeneratedFrameFor() doesn't add the generated content as anonymous content : [Attachment 157632] Mark tell the presshell about anonymous content for generate
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> for superreview: Bug 257690: CreateGeneratedFrameFor() doesn't add the generated content as anonymous content http://bugzilla.mozilla.org/show_bug.cgi?id=257690 Attachment 157632: Mark tell the presshell about anonymous content for generated frames. http://bugzilla.mozilla.org/attachment.cgi?id=157632&action=edit ...

superreview granted: [Bug 257690] CreateGeneratedFrameFor() doesn't add the generated content as anonymous content : [Attachment 157641] diff -w for review
Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 257690: CreateGeneratedFrameFor() doesn't add the generated content as anonymous content http://bugzilla.mozilla.org/show_bug.cgi?id=257690 Attachment 157641: diff -w for review http://bugzilla.mozilla.org/attachment.cgi?id=157641&action=edit ------- Additional Comments from Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> >Index: layout/html/style/src/nsCSSFrameConstructor.cpp >@@ -1524,38 +1525,...

superreview cancelled: [Bug 257690] CreateGeneratedFrameFor() doesn't add the generated content as anonymous content : [Attachment 157632] Mark tell the presshell about anonymous content for generate
Johnny Stenback <jst@mozilla.jstenback.com> has cancelled Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 257690: CreateGeneratedFrameFor() doesn't add the generated content as anonymous content http://bugzilla.mozilla.org/show_bug.cgi?id=257690 Attachment 157632: Mark tell the presshell about anonymous content for generated frames. http://bugzilla.mozilla.org/attachment.cgi?id=157632&action=edit ...

superreview requested: [Bug 226954] doesn't show the 'contents' frame : [Attachment 136666] Partial patch
Boris Zbarsky (not really reading bugmail) <bz-vacation@mit.edu> has asked for superreview: Bug 226954: doesn't show the 'contents' frame http://bugzilla.mozilla.org/show_bug.cgi?id=226954 Attachment 136666: Partial patch http://bugzilla.mozilla.org/attachment.cgi?id=136666&action=edit ------- Additional Comments from Boris Zbarsky (not really reading bugmail) <bz-vacation@mit.edu> OK, the issue with the second testcase is resolved by the patch in bug 97695. Looks like line layout is just passing us a bogus CB height here... ...

superreview requested: [Bug 226954] doesn't show the 'contents' frame : [Attachment 136666] Partial patch #2
Boris Zbarsky (not in town, no tree) <bz-vacation@mit.edu> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 226954: doesn't show the 'contents' frame http://bugzilla.mozilla.org/show_bug.cgi?id=226954 Attachment 136666: Partial patch http://bugzilla.mozilla.org/attachment.cgi?id=136666&action=edit ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview requested: [Bug 232129] imap protocol logging doesn't handle long lines : [Attachment 139853] fix that doesn't add newlines
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 232129: imap protocol logging doesn't handle long lines http://bugzilla.mozilla.org/show_bug.cgi?id=232129 Attachment 139853: fix that doesn't add newlines http://bugzilla.mozilla.org/attachment.cgi?id=139853&action=edit ...

superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ...

superreview requested: [Bug 87513] about:<randomness> doesn't display a default page, if the about: topic doesn't exist. : [Attachment 195365] Simple fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Darin Fisher <darin@meer.net> for superreview: Bug 87513: about:<randomness> doesn't display a default page, if the about: topic doesn't exist. https://bugzilla.mozilla.org/show_bug.cgi?id=87513 Attachment 195365: Simple fix https://bugzilla.mozilla.org/attachment.cgi?id=195365&action=edit ...

superreview requested: [Bug 344172] Spellchecker doesn't display suggestion list for misspelled words and doesn't underline them if Russian, Ukrainian or Bulgarian Spell dictionary is installed : [Att #2
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked for superreview: Bug 344172: Spellchecker doesn't display suggestion list for misspelled words and doesn't underline them if Russian, Ukrainian or Bulgarian Spell dictionary is installed https://bugzilla.mozilla.org/show_bug.cgi?id=344172 Attachment 229985: fix https://bugzilla.mozilla.org/attachment.cgi?id=229985&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Fairly obvious bug in retrospect. Comparing just the bottom 8 bits to see if it's a d...

Web resources about - superreview requested: [Bug 401559] GetFirst/LastChild doesn' t ensure contents generated - mozilla.dev.super-review

Resources last updated: 12/6/2015 11:16:05 AM