superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 293819] patch, v.1.4, updated based on review comments

John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter
<pavlov@pavlov.net> for superreview:
Bug 396137: port Windows font matching code to Mac and use in place of ATSUI
font matching
https://bugzilla.mozilla.org/show_bug.cgi?id=396137

Attachment 293819: patch, v.1.4, updated based on review comments
https://bugzilla.mozilla.org/attachment.cgi?id=293819&action=edit
0
bugzilla
12/19/2007 10:21:23 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
632 Views

Similar Articles

[PageSpeed] 18

Reply:

Similar Artilces:

superreview canceled: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 293819] patch, v.1.4, updated based on review comments
John Daggett (:jtd) <jdaggett@mozilla.com> has canceled John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=3D396137 Attachment 293819: patch, v.1.4, updated based on review comments https://bugzilla.mozilla.org/attachment.cgi?id=3D293819&action=3Dedit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> Yeah, the first thing I want to improve about this is to cache the pref fon= t...

superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 294611] patch, v.1.6, updated based on pav's comments on 1. 5 patch
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 294611: patch, v.1.6, updated based on pav's comments on 1.5 patch https://bugzilla.mozilla.org/attachment.cgi?id=294611&action=edit ...

superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 294004] patch, v.1.5, updated based on roc's comments
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=3D396137 Attachment 294004: patch, v.1.5, updated based on roc's comments https://bugzilla.mozilla.org/attachment.cgi?id=3D294004&action=3Dedit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> Yeah, the first thing I want to improve about this is to cache the pref fon= ts in some compact f...

superreview granted: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 294611] patch, v.1.6, updated based on pav's comments on 1. 5 patch
Stuart Parmenter <pavlov@pavlov.net> has granted John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 294611: patch, v.1.6, updated based on pav's comments on 1.5 patch https://bugzilla.mozilla.org/attachment.cgi?id=294611&action=edit ...

superreview canceled: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 294004] patch, v.1.5, updated based on roc's comments
John Daggett (:jtd) <jdaggett@mozilla.com> has canceled John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 294004: patch, v.1.5, updated based on roc's comments https://bugzilla.mozilla.org/attachment.cgi?id=294004&action=edit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> Changes based on comment 40. In addition, I put back in the call to SortGlyphRun...

superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 293486] patch, v.1.3, fix problem with missing glyphs
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 293486: patch, v.1.3, fix problem with missing glyphs https://bugzilla.mozilla.org/attachment.cgi?id=293486&action=edit ...

superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 292750] patch, v1.2, cmap font matching fix
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=3D396137 Attachment 292750: patch, v1.2, cmap font matching fix https://bugzilla.mozilla.org/attachment.cgi?id=3D292750&action=3Dedit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> Tested patch, ready for inspection. I haven't done a lot of optimization on this yet, specifically I haven&...

superreview canceled: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 293486] patch, v.1.3, fix problem with missing glyphs
John Daggett (:jtd) <jdaggett@mozilla.com> has canceled John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 293486: patch, v.1.3, fix problem with missing glyphs https://bugzilla.mozilla.org/attachment.cgi?id=293486&action=edit ...

superreview denied: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 292750] patch, v1.2, cmap font matching fix
Stuart Parmenter <pavlov@pavlov.net> has denied John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=3D396137 Attachment 292750: patch, v1.2, cmap font matching fix https://bugzilla.mozilla.org/attachment.cgi?id=3D292750&action=3Dedit ------- Additional Comments from Stuart Parmenter <pavlov@pavlov.net> Overall, this looks pretty good. Some comments:=0D =0D -/* -*- Mode: C++; tab-width: 20; indent-tabs-...

superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 291416: patch, v.1.0 use cmap information to match fonts under Mac OS X https://bugzilla.mozilla.org/attachment.cgi?id=291416&action=edit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> This bug blocks other blockers, 361986 and 396732. ...

superreview canceled: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching
John Daggett (:jtd) <jdaggett@mozilla.com> has canceled John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 291416: patch, v.1.0 use cmap information to match fonts under Mac OS X https://bugzilla.mozilla.org/attachment.cgi?id=291416&action=edit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> This patch trims out UPDATE_RANGES code and fixes a periodic crash ...

superreview granted: [Bug 419757] cache codepoints for which no font matches on windows : [Attachment 305960] patch, v.0.1, cache codepoints for which no font matches
Stuart Parmenter <pavlov@pavlov.net> has granted superreview: Bug 419757: cache codepoints for which no font matches on windows https://bugzilla.mozilla.org/show_bug.cgi?id=419757 Attachment 305960: patch, v.0.1, cache codepoints for which no font matches https://bugzilla.mozilla.org/attachment.cgi?id=305960&action=edit ------- Additional Comments from Stuart Parmenter <pavlov@pavlov.net> + mCodepointsWithNoFonts.reset (); get rid of the space between reset and () ...

superreview requested: [Bug 159809] Camino defaults to old Mac OS 9 fonts for most non-Western European languages : [Attachment 177195] Patched all.js (using v2.4.1 of font list)
Jungshik Shin <jshin1987@gmail.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 159809: Camino defaults to old Mac OS 9 fonts for most non-Western European languages https://bugzilla.mozilla.org/show_bug.cgi?id=159809 Attachment 177195: Patched all.js (using v2.4.1 of font list) https://bugzilla.mozilla.org/attachment.cgi?id=177195&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> I've conducted some tests with both Camino and Firefox. It seems that for now this is as good as it can get except that Za...

superreview requested: [Bug 419744] load font cmap info via a background task on windows : [Attachment 313300] patch, v.0.4, clean out debugging stuff, both mac and windows
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 419744: load font cmap info via a background task on windows https://bugzilla.mozilla.org/show_bug.cgi?id=419744 Attachment 313300: patch, v.0.4, clean out debugging stuff, both mac and windows https://bugzilla.mozilla.org/attachment.cgi?id=313300&action=edit ...

Web resources about - superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 293819] patch, v.1.4, updated based on review comments - mozilla.dev.super-review

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/12/2015 12:28:01 AM