superreview denied: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has denied Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't displ= ay server name https://bugzilla.mozilla.org/show_bug.cgi?id=3D393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=3D292031&action=3Dedit ------- Additional Comments from Boris Zbarsky (reviews very slow until spr= ing) <bzbarsky@mit.edu> You don't need the QI. ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292088] patch v3: remove unnecessary QueryInterface
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292088: patch v3: remove unnecessary QueryInterface https://bugzilla.mozilla.org/attachment.cgi?id=292088&action=edit ------- Additional Comments from Anant Narayanan <anant@kix.in> Sorry, should have taken a look at the implementation of NS_GetInnermostURI first. ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292022] patch v1: fixes mentioned problem
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292022: patch v1: fixes mentioned problem https://bugzilla.mozilla.org/attachment.cgi?id=292022&action=edit ...

superreview denied: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292022] patch v1: fixes mentioned problem
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has denied Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292022: patch v1: fixes mentioned problem https://bugzilla.mozilla.org/attachment.cgi?id=292022&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> I think you want to use NS_GetInnermostURI here inst...

superreview granted: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292088] patch v3: remove unnecessary QueryInterface
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292088: patch v3: remove unnecessary QueryInterface https://bugzilla.mozilla.org/attachment.cgi?id=292088&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> Excellent! ...

superreview requested: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Simon Montagu <smontagu@smontagu.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Simon Montagu <smontagu@smontagu.org> This is a port of Neil's patch to xpfe in bug 252317. It had r=doron, sr=bzbarsky over there, so I guess rs should be enough to apply it to toolkit. ...

superreview granted: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Scott MacGregor <mscott@mozilla.org> has granted Simon Montagu <smontagu@smontagu.org>'s request for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> this needs a toolkit module owner review so I'll ask Benjamin for that. David's on vacation, i'll do the sr. ...

superreview requested: [Bug 90263] New account wizard uses "server name" and "hostname" : [Attachment 106602] quick patch that changes hostname to server name
Henrik Lynggaard Hansen <admin@mozillatranslator.org> has asked Scott MacGregor (on holiday until 01/02/2004) <mscott@mozilla.org> for superreview: Bug 90263: New account wizard uses "server name" and "hostname" http://bugzilla.mozilla.org/show_bug.cgi?id=90263 Attachment 106602: quick patch that changes hostname to server name http://bugzilla.mozilla.org/attachment.cgi?id=106602&action=edit ------- Additional Comments from Henrik Lynggaard Hansen <admin@mozillatranslator.org> review please ...

superreview requested: [Bug 91937] "Edit As New" doesn't update From: address in the compose window with the right address : [Attachment 138231] proposed patch
Christian Eyrich <ch.ey@gmx.net> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 91937: "Edit As New" doesn't update From: address in the compose window with the right address http://bugzilla.mozilla.org/show_bug.cgi?id=91937 Attachment 138231: proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=138231&action=edit ...

superreview granted: [Bug 91937] "Edit As New" doesn't update From: address in the compose window with the right address : [Attachment 138503] patch v2
David Bienvenu <bienvenu@nventure.com> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 91937: "Edit As New" doesn't update From: address in the compose window with the right address http://bugzilla.mozilla.org/show_bug.cgi?id=91937 Attachment 138503: patch v2 http://bugzilla.mozilla.org/attachment.cgi?id=138503&action=edit ...

superreview requested: [Bug 217147] "View Saved Passwords..." window doesn't remember its size and position : [Attachment 131839] patch to fix bug 205176 as well
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 217147: "View Saved Passwords..." window doesn't remember its size and position http://bugzilla.mozilla.org/show_bug.cgi?id=217147 Attachment 131839: patch to fix bug 205176 as well http://bugzilla.mozilla.org/attachment.cgi?id=131839&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Brian, I just realized that you've got the full cvs blame for both files. Can you review this please? ...

superreview requested: [Bug 102269] Cookie Manager: "Server Secure" should be "Secure Server" : [Attachment 143120] patch v2 including dialog update
Mike Connor <mconnor@myrealbox.com> has asked Alec Flett <alecf@flett.org> for superreview: Bug 102269: Cookie Manager: "Server Secure" should be "Secure Server" http://bugzilla.mozilla.org/show_bug.cgi?id=102269 Attachment 143120: patch v2 including dialog update http://bugzilla.mozilla.org/attachment.cgi?id=143120&action=edit ------- Additional Comments from Mike Connor <mconnor@myrealbox.com> alec, this one is pretty trivial if you have time before freeze... ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> (In reply to comment #60) > (From update of attachment 227564 [edit]) > So this w...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=307048&action=edit ...