superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2

Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron
<dbaron@mozilla.com> for superreview:
Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is
broken)
https://bugzilla.mozilla.org/show_bug.cgi?id=363573

Attachment 248557: Patch rev. 2
https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit

------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net>
Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use
GetAbsoluteCoord, the latter made 'ch' work for 'height', 'min-height'
and 'max-height' (to my surprise it seems to be working for vertical
padding and margin already).
0
bugzilla
12/13/2006 9:15:32 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
553 Views

Similar Articles

[PageSpeed] 46

Reply:

Similar Artilces:

superreview granted: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2
David Baron <dbaron@mozilla.com> has granted superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248557: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.com> r+sr=dbaron. Let's do the renaming in a separate patch after this one lands. (You can if you want, or I can...) ...

superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248510: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The 'cols' attribute is mapped to a 'ch' unit width. This patch implements the 'ch' unit generally for 'wid...

superreview cancelled: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has cancelled superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248510: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use GetAbsoluteCoord, the latter made 'ch' work for 'height', 'min-height' and 'max...

superreview requested: [Bug 271955] "empty" table cells don't include borders in size even when 'empty-cells: show' : [Attachment 167169] patch
David Baron <dbaron@mozilla.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 271955: "empty" table cells don't include borders in size even when 'empty-cells: show' https://bugzilla.mozilla.org/show_bug.cgi?id=271955 Attachment 167169: patch https://bugzilla.mozilla.org/attachment.cgi?id=167169&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 426776: If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. https://bugzilla.mozilla.org/show_bug.cgi?id=426776 Attachment 313548: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=313548&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> netwerk/base/src/nsDirectoryIndexStream.cpp: On MacOSX, IsFile() and IsDirectory() returns N...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #3
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #4
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <bienvenu@nventure.com> since '2004-04-26' :-( ...

superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> This proved to be pretty simple to fix, with some caveats. The attached pa= tch passes Hixie's test linke...

superreview requested: [Bug 363706] Support CSS3 'ch' unit for border and outline : [Attachment 323794] revised patch to expose width of '0' to GetLengthWith() #2
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 363706: Support CSS3 'ch' unit for border and outline https://bugzilla.mozilla.org/show_bug.cgi?id=363706 Attachment 323794: revised patch to expose width of '0' to GetLengthWith() https://bugzilla.mozilla.org/attachment.cgi?id=323794&action=edit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> fixing r/sr fields. And I should have mentioned that this patch now depends on the removal of eStyleUnit_Chars. ...

superreview granted: [Bug 271955] "empty" table cells don't include borders in size even when 'empty-cells: show' : [Attachment 167169] patch
Robert O'Callahan <roc@ocallahan.org> has granted David Baron <dbaron@mozilla.org>'s request for superreview: Bug 271955: "empty" table cells don't include borders in size even when 'empty-cells: show' https://bugzilla.mozilla.org/show_bug.cgi?id=271955 Attachment 167169: patch https://bugzilla.mozilla.org/attachment.cgi?id=167169&action=edit ...

superreview requested: [Bug 289667] drag 'n drop of < map > links found in an < img > is broken : [Attachment 187458] Patch rev. 2
Mats Palmgren <mats.palmgren@bredband.net> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 289667: drag 'n drop of < map > links found in an < img > is broken https://bugzilla.mozilla.org/show_bug.cgi?id=289667 Attachment 187458: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=187458&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Added comments and stopping mouse capture as suggested. ...

superreview requested: [Bug 227633] (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR : [Attachment 154285] (Av1a-Bw) <mailnews/*> (review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 227633: (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR https://bugzilla.mozilla.org/show_bug.cgi?id=227633 Attachment 154285: (Av1a-Bw) <mailnews/*> (review only) https://bugzilla.mozilla.org/attachment.cgi?id=154285&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <sspitzer@mozilla.org> since "2004-07-25" :-( DanM: DanW suggests giving 'rs...