superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1

Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron
<dbaron@mozilla.com> for superreview:
Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is
broken)
https://bugzilla.mozilla.org/show_bug.cgi?id=363573

Attachment 248510: Patch rev. 1
https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit

------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net>
The 'cols' attribute is mapped to a 'ch' unit width.

This patch implements the 'ch' unit generally for 'width', 'min-width',
'max-width', 'padding' and 'margin'.
I'm leaving 'border'/'outline' for now since it needs style struct changes.
I will file a separate bug that.

I also noted that "CSS3 Values and Units" now has a 'ch' unit
that is the width of a "0" (zero) whereas we use "M".
http://www.w3.org/TR/css3-values/#relative0
We should probably fix that separately though since it may involve
adjusting INPUT and/or TEXTAREA code.
0
bugzilla
12/13/2006 1:57:26 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
566 Views

Similar Articles

[PageSpeed] 42

Reply:

Similar Artilces:

superreview cancelled: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has cancelled superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248510: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use GetAbsoluteCoord, the latter made 'ch' work for 'height', 'min-height' and 'max...

superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248557: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use GetAbsoluteCoord, the latter made 'ch' work for 'height&#...

superreview granted: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2
David Baron <dbaron@mozilla.com> has granted superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248557: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.com> r+sr=dbaron. Let's do the renaming in a separate patch after this one lands. (You can if you want, or I can...) ...

superreview requested: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 426776: If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. https://bugzilla.mozilla.org/show_bug.cgi?id=426776 Attachment 313548: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=313548&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> netwerk/base/src/nsDirectoryIndexStream.cpp: On MacOSX, IsFile() and IsDirectory() returns N...

superreview requested: [Bug 296102] Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 : [Attachment 187861] If we can't load a <xul:script>, don't barf, rev. 1
Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 296102: Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 https://bugzilla.mozilla.org/show_bug.cgi?id=296102 Attachment 187861: If we can't load a <xul:script>, don't barf, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187861&action=edit ...

superreview requested: [Bug 271955] "empty" table cells don't include borders in size even when 'empty-cells: show' : [Attachment 167169] patch
David Baron <dbaron@mozilla.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 271955: "empty" table cells don't include borders in size even when 'empty-cells: show' https://bugzilla.mozilla.org/show_bug.cgi?id=271955 Attachment 167169: patch https://bugzilla.mozilla.org/attachment.cgi?id=167169&action=edit ...

superreview requested: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> These two changes are not needed to fix this bug: Removed an unused parameter from GetMaxOptionHeight(). Make sure GetNum...

superreview canceled: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1
Christian :Biesinger <cbiesinger@gmail.com> has canceled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 426776: If a folder contains a 'broken' symbolic link, you can't naviga= te to it in Firefox using the file:/// URL. https://bugzilla.mozilla.org/show_bug.cgi?id=3D426776 Attachment 313548: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=3D313548&action=3Dedit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com> + int err =3D lstat((char*)path, &stats);=0D =0D that cast se...

superreview granted: [Bug 296102] Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 : [Attachment 187861] If we can't load a <xul:script>, don't barf, rev. 1
Johnny Stenback <jst@mozilla.org> has granted Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us>'s request for superreview: Bug 296102: Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 https://bugzilla.mozilla.org/show_bug.cgi?id=296102 Attachment 187861: If we can't load a <xul:script>, don't barf, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187861&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> This proved to be pretty simple to fix, with some caveats. The attached pa= tch passes Hixie's test linke...

superreview granted: [Bug 271955] "empty" table cells don't include borders in size even when 'empty-cells: show' : [Attachment 167169] patch
Robert O'Callahan <roc@ocallahan.org> has granted David Baron <dbaron@mozilla.org>'s request for superreview: Bug 271955: "empty" table cells don't include borders in size even when 'empty-cells: show' https://bugzilla.mozilla.org/show_bug.cgi?id=271955 Attachment 167169: patch https://bugzilla.mozilla.org/attachment.cgi?id=167169&action=edit ...

superreview requested: [Bug 289667] drag 'n drop of < map > links found in an < img > is broken : [Attachment 187358] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 289667: drag 'n drop of < map > links found in an < img > is broken https://bugzilla.mozilla.org/show_bug.cgi?id=289667 Attachment 187358: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187358&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The problem is that <area> content does not have a primary frame, so we call |StopTrackingDragGesture()| and make an early re...

superreview requested: [Bug 448281] font-size sometimes gets calculated wrong : [Attachment 332497] patch 1: don't rebuild rule cascades if they're aren't currently any
David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky (todo: 200+ items) <bzbarsky@mit.edu> for superreview: Bug 448281: font-size sometimes gets calculated wrong https://bugzilla.mozilla.org/show_bug.cgi?id=448281 Attachment 332497: patch 1: don't rebuild rule cascades if they're aren't currently any https://bugzilla.mozilla.org/attachment.cgi?id=332497&action=edit ...

superreview requested: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The problem is that "if (aDesiredSize.width > dropdownDesiredSize.width)" is false so we never do the second...

superreview granted: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: layout/forms/nsListControlFrame.cpp >+ nsIPresShell* shell = aPresContext->GetPresShell(); I thi...

superreview requested: [Bug 344505] role="anything" on <table> should remove roleless <td>'s, <th's> from hierarchy : [Attachment 229522] Any role on a table means the table structure descendants are
Aaron Leventhal <aaronleventhal@moonset.net> has asked for superreview: Bug 344505: role="anything" on <table> should remove roleless <td>'s, <th's> from hierarchy https://bugzilla.mozilla.org/show_bug.cgi?id=344505 Attachment 229522: Any role on a table means the table structure descendants are no longer structurally relevant, unless they have their own role. They're being used to layout the container. https://bugzilla.mozilla.org/attachment.cgi?id=229522&action=edit ...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137796] (Av2) <nsInternetSearchService.cpp>
Serge GAUTHERIE <gautheri@noos.fr> has asked Alec Flett <alecf@flett.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 137796: (Av2) <nsInternetSearchService.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137796&action=edit ...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137404] (Av1) <nsInternetSearchService.cpp>
Serge GAUTHERIE <gautheri@noos.fr> has asked Alec Flett <alecf@flett.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 137404: (Av1) <nsInternetSearchService.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137404&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'r=?': (see comment 2) Can you (super-)review, compile, test, check it in ? ...

superreview granted: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 318391] Patch v1.1
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted=20 superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 318391: Patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=3D318391&action=3Dedit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> Thank you, Roc and Katakai-san.= ...

superreview requested: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 317954] Patch v1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 317954: Patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=3D317954&action=3Dedit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> Katakai-san, please hurry up to review this, if you can.=0D =0D Roc: Would you r+sr for this? Even if we...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 139060] (Bv1b) </mailnews/addrbook/src/ns*.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 139060: (Bv1b) </mailnews/addrbook/src/ns*.*> http://bugzilla.mozilla.org/attachment.cgi?id=139060&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> { (Bv1) </mailnews/addrbook/src/ns*.*> patch 2003-12-29 15:10:42 neil.parkwaycc.co.uk: review+ } ...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 139060] (Bv1b) </mailnews/addrbook/src/ns*.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 139060: (Bv1b) </mailnews/addrbook/src/ns*.*> http://bugzilla.mozilla.org/attachment.cgi?id=139060&action=edit ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ...

superreview requested: [Bug 139568] ASSERT: nsFrameManager::GenerateStateKey didn't find content by type!: 'index > -1', file nsFrameManager.cpp, line 2261 : [Attachment 172218] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 139568: ASSERT: nsFrameManager::GenerateStateKey didn't find content by type!: 'index > -1', file nsFrameManager.cpp, line 2261 https://bugzilla.mozilla.org/show_bug.cgi?id=139568 Attachment 172218: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172218&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This is the right thing to do. If this causes pageload issues, I'll remove the flush, but the assert ...

Web resources about - superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1 - mozilla.dev.super-review

Adobe issues emergency patch for actively exploited code-execution bug
Adobe has issued an emergency update for its Flash media player that patches almost two dozen critical vulnerabilities, including one that's ...

‘The Elder Scrolls Online’ On PC Updates With ‘Thieves Guild’ DLC, Major Content Patch, And 64-Bit Client ...
Sneaking around the guards, deftly pickpocketing the locals, and taking anything else that is not nailed down are staples of thievery in the ...

Resources last updated: 3/11/2016 2:07:51 PM