superreview requested: [Bug 362173] The NSS cryptographic module should have its own version numbers. : [Attachment 247256] Add NSS 3.11.4's nss.h to lib/freebl and lib/softoken

Wan-Teh Chang <wtchang@redhat.com> has asked Robert Relyea <rrelyea@redhat.com>
for superreview:
Bug 362173: The NSS cryptographic module should have its own version numbers.
https://bugzilla.mozilla.org/show_bug.cgi?id=362173

Attachment 247256: Add NSS 3.11.4's nss.h to lib/freebl and lib/softoken
https://bugzilla.mozilla.org/attachment.cgi?id=247256&action=edit

------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com>
This is a workaround for the NSS_3_11_BRANCH only,
to avoid changing any file in lib/freebl and lib/softoken.

I found that if there is an nss.h file in the current
directory, the compiler (on all platforms) will use that
instead of the nss.h file found in any of the directories
specified by the -I flags.

So if we add the nss.h file from NSS_3_11_4_RTM to the
lib/freebl and lib/softoken directories, that copy of nss.h
will get used when we are compiling in lib/freebl and
lib/softoken.
0
bugzilla
12/2/2006 9:01:01 AM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
283 Views

Similar Articles

[PageSpeed] 38

Reply:

Similar Artilces:

superreview cancelled: [Bug 362173] The NSS cryptographic module should have its own version numbers. : [Attachment 247256] Add NSS 3.11.4's nss.h to lib/freebl and lib/softoken
Wan-Teh Chang <wtchang@redhat.com> has cancelled Wan-Teh Chang <wtchang@redhat.com>'s request for superreview: Bug 362173: The NSS cryptographic module should have its own version numbers. https://bugzilla.mozilla.org/show_bug.cgi?id=362173 Attachment 247256: Add NSS 3.11.4's nss.h to lib/freebl and lib/softoken https://bugzilla.mozilla.org/attachment.cgi?id=247256&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> Nelson, I'm proposing this patch for the NSS_3_11_BRANCH because it is much easier to explain what the pat...

superreview requested: [Bug 362173] The NSS cryptographic module should have its own version numbers. : [Attachment 246876] Proposed patch
Wan-Teh Chang <wtchang@redhat.com> has asked Neil Williams <neil.williams@sun.com> for superreview: Bug 362173: The NSS cryptographic module should have its own version numbers. https://bugzilla.mozilla.org/show_bug.cgi?id=362173 Attachment 246876: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=246876&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> Add a new header file, cryptmod.h, that defines the macros for the NSS cryptographic module's version numbers. Change the files to include cryptmod.h instead of ...

superreview requested: [Bug 362173] The NSS cryptographic module should have its own version numbers. : [Attachment 246995] Proposed patch v2
Wan-Teh Chang <wtchang@redhat.com> has asked Neil Williams <neil.williams@sun.com> for superreview: Bug 362173: The NSS cryptographic module should have its own version numbers. https://bugzilla.mozilla.org/show_bug.cgi?id=362173 Attachment 246995: Proposed patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=246995&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> In this patch, cryptmod.h is renamed softkver.h and moved to lib/softoken, and the CRYPTO_MODULE_xxx macros are renamed SOFTOKEN_xxx. ...

superreview requested: [Bug 449883] Replace existing "GlobalSign Root CA" cert and add new WellsSecure cert : [Attachment 333011] Patch v1 for both NSS 3.12x and NSS 3.11.x
Kai Engert (:kaie, kengert@redhat.com) <kaie@kuix.de> has asked Nelson Bolyard (:MisterSSL) <nelson@bolyard.com> for superreview: Bug 449883: Replace existing "GlobalSign Root CA" cert and add new WellsSecure cert https://bugzilla.mozilla.org/show_bug.cgi?id=449883 Attachment 333011: Patch v1 for both NSS 3.12x and NSS 3.11.x https://bugzilla.mozilla.org/attachment.cgi?id=333011&action=edit ...

superreview requested: [Bug 320583] NSS ECDSA can only sign SHA-1 : [Attachment 208799] Incorporate WTC and Nelson's comments. 3.11 version
Robert Relyea <rrelyea@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 320583: NSS ECDSA can only sign SHA-1 https://bugzilla.mozilla.org/show_bug.cgi?id=320583 Attachment 208799: Incorporate WTC and Nelson's comments. 3.11 version https://bugzilla.mozilla.org/attachment.cgi?id=208799&action=edit ------- Additional Comments from Robert Relyea <rrelyea@redhat.com> Some notes: I did not pick up the 3.12 version of decodeECorDSASignature() because the meaning of the paramters have changed between those 2 versions. The algid is ...

superreview requested: [Bug 320583] NSS ECDSA can only sign SHA-1 : [Attachment 206556] NSS 3.11 version of this patch
Robert Relyea <rrelyea@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 320583: NSS ECDSA can only sign SHA-1 https://bugzilla.mozilla.org/show_bug.cgi?id=320583 Attachment 206556: NSS 3.11 version of this patch https://bugzilla.mozilla.org/attachment.cgi?id=206556&action=edit ------- Additional Comments from Robert Relyea <rrelyea@redhat.com> Unlike the Tip patch, this patch does not add any new external APIs. This means that non-NSS programs will still not be able to handle ECC_SPECIFY type oids. Particularly gross things abo...

superreview requested: [Bug 239827] NSS has race condition in unwrap key code. : [Attachment 145559] Add the appropriate locks.
Wan-Teh Chang <wchang0222@aol.com> has asked Nelson Bolyard <MisterSSL@aol.com> for superreview: Bug 239827: NSS has race condition in unwrap key code. http://bugzilla.mozilla.org/show_bug.cgi?id=239827 Attachment 145559: Add the appropriate locks. - Version NSS 3.7 http://bugzilla.mozilla.org/attachment.cgi?id=145559&action=edit ------- Additional Comments from Wan-Teh Chang <wchang0222@aol.com> r=wtc. ...

superreview cancelled: [Bug 288647] NSS doesn't build --with-system-nspr : [Attachment 189377] NSS patch v1.1 (checked in to NSS 3.11)
Nelson Bolyard <nelson@bolyard.com> has cancelled Wan-Teh Chang <wtchang@redhat.com>'s request for superreview: Bug 288647: NSS doesn't build --with-system-nspr https://bugzilla.mozilla.org/show_bug.cgi?id=288647 Attachment 189377: NSS patch v1.1 (checked in to NSS 3.11) https://bugzilla.mozilla.org/attachment.cgi?id=189377&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> Looking at the "my requests" page in BMO, I see that a review was requested of me a week ago. I never saw any email about it. Sorry. I rely...

superreview requested: [Bug 298537] softoken PKCS#11 version is incorrect : [Attachment 187086] Use the version macros defined in nss.h
Wan-Teh Chang <wtchang@redhat.com> has asked Robert Relyea <rrelyea@redhat.com> for superreview: Bug 298537: softoken PKCS#11 version is incorrect https://bugzilla.mozilla.org/show_bug.cgi?id=298537 Attachment 187086: Use the version macros defined in nss.h https://bugzilla.mozilla.org/attachment.cgi?id=187086&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> Some interesting info. That version has been 3.2, 3.6, 3.7, 3.8. The changes to 3.6, 3.7, and 3.8 were all done by Julien, in rev. 1.61 (bug 172732), rev. 1.62, and re...

superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195953] Wan-Teh's code cleanup patch for lib/freebl/loader.c
Wan-Teh Chang <wtchang@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 195953: Wan-Teh's code cleanup patch for lib/freebl/loader.c https://bugzilla.mozilla.org/attachment.cgi?id=195953&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> 1. Structure the ifdefs around the definitions of getLibName like this: #if defined(SOLARIS) && defined(__sparc) ... #e...

superreview cancelled: [Bug 362173] The NSS cryptographic module should have its own version numbers. : [Attachment 246876] Proposed patch
Wan-Teh Chang <wtchang@redhat.com> has cancelled Wan-Teh Chang <wtchang@redhat.com>'s request for superreview: Bug 362173: The NSS cryptographic module should have its own version numbers. https://bugzilla.mozilla.org/show_bug.cgi?id=362173 Attachment 246876: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=246876&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> In this patch, cryptmod.h is renamed softkver.h and moved to lib/softoken, and the CRYPTO_MODULE_xxx macros are renamed SOFTOKEN_xxx. ...

superreview granted: [Bug 362173] The NSS cryptographic module should have its own version numbers. : [Attachment 246876] Proposed patch
Neil Williams <neil.williams@sun.com> has granted superreview: Bug 362173: The NSS cryptographic module should have its own version numbers. https://bugzilla.mozilla.org/show_bug.cgi?id=362173 Attachment 246876: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=246876&action=edit ------- Additional Comments from Neil Williams <neil.williams@sun.com> Looks good as far as it goes. ...

superreview granted: [Bug 362173] The NSS cryptographic module should have its own version numbers. : [Attachment 246995] Proposed patch v2
Neil Williams <neil.williams@sun.com> has granted Wan-Teh Chang <wtchang@redhat.com>'s request for superreview: Bug 362173: The NSS cryptographic module should have its own version numbers. https://bugzilla.mozilla.org/show_bug.cgi?id=362173 Attachment 246995: Proposed patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=246995&action=edit ...

superreview requested: [Bug 245518] NSS tools should have an rpath of /usr/lib/mps/secv1 : [Attachment 159228] Compact the RPATH option for each case, add /usr/lib/mps for Sun
Saul Edwards <saul.edwards.bugs@sun.com> has asked Wan-Teh Chang <wchang0222@aol.com> for superreview: Bug 245518: NSS tools should have an rpath of /usr/lib/mps/secv1 http://bugzilla.mozilla.org/show_bug.cgi?id=245518 Attachment 159228: Compact the RPATH option for each case, add /usr/lib/mps for Sun http://bugzilla.mozilla.org/attachment.cgi?id=159228&action=edit ...

Web resources about - superreview requested: [Bug 362173] The NSS cryptographic module should have its own version numbers. : [Attachment 247256] Add NSS 3.11.4's nss.h to lib/freebl and lib/softoken - mozilla.dev.super-review

Cryptographic hash function - Wikipedia, the free encyclopedia
A cryptographic hash function (specifically, SHA-1 ) at work. Note that even small changes in the source input (here in the word "over") drastically ...

secure cryptographic - News, Features, and Slideshows
Latest news, features, and slideshows on secure cryptographic from CSO

iOS 6: Apple FIPS iOS Cryptographic Modules v3.0
Learn about FIPS in iOS 6. The iOS Cryptographic Modules, Apple iOS CoreCrypto Module v3.0, and Apple iOS CoreCrypto Kernel Module v3.0, require ...

Cryptographic certification could lead to wider iPhone use in government
Apple's iPhone might see wider adoption in government use, thanks to the recent validation of a cryptographic module for iOS.

Scientists crack RSA SecurID 800 tokens, steal cryptographic keys
RSA's SecurID 800 is one of at least five commercially available security devices susceptible to a new attack that extracts cryptographic keys ...

Sensitive cryptographic gear could slow recovery of Cygnus cargo
... was carrying an unmanned Cygnus spacecraft with about 5,000 pounds of cargo on board including classified equipment that uses sensitive cryptographic ...

Cryptographic currency
MATT Green would like you to think of Zerocoin, a Bitcoin-like alternative currency in the process of finalising its specifications, as a bulletin ...

NIST to review its cryptographic standards, hopes to regain trust in wake of NSA scandals
Whoever said that there's no such thing as bad press should talk to the NIST it says that "recent news reports about classified documents" are ...

Logjam SSL/TLS Vulnerability Exposes Cryptographic Weakness
The Logjam flaw is due to a vulnerability in the TLS protocol and puts the widely deployed Diffie-Hellman key exchange at risk, exposing Web ...

New Xerox PARC processor can self-destruct, destroy cryptographic keys on command
A new cryptographic processor from DARPA could store keys inside a chip on a glass substrate and shatter when ordered to do so, locking the keys ...

Resources last updated: 11/26/2015 7:02:14 AM