superreview requested: [Bug 361545] Last line not selected when dragging downwards to following whitespace, in certain cases of Bidi with letter-spacing, word-spacing, etc. : [Attachment 246320] patc

Uri Bernstein (mostly gone) <uriber@gmail.com> has asked Robert O'Callahan
(Novell) <roc@ocallahan.org> for superreview:
Bug 361545: Last line not selected when dragging downwards to following
whitespace, in certain cases of Bidi with letter-spacing, word-spacing, etc.
https://bugzilla.mozilla.org/show_bug.cgi?id=361545

Attachment 246320: patch (diff -w)
https://bugzilla.mozilla.org/attachment.cgi?id=246320&action=edit

------- Additional Comments from Uri Bernstein (mostly gone) <uriber@gmail.com>
I guess we can fix it by not failing on empty frames in GetPositionSlowly() - I
noticed that I had introduced the exact same change to GetPositionHelper() in
bug 298690 (for different reasons).

Rob, is this worth getting in, or is this method going to be blown out by your
nsTextFrame rewrite anyway?
0
bugzilla
11/22/2006 8:03:44 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
1503 Views

Similar Articles

[PageSpeed] 57

Reply: