superreview requested: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237072] Maybe better

Blake Kaplan <mrbkap@gmail.com> has asked Brendan Eich <brendan@mozilla.org>
for superreview:
Bug 351606: nested for..in and throw causes "Assertion failure:
OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate]
https://bugzilla.mozilla.org/show_bug.cgi?id=351606

Attachment 237072: Maybe better
https://bugzilla.mozilla.org/attachment.cgi?id=237072&action=edit

------- Additional Comments from Blake Kaplan <mrbkap@gmail.com>
The last patch did the wrong thing if the only object on fp->blockChain had a
NULL parent.
0
bugzilla
9/7/2006 5:37:21 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
294 Views

Similar Articles

[PageSpeed] 59

Reply:

Similar Artilces:

superreview granted: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237072] Maybe better
Brendan Eich <brendan@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 351606: nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] https://bugzilla.mozilla.org/show_bug.cgi?id=351606 Attachment 237072: Maybe better https://bugzilla.mozilla.org/attachment.cgi?id=237072&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Looks good to me again, but I'm not counting for much here. Igor's r+ counts....

superreview requested: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237063] Updated
Blake Kaplan <mrbkap@gmail.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 351606: nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] https://bugzilla.mozilla.org/show_bug.cgi?id=351606 Attachment 237063: Updated https://bugzilla.mozilla.org/attachment.cgi?id=237063&action=edit ...

superreview granted: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237063] Updated
Brendan Eich <brendan@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 351606: nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] https://bugzilla.mozilla.org/show_bug.cgi?id=351606 Attachment 237063: Updated https://bugzilla.mozilla.org/attachment.cgi?id=237063&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Need to get this into the trunk pretty quickly. /be ...

superreview requested: [Bug 422009] [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler : [Attachment 310421] Fix
Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> has asked Johnny Stenback (:jst) <jst@mozilla.org> for superreview: Bug 422009: [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler https://bugzilla.mozilla.org/show_bug.cgi?id=422009 Attachment 310421: Fix https://bugzilla.mozilla.org/attachment.cgi?id=310421&action=edit ...

superreview granted: [Bug 422009] [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler : [Attachment 310421] Fix
Johnny Stenback (:jst) <jst@mozilla.org> has granted Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu>'s request for superreview: Bug 422009: [FIX]"Assertion failure: !cx->throwing" with XBL constructor that throws and syntax error in event handler https://bugzilla.mozilla.org/show_bug.cgi?id=422009 Attachment 310421: Fix https://bugzilla.mozilla.org/attachment.cgi?id=310421&action=edit ...

superreview requested: [Bug 418133] "Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> : [Attachment 306201] Possible patch
Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 418133: "Assertion failure: !JS_IsExceptionPending(cx)" with <xul:preferences> https://bugzilla.mozilla.org/show_bug.cgi?id=418133 Attachment 306201: Possible patch https://bugzilla.mozilla.org/attachment.cgi?id=306201&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until May) <bzbarsky@mit.edu> If this patch fails mochitest, I'll be very very surprised! If this fixes the bug, let...

superreview requested: [Bug 427928] "ASSERTION: Non-border-colors case with borderColorStyleCount < 1 or > 3" and "ASSERTION: Unhandled border style" with <table style="outline: auto; "></table> : [At
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 427928: "ASSERTION: Non-border-colors case with borderColorStyleCount < 1 or > 3" and "ASSERTION: Unhandled border style" with <table style="outline: auto;"></table> https://bugzilla.mozilla.org/show_bug.cgi?id=427928 Attachment 314802: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=314802&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Not sure...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 137491] (Cv2) <Wallet*.*> (+ <*pref*>)
Serge GAUTHERIE <gautheri@noos.fr> has asked Ben Goodger (I don't read bugmail) <bugs@bengoodger.com> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 137491: (Cv2) <Wallet*.*> (+ <*pref*>) http://bugzilla.mozilla.org/attachment.cgi?id=137491&action=edit ...

superreview requested: [Bug 436195] "ASSERTION: invalid min or max param: 'min <= max && min > 0'" when accessing a newsgroup : [Attachment 322870] Patch to fix the issue
Joshua Cranmer [:jcranmer] <Pidgeot18@gmail.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 436195: "ASSERTION: invalid min or max param: 'min <= max && min > 0'" when accessing a newsgroup https://bugzilla.mozilla.org/show_bug.cgi?id=436195 Attachment 322870: Patch to fix the issue https://bugzilla.mozilla.org/attachment.cgi?id=322870&action=edit ------- Additional Comments from Joshua Cranmer [:jcranmer] <Pidgeot18@gmail.com> Patch as promised in previous comment. ...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 137239] (Cv1c) <WalletViewer.* ++>
Serge GAUTHERIE <gautheri@noos.fr> has asked Ben Goodger (I don't read bugmail) <bugs@bengoodger.com> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 137239: (Cv1c) <WalletViewer.* ++> http://bugzilla.mozilla.org/attachment.cgi?id=137239&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'approval1.6=?': Trivial U.I. code cleanup. ...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 137678] (Cv2b) <Wallet*.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Ben Goodger (I don't read bugmail) <bugs@bengoodger.com> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 137678: (Cv2b) <Wallet*.*> http://bugzilla.mozilla.org/attachment.cgi?id=137678&action=edit ...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 136988] (Cv1) <WalletViewer.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Ben Goodger (I don't read bugmail) <bugs@bengoodger.com> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 136988: (Cv1) <WalletViewer.*> http://bugzilla.mozilla.org/attachment.cgi?id=136988&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> I tested Cancel/Help buttons only. I wonder about the purpose of |window.doneLoading = fals...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 137197] (Cv2) <WalletViewer.* ++>
Serge GAUTHERIE <gautheri@noos.fr> has asked Ben Goodger (I don't read bugmail) <bugs@bengoodger.com> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 137197: (Cv2) <WalletViewer.* ++> http://bugzilla.mozilla.org/attachment.cgi?id=137197&action=edit ...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 137732] (Cv2c) <Wallet*.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Alec Flett <alecf@flett.org> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 137732: (Cv2c) <Wallet*.*> http://bugzilla.mozilla.org/attachment.cgi?id=137732&action=edit ...

Web resources about - superreview requested: [Bug 351606] nested for..in and throw causes "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" [@ JS_SetPrivate] : [Attachment 237072] Maybe better - mozilla.dev.super-review

Resources last updated: 11/21/2015 5:28:05 AM