superreview requested: [Bug 351443] Remove unused code from mozilla/security/nss/lib/jar : [Attachment 236819] Patch to remove unused code

Ehsan Akhgari <ehsan.akhgari@gmail.com> has asked Alexei Volkov
<alexei.volkov.bugs@sun.com> for superreview:
Bug 351443: Remove unused code from mozilla/security/nss/lib/jar
https://bugzilla.mozilla.org/show_bug.cgi?id=351443

Attachment 236819: Patch to remove unused code
https://bugzilla.mozilla.org/attachment.cgi?id=236819&action=edit

------- Additional Comments from Ehsan Akhgari <ehsan.akhgari@gmail.com>
This patch simply removes the code blocks as mentioned in comment #0.  It
should not have any affects on the code that actually gets executed, since the
removed parts have been removed by the compiler anyway.
0
bugzilla
9/5/2006 5:49:48 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
611 Views

Similar Articles

[PageSpeed] 30

Reply:

Similar Artilces:

superreview requested: [Bug 291123] remove unused MOZ_THREADSAFE_RDF and locks from nsInMemoryDataSource : [Attachment 181288] remove unused lock code from nsInMemoryDataSource
Axel Hecht <axel@pike.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 291123: remove unused MOZ_THREADSAFE_RDF and locks from nsInMemoryDataSource https://bugzilla.mozilla.org/show_bug.cgi?id=291123 Attachment 181288: remove unused lock code from nsInMemoryDataSource https://bugzilla.mozilla.org/attachment.cgi?id=181288&action=edit ...

superreview requested: [Bug 216075] Remove unused uuencode code from mailnews compose : [Attachment 330998] remove the uudecode code from mimedrft
David Bienvenu <bienvenu@nventure.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 216075: Remove unused uuencode code from mailnews compose https://bugzilla.mozilla.org/show_bug.cgi?id=216075 Attachment 330998: remove the uudecode code from mimedrft https://bugzilla.mozilla.org/attachment.cgi?id=330998&action=edit ...

superreview requested: [Bug 348238] Remove some unused code from ESM : [Attachment 233095] Removing some code which isn't used anymore.
Smaug <Olli.Pettay@gmail.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 348238: Remove some unused code from ESM https://bugzilla.mozilla.org/show_bug.cgi?id=348238 Attachment 233095: Removing some code which isn't used anymore. https://bugzilla.mozilla.org/attachment.cgi?id=233095&action=edit ...

superreview granted: [Bug 216075] Remove unused uuencode code from mailnews compose : [Attachment 330998] remove the uudecode code from mimedrft
neil@parkwaycc.co.uk <neil@httl.net> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 216075: Remove unused uuencode code from mailnews compose https://bugzilla.mozilla.org/show_bug.cgi?id=216075 Attachment 330998: remove the uudecode code from mimedrft https://bugzilla.mozilla.org/attachment.cgi?id=330998&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> You could have just said "yes" then I could have said "sr=me with the smime changes from the first patch" ;-) ...

superreview granted: [Bug 291123] remove unused MOZ_THREADSAFE_RDF and locks from nsInMemoryDataSource : [Attachment 181288] remove unused lock code from nsInMemoryDataSource
Brendan Eich <brendan@mozilla.org> has granted Axel Hecht <axel@pike.org>'s request for superreview: Bug 291123: remove unused MOZ_THREADSAFE_RDF and locks from nsInMemoryDataSource https://bugzilla.mozilla.org/show_bug.cgi?id=291123 Attachment 181288: remove unused lock code from nsInMemoryDataSource https://bugzilla.mozilla.org/attachment.cgi?id=181288&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> rs=brendan@mozilla.org. /be ...

superreview granted: [Bug 348238] Remove some unused code from ESM : [Attachment 233095] Removing some code which isn't used anymore.
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Smaug <Olli.Pettay@gmail.com>'s request for superreview: Bug 348238: Remove some unused code from ESM https://bugzilla.mozilla.org/show_bug.cgi?id=348238 Attachment 233095: Removing some code which isn't used anymore. https://bugzilla.mozilla.org/attachment.cgi?id=233095&action=edit ...

superreview requested: [Bug 410792] Remove unused FEUnimplementedMOZElement code : [Attachment 295367] patch
Robert Longson <longsonr@gmail.com> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 410792: Remove unused FEUnimplementedMOZElement code https://bugzilla.mozilla.org/show_bug.cgi?id=410792 Attachment 295367: patch https://bugzilla.mozilla.org/attachment.cgi?id=295367&action=edit ------- Additional Comments from Robert Longson <longsonr@gmail.com> Now that the last two filters have landed FEUnimplementedMOZElement is no longer used. ...

superreview requested: [Bug 314679] remove a bit unused code from nsObjectFrame : [Attachment 201569] patch
Christian Biesinger (:bi) (reviews slower than usual) <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 314679: remove a bit unused code from nsObjectFrame https://bugzilla.mozilla.org/show_bug.cgi?id=314679 Attachment 201569: patch https://bugzilla.mozilla.org/attachment.cgi?id=201569&action=edit ...

superreview requested: [Bug 216075] Remove unused uuencode code from mailnews compose : [Attachment 330335] get rid of uuencode code
David Bienvenu <bienvenu@nventure.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 216075: Remove unused uuencode code from mailnews compose https://bugzilla.mozilla.org/show_bug.cgi?id=216075 Attachment 330335: get rid of uuencode code https://bugzilla.mozilla.org/attachment.cgi?id=330335&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> this code hasn't been used for a long time. The one potential issue is editing drafts that had uuencoded attachments, but I think that's OK. ...

superreview requested: [Bug 281744] Remove dead code and silly plugin code : [Attachment 173910] Remove silly code
Johnny Stenback <jst@mozilla.org> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 281744: Remove dead code and silly plugin code https://bugzilla.mozilla.org/show_bug.cgi?id=281744 Attachment 173910: Remove silly code https://bugzilla.mozilla.org/attachment.cgi?id=173910&action=edit ...

superreview requested: [Bug 208607] Reconfigure libpng for smaller imglib2 : [Attachment 128475] Updated patch to remove another 5k of unused libpng code
Glenn Randers-Pehrson <randeg@alum.rpi.edu> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 208607: Reconfigure libpng for smaller imglib2 http://bugzilla.mozilla.org/show_bug.cgi?id=208607 Attachment 128475: Updated patch to remove another 5k of unused libpng code http://bugzilla.mozilla.org/attachment.cgi?id=128475&action=edit ------- Additional Comments from Glenn Randers-Pehrson <randeg@alum.rpi.edu> r? tor; sr? pavlov Also let me know if you want the patch to optionally remove error message text, either as a separate patch or adde...

superreview requested: [Bug 208607] Reconfigure libpng for smaller imglib2 : [Attachment 128475] Updated patch to remove another 5k of unused libpng code #2
Glenn Randers-Pehrson <randeg@alum.rpi.edu> has asked tor@acm.org for superreview: Bug 208607: Reconfigure libpng for smaller imglib2 http://bugzilla.mozilla.org/show_bug.cgi?id=208607 Attachment 128475: Updated patch to remove another 5k of unused libpng code http://bugzilla.mozilla.org/attachment.cgi?id=128475&action=edit ------- Additional Comments from Glenn Randers-Pehrson <randeg@alum.rpi.edu> Whatever. I thought Stuart owned libimg and therefore was higher on the pecking order. pav: r? tor: sr? ...

superreview requested: [Bug 170615] eliminate use of nsAutoString in parser attribute token : [Attachment 100484] patch v1.0 [ reduce attr token size and removed unused code ]
Simon 'sipaq' Paquet <bugzilla@babylonsounds.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 170615: eliminate use of nsAutoString in parser attribute token http://bugzilla.mozilla.org/show_bug.cgi?id=170615 Attachment 100484: patch v1.0 [ reduce attr token size and removed unused code ] http://bugzilla.mozilla.org/attachment.cgi?id=100484&action=edit ------- Additional Comments from Simon 'sipaq' Paquet <bugzilla@babylonsounds.com> Asking for reviews ...

superreview requested: [Bug 357530] Remove dead code from DraggableImageAndTextCell : [Attachment 243037] removes dead code
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 357530: Remove dead code from DraggableImageAndTextCell https://bugzilla.mozilla.org/show_bug.cgi?id=357530 Attachment 243037: removes dead code https://bugzilla.mozilla.org/attachment.cgi?id=243037&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Simon, since you're listed as the author I figure you're in the best position to know if there's any downside I'm missing to doing this. ...

superreview requested: [Bug 242212] Remove useless nsISecurityCheckedComponent code from nsXULTemplateBuilder : [Attachment 147401] remove code
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 242212: Remove useless nsISecurityCheckedComponent code from nsXULTemplateBuilder http://bugzilla.mozilla.org/show_bug.cgi?id=242212 Attachment 147401: remove code http://bugzilla.mozilla.org/attachment.cgi?id=147401&action=edit ...

Web resources about - superreview requested: [Bug 351443] Remove unused code from mozilla/security/nss/lib/jar : [Attachment 236819] Patch to remove unused code - mozilla.dev.super-review

Resources last updated: 12/28/2015 3:00:12 AM