superreview requested: [Bug 346029] try-finally where try throws runs finally with exception pending : [Attachment 230825] fix

Brendan Eich <brendan@mozilla.org> has asked Mike Shaver <shaver@mozilla.org>
for superreview:
Bug 346029: try-finally where try throws runs finally with exception pending
https://bugzilla.mozilla.org/show_bug.cgi?id=346029

Attachment 230825: fix
https://bugzilla.mozilla.org/attachment.cgi?id=230825&action=edit

------- Additional Comments from Brendan Eich <brendan@mozilla.org>
Shaver, it would be great if you could give this a look too.

/be
0
bugzilla
7/27/2006 12:52:20 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
497 Views

Similar Articles

[PageSpeed] 37

Reply:

Similar Artilces:

superreview granted: [Bug 346029] try-finally where try throws runs finally with exception pending : [Attachment 230825] fix
Mike Shaver <shaver@mozilla.org> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 346029: try-finally where try throws runs finally with exception pending https://bugzilla.mozilla.org/show_bug.cgi?id=346029 Attachment 230825: fix https://bugzilla.mozilla.org/attachment.cgi?id=230825&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> sr=shaver ...

superreview requested: [Bug 258699] CipherContentProxy finalize must call super.finalize : [Attachment 159101] Add finalize to CipherContentProxy
Saul Edwards <saul.edwards.bugs@sun.com> has asked Wan-Teh Chang <wchang0222@aol.com> for superreview: Bug 258699: CipherContentProxy finalize must call super.finalize http://bugzilla.mozilla.org/show_bug.cgi?id=258699 Attachment 159101: Add finalize to CipherContentProxy http://bugzilla.mozilla.org/attachment.cgi?id=159101&action=edit ...

superreview requested: [Bug 56764] Document appendChild, insertBefore fail to throw HIERARCHY_REQUEST_ERR when inserting Text Nodes : [Attachment 133757] Throw exception if trying to insert docType
Peter Van der Beken <peterv@propagandism.org> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 56764: Document appendChild, insertBefore fail to throw HIERARCHY_REQUEST_ERR when inserting Text Nodes http://bugzilla.mozilla.org/show_bug.cgi?id=56764 Attachment 133757: Throw exception if trying to insert docType after documentElement http://bugzilla.mozilla.org/attachment.cgi?id=133757&action=edit ...

superreview requested: [Bug 364109] Switch to @try, @catch, @ finally exception macros
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 364109: Switch to @try, @catch, @finally exception macros https://bugzilla.mozilla.org/show_bug.cgi?id=364109 Attachment 277205: fix https://bugzilla.mozilla.org/attachment.cgi?id=277205&action=edit ...

superreview requested: [Bug 208920] If the Print command is issued, the browser crashes : [Attachment 134747] final fixes from camino branch which fix bug
Mike Pinkerton <pinkerton@aol.net> has asked Simon Fraser <sfraser@aol.net> for superreview: Bug 208920: If the Print command is issued, the browser crashes http://bugzilla.mozilla.org/show_bug.cgi?id=208920 Attachment 134747: final fixes from camino branch which fix bug http://bugzilla.mozilla.org/attachment.cgi?id=134747&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> need r/sr for changes leftover from camino branch. ...

superreview requested: [Bug 307317] JS engine assert when running with WAY_TOO_MUCH_GC : [Attachment 195302] try to fix xpconnect
Brendan Eich <brendan@mozilla.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 307317: JS engine assert when running with WAY_TOO_MUCH_GC https://bugzilla.mozilla.org/show_bug.cgi?id=307317 Attachment 195302: try to fix xpconnect https://bugzilla.mozilla.org/attachment.cgi?id=195302&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> bz, can you try these two patches and see how much further your WAY_TOO_MUCH_GC build gets? Thanks, /be ...

superreview requested: [Bug 342235] [FIX]XBL method trying to use event parameter gets exception : [Attachment 226497] Like so
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 342235: [FIX]XBL method trying to use event parameter gets exception https://bugzilla.mozilla.org/show_bug.cgi?id=342235 Attachment 226497: Like so https://bugzilla.mozilla.org/attachment.cgi?id=226497&action=edit ...

superreview requested: [Bug 319490] js1_5/Regress/regress-104077
Mike Shaver <shaver@mozilla.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 319490: js1_5/Regress/regress-104077 - return in finally should clear pending exception https://bugzilla.mozilla.org/show_bug.cgi?id=319490 Attachment 206305: patch https://bugzilla.mozilla.org/attachment.cgi?id=206305&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> This seems to fix the issue, though I haven't run the browser-requiring test. cx->throwing is cleared after returning from my simple test function, though, and ...

superreview requested: [Bug 214949] XUL error pages have no content except for Try Again link : [Attachment 129337] Fix (diff -w)
Christopher A. Aillon <caillon@aillon.org> has asked Johnny Stenback <jst@netscape.com> for superreview: Bug 214949: XUL error pages have no content except for Try Again link http://bugzilla.mozilla.org/show_bug.cgi?id=214949 Attachment 129337: Fix (diff -w) http://bugzilla.mozilla.org/attachment.cgi?id=129337&action=edit ------- Additional Comments from Christopher A. Aillon <caillon@aillon.org> I'm just attaching a diff -w since it should be enough for reviewing this patch. Let me know if you want a normal diff as well. ...

superreview requested: [Bug 342235] [FIX]XBL method trying to use event parameter gets exception : [Attachment 226497] Like so #2
Mark Hammond <mhammond@skippinet.com.au> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 342235: [FIX]XBL method trying to use event parameter gets exception https://bugzilla.mozilla.org/show_bug.cgi?id=342235 Attachment 226497: Like so https://bugzilla.mozilla.org/attachment.cgi?id=226497&action=edit ...

superreview granted: [Bug 258699] CipherContentProxy finalize must call super.finalize : [Attachment 159101] Add finalize to CipherContentProxy
Wan-Teh Chang <wchang0222@aol.com> has granted Saul Edwards <saul.edwards.bugs@sun.com>'s request for superreview: Bug 258699: CipherContentProxy finalize must call super.finalize http://bugzilla.mozilla.org/show_bug.cgi?id=258699 Attachment 159101: Add finalize to CipherContentProxy http://bugzilla.mozilla.org/attachment.cgi?id=159101&action=edit ------- Additional Comments from Wan-Teh Chang <wchang0222@aol.com> r=wtc. Make sure you also get a review from Glen. ...

superreview requested: [Bug 227263] trying to get domain from document when URL is about:blank produces "uncaught exception" : [Attachment 140104] Fix.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 227263: trying to get domain from document when URL is about:blank produces "uncaught exception" http://bugzilla.mozilla.org/show_bug.cgi?id=227263 Attachment 140104: Fix. http://bugzilla.mozilla.org/attachment.cgi?id=140104&action=edit ...

superreview requested: [Bug 319490] js1_5/Regress/regress-104077
Mike Shaver <shaver@mozilla.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 319490: js1_5/Regress/regress-104077 - return in finally should clear pending exception https://bugzilla.mozilla.org/show_bug.cgi?id=319490 Attachment 206312: how ya like me now? https://bugzilla.mozilla.org/attachment.cgi?id=206312&action=edit ...

superreview requested: [Bug 424449] Trying to access window.closed (after using window.open) throws "Illegal operation on WrappedNative prototype object" : [Attachment 311686] Fix.
Johnny Stenback (:jst) <jst@mozilla.org> has asked Blake Kaplan <mrbkap@gmail.com> for superreview: Bug 424449: Trying to access window.closed (after using window.open) throws "Illegal operation on WrappedNative prototype object" https://bugzilla.mozilla.org/show_bug.cgi?id=424449 Attachment 311686: Fix. https://bugzilla.mozilla.org/attachment.cgi?id=311686&action=edit ------- Additional Comments from Johnny Stenback (:jst) <jst@mozilla.org> This fixes this bug. The problem is that our XOWs remember what they've resolved, even though what they r...

Web resources about - superreview requested: [Bug 346029] try-finally where try throws runs finally with exception pending : [Attachment 230825] fix - mozilla.dev.super-review

Resources last updated: 12/11/2015 7:32:45 AM