superreview requested: [Bug 340373] Escape key should cancel "send in Unicode (UTF-8)?" dialog : [Attachment 226042] use button 1 for cancel instead of button 2 #2

Gavin Sharp <gavin.sharp@gmail.com> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 340373: Escape key should cancel "send in Unicode (UTF-8)?" dialog
https://bugzilla.mozilla.org/show_bug.cgi?id=340373

Attachment 226042: use button 1 for cancel instead of button 2
https://bugzilla.mozilla.org/attachment.cgi?id=226042&action=edit
0
bugzilla
6/18/2006 7:35:36 AM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
682 Views

Similar Articles

[PageSpeed] 43

Reply:

Similar Artilces:

superreview requested: [Bug 340373] Escape key should cancel "send in Unicode (UTF-8)?" dialog : [Attachment 226042] use button 1 for cancel instead of button 2
Gavin Sharp <gavin.sharp@gmail.com> has asked for superreview: Bug 340373: Escape key should cancel "send in Unicode (UTF-8)?" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=340373 Attachment 226042: use button 1 for cancel instead of button 2 https://bugzilla.mozilla.org/attachment.cgi?id=226042&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> commonDialog.js sets the cancel button to the button at index 1 in the button flags, so POS_1 should be used for the cancel button. The only implementation that I tested was the...

superreview granted: [Bug 340373] Escape key should cancel "send in Unicode (UTF-8)?" dialog : [Attachment 226042] use button 1 for cancel instead of button 2
David Bienvenu <bienvenu@nventure.com> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 340373: Escape key should cancel "send in Unicode (UTF-8)?" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=340373 Attachment 226042: use button 1 for cancel instead of button 2 https://bugzilla.mozilla.org/attachment.cgi?id=226042&action=edit ...

superreview cancelled: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156223] use OK/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has cancelled Steffen Wilberg <steffen.wilberg@web.de>'s request for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156223: use OK/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156223&action=edit ...

superreview requested: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156227] use Grant/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156227: use Grant/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156227&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Grant/Cancel is better indeed. ...

superreview requested: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156223] use OK/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156223: use OK/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156223&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Brian, this is really simple, yet a 1.0PR blocker. ...

superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #2
Steuard Jensen <steuard+mozilla@slimy.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit ...

superreview requested: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174078] proposed patch #2
Daniel Brooks <db48x@yahoo.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174078: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=174078&action=edit ------- Additional Comments from Daniel Brooks <db48x@yahoo.com> >- <key key="&selectall.key;" modifiers="alt" command="cmd_selectall"/> �...

superreview requested: [Bug 311503] Safe Mode UI: closing or cancelling the dialog should quit Firefox : [Attachment 198807] Add "cancel" button, rev. 1
Benjamin Smedberg [:bs] <benjamin@smedbergs.us> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 311503: Safe Mode UI: closing or cancelling the dialog should quit Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=311503 Attachment 198807: Add "cancel" button, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=198807&action=edit ...

superreview requested: [Bug 157067] Inconsistency in appearance of "Move Up" and "Move Down" buttons : [Attachment 145778] Makes buttons and access keys in Filter List consistent with the rest of Sea #2
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 157067: Inconsistency in appearance of "Move Up" and "Move Down" buttons http://bugzilla.mozilla.org/show_bug.cgi?id=157067 Attachment 145778: Makes buttons and access keys in Filter List consistent with the rest of Seamonkey http://bugzilla.mozilla.org/attachment.cgi?id=145778&action=edit ------- Additional Comments from Stefan Borggraefe <Stefan.Borggraefe@gmx.de> Asking a MailNews peer for sr. ...

superreview granted: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156227] use Grant/Cancel
Blake Ross <firefox@blakeross.com> has granted Steffen Wilberg <steffen.wilberg@web.de>'s request for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156227: use Grant/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156227&action=edit ...

superreview cancelled: [Bug 199262] Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons are next to each other) : [Attachment 118601] patch that swaps the "Mark" and "Junk" buttons
Adam Becevello <bugs@abecevello.imapmail.org> has cancelled Adam Becevello <bugs@abecevello.imapmail.org>'s request for superreview: Bug 199262: Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons are next to each other) https://bugzilla.mozilla.org/show_bug.cgi?id=199262 Attachment 118601: patch that swaps the "Mark" and "Junk" buttons https://bugzilla.mozilla.org/attachment.cgi?id=118601&action=edit ------- Additional Comments from Adam Becevello <bugs@abecevello.imapmail.org> Remo...

superreview cancelled: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174078] proposed patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has cancelled Daniel Brooks <db48x@yahoo.com>'s request for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174078: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=174078&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Cancelling request on obsolete patch. ...

superreview granted: [Bug 311503] Safe Mode UI: closing or cancelling the dialog should quit Firefox : [Attachment 198807] Add "cancel" button, rev. 1
Mike Connor <mconnor@mozilla.com> has granted Benjamin Smedberg [:bs] <benjamin@smedbergs.us>'s request for superreview: Bug 311503: Safe Mode UI: closing or cancelling the dialog should quit Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=311503 Attachment 198807: Add "cancel" button, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=198807&action=edit ------- Additional Comments from Mike Connor <mconnor@mozilla.com> sure, that'll work ...

superreview cancelled: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 174788] (Tv1) transformiix/xpath #2
Peter Van der Beken <peterv@propagandism.org> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") https://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 174788: (Tv1) transformiix/xpath https://bugzilla.mozilla.org/attachment.cgi?id=174788&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> Code was rewritten as part of the fix for bug 278981. ...

Web resources about - superreview requested: [Bug 340373] Escape key should cancel "send in Unicode (UTF-8)?" dialog : [Attachment 226042] use button 1 for cancel instead of button 2 #2 - mozilla.dev.super-review

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/15/2016 9:55:34 PM