superreview requested: [Bug 336009] Coverity 468, missing error check : [Attachment 220308] check the error return

Benjamin Smedberg  [:bs] (bsmedberg@) <benjamin@smedbergs.us> has asked Daniel
Veditz <dveditz@cruzio.com> for superreview:
Bug 336009: Coverity 468, missing error check
https://bugzilla.mozilla.org/show_bug.cgi?id=336009

Attachment 220308: check the error return
https://bugzilla.mozilla.org/attachment.cgi?id=220308&action=edit

------- Additional Comments from Benjamin Smedberg  [:bs] (bsmedberg@)
<benjamin@smedbergs.us>
Dan, did we want to provide a builtin default for confirmDialogURL?
0
bugzilla
5/16/2006 10:29:48 AM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
579 Views

Similar Articles

[PageSpeed] 25

Reply:

Similar Artilces:

superreview granted: [Bug 336009] Coverity 468, missing error check : [Attachment 220308] check the error return
Daniel Veditz <dveditz@cruzio.com> has granted Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us>'s request for superreview: Bug 336009: Coverity 468, missing error check https://bugzilla.mozilla.org/show_bug.cgi?id=336009 Attachment 220308: check the error return https://bugzilla.mozilla.org/attachment.cgi?id=220308&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> First let me thank you profusely for taking on the fairly unrewarding work of munching through the Coverity errors. I would like to complain a bit ab...

superreview requested: [Bug 441914] Add missing error checks in search views : [Attachment 326845] Added some checks
Kent James (:rkent) <kent@caspia.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 441914: Add missing error checks in search views https://bugzilla.mozilla.org/show_bug.cgi?id=441914 Attachment 326845: Added some checks https://bugzilla.mozilla.org/attachment.cgi?id=326845&action=edit ------- Additional Comments from Kent James (:rkent) <kent@caspia.com> These missing checks and incorrect returns may have caused my system to hang at some point during development. ...

superreview granted: [Bug 441914] Add missing error checks in search views : [Attachment 326845] Added some checks
neil@parkwaycc.co.uk <neil@httl.net> has granted Kent James (:rkent) <kent@caspia.com>'s request for superreview: Bug 441914: Add missing error checks in search views https://bugzilla.mozilla.org/show_bug.cgi?id=441914 Attachment 326845: Added some checks https://bugzilla.mozilla.org/attachment.cgi?id=326845&action=edit ...

superreview requested: [Bug 289645] nsXBLPrototypeHandler::ExecuteHandler doesn't null/rv check : [Attachment 189301] add error checking
Bastiaan Jacques <b.jacques@planet.nl> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 289645: nsXBLPrototypeHandler::ExecuteHandler doesn't null/rv check https://bugzilla.mozilla.org/show_bug.cgi?id=289645 Attachment 189301: add error checking https://bugzilla.mozilla.org/attachment.cgi?id=189301&action=edit ...

superreview requested: [Bug 294846] misplaced null checks in NS_ScriptErrorReporter : [Attachment 184055] rearrange null checks and don't try to send a dom error for OOM
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 294846: misplaced null checks in NS_ScriptErrorReporter https://bugzilla.mozilla.org/show_bug.cgi?id=294846 Attachment 184055: rearrange null checks and don't try to send a dom error for OOM https://bugzilla.mozilla.org/attachment.cgi?id=184055&action=edit ------- Additional Comments from timeless@myrealbox.com (working) <timeless@bemail.org> the oom path i followed to notice these problems: report->errorNumber 0x00000089 unsigned...

superreview requested: [Bug 262189] useless error: JS Component Loader: ERROR (null):0\n TypeError: undefined is not a function : [Attachment 161509] Check for JSVAL_VOID as well
Mike Shaver <shaver@mozilla.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 262189: useless error: JS Component Loader: ERROR (null):0\n TypeError: undefined is not a function https://bugzilla.mozilla.org/show_bug.cgi?id=262189 Attachment 161509: Check for JSVAL_VOID as well as failed JS_GetProperty, use TypeOfValue. https://bugzilla.mozilla.org/attachment.cgi?id=161509&action=edit ...

superreview requested: [Bug 294846] misplaced null checks in NS_ScriptErrorReporter : [Attachment 184643] rearrange null checks and don't try to send a dom error for OOM
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 294846: misplaced null checks in NS_ScriptErrorReporter https://bugzilla.mozilla.org/show_bug.cgi?id=294846 Attachment 184643: rearrange null checks and don't try to send a dom error for OOM - include a definition of OOM... https://bugzilla.mozilla.org/attachment.cgi?id=184643&action=edit ...

superreview requested: [Bug 427448] Applescript curl & ptit query worked in FF2 fails in FF3 : [Attachment 327846] Patch for AppleScript bug with more error checking
Josh Aas <joshmoz@gmail.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 427448: Applescript curl & ptit query worked in FF2 fails in FF3 https://bugzilla.mozilla.org/show_bug.cgi?id=427448 Attachment 327846: Patch for AppleScript bug with more error checking https://bugzilla.mozilla.org/attachment.cgi?id=327846&action=edit ...

superreview requested: [Bug 211284] SetOrRemoveObject doesn't check the return value of PL_DHashTableInit : [Attachment 126840] check
timeless@myrealbox.com <timeless@bemail.org> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 211284: SetOrRemoveObject doesn't check the return value of PL_DHashTableInit http://bugzilla.mozilla.org/show_bug.cgi?id=211284 Attachment 126840: check http://bugzilla.mozilla.org/attachment.cgi?id=126840&action=edit ...

superreview requested: [Bug 360122] Correct cairo_create error checking : [Attachment 245859] Patch A
Alex Menzies <amenzie@us.ibm.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 360122: Correct cairo_create error checking https://bugzilla.mozilla.org/show_bug.cgi?id=360122 Attachment 245859: Patch A https://bugzilla.mozilla.org/attachment.cgi?id=245859&action=edit ...

superreview requested: [Bug 362773] Add cairo_create error checking to nsSVGUtils : [Attachment 247483] Patch A
Alex Menzies <amenzie@us.ibm.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 362773: Add cairo_create error checking to nsSVGUtils https://bugzilla.mozilla.org/show_bug.cgi?id=362773 Attachment 247483: Patch A https://bugzilla.mozilla.org/attachment.cgi?id=247483&action=edit ...

superreview granted: [Bug 289645] nsXBLPrototypeHandler::ExecuteHandler doesn't null/rv check : [Attachment 189301] add error checking
Boris Zbarsky <bzbarsky@mit.edu> has granted Bastiaan Jacques <b.jacques@planet.nl>'s request for superreview: Bug 289645: nsXBLPrototypeHandler::ExecuteHandler doesn't null/rv check https://bugzilla.mozilla.org/show_bug.cgi?id=289645 Attachment 189301: add error checking https://bugzilla.mozilla.org/attachment.cgi?id=189301&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: content/xbl/src/nsXBLPrototypeHandler.cpp > nsCOMPtr<nsIDOMScriptObjectFactory> factory = >- do_GetService(kDOMScriptObjectF...

superreview requested: [Bug 231137] NS_GetSpecialDirectory rv isn't checked in WriteProperties : [Attachment 139206] Checks return value of NS_GetSpecialDirectory
timeless@myrealbox.com (working) <timeless@bemail.org> has asked tor@acm.org for superreview: Bug 231137: NS_GetSpecialDirectory rv isn't checked in WriteProperties http://bugzilla.mozilla.org/show_bug.cgi?id=231137 Attachment 139206: Checks return value of NS_GetSpecialDirectory http://bugzilla.mozilla.org/attachment.cgi?id=139206&action=edit ...

superreview granted: [Bug 310828] JS error when hitting try again button on an error page : [Attachment 237295] try/catch the reload() call (for check-in)
Adam Guthrie <ispiked@gmail.com> has granted superreview: Bug 310828: JS error when hitting try again button on an error page https://bugzilla.mozilla.org/show_bug.cgi?id=310828 Attachment 237295: try/catch the reload() call (for check-in) https://bugzilla.mozilla.org/attachment.cgi?id=237295&action=edit ------- Additional Comments from Adam Guthrie <ispiked@gmail.com> The previous patch had some tabs in it. This patch is what needs to be checked in. ...

Web resources about - superreview requested: [Bug 336009] Coverity 468, missing error check : [Attachment 220308] check the error return - mozilla.dev.super-review

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/10/2016 1:31:06 PM