superreview denied: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 218809] set prefs to find navigator XUL and set theme correctly
neil@parkwaycc.co.uk <neil@httl.net> has denied Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 218809: set prefs to find navigator XUL and set theme correctly https://bugzilla.mozilla.org/attachment.cgi?id=218809&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> browser.chromeURL is very much needed. Also you should note that toolkit.chromeURI is a stop-gap until ...

superreview requested: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 222715] build themes before suite for correct mac packaging
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 222715: build themes before suite for correct mac packaging https://bugzilla.mozilla.org/attachment.cgi?id=222715&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> Mac suiterunner misses most of our theme files currently. We are actually running into a very similar problem to bug 338571 there...

superreview requested: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 218813] default prefs changes, v2
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 218813: default prefs changes, v2 https://bugzilla.mozilla.org/attachment.cgi?id=218813&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> OK, added a comment about the default command line handler and removed the else branch so that browser.defaultURL is also set for suiterunner ...

superreview requested: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 219205] make communicator chrome register correctly
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 219205: make communicator chrome register correctly https://bugzilla.mozilla.org/attachment.cgi?id=219205&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> Here's a "minimal" patch for correcting the communicator chrome registration stuff. This includes the missing overlays and ...

superreview granted: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 222715] build themes before suite for correct mac packaging
neil@parkwaycc.co.uk <neil@httl.net> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 222715: build themes before suite for correct mac packaging https://bugzilla.mozilla.org/attachment.cgi?id=222715&action=edit ...

superreview granted: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 218813] default prefs changes, v2
neil@parkwaycc.co.uk <neil@httl.net> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 218813: default prefs changes, v2 https://bugzilla.mozilla.org/attachment.cgi?id=218813&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+// XXX When SeaMonkey becomes a full xul app the non-moz_xul_app part of this >+// can be removed. Oops ;-) ...

superreview requested: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 219302] make help locale work
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 219302: make help locale work https://bugzilla.mozilla.org/attachment.cgi?id=219302&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> toolkit packages its own help locale files into the locale .jar, and that interferes with extensions/help filling up help locale. This patch fixes help by o...

superreview requested: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 219069] communicator chrome registration changes
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 219069: communicator chrome registration changes https://bugzilla.mozilla.org/attachment.cgi?id=219069&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> Somehow the extra "platform" on the communicator-platform registration line is causing XML errors, so remove it. Additionally, add...

superreview granted: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 219205] make communicator chrome register correctly
neil@parkwaycc.co.uk <neil@httl.net> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 219205: make communicator chrome register correctly https://bugzilla.mozilla.org/attachment.cgi?id=219205&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Nit: xpcnativewrappers=yes ...

superreview requested: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 219332] use toolkit console, remove old xpfe files
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 219332: use toolkit console, remove old xpfe files https://bugzilla.mozilla.org/attachment.cgi?id=219332&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This patch makes us use the toolkit console as JS console, and removes some other, now unused xpfe files from suiterunner chrome along wit...

superreview requested: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 219086] move communicator platform and region to new location and registra
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 219086: move communicator platform and region to new location and registration https://bugzilla.mozilla.org/attachment.cgi?id=219086&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This one should fix the inconsistency seen in communicator-platform in a better way. The region, xpcnativewra...

superreview granted: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 219302] make help locale work
neil@parkwaycc.co.uk <neil@httl.net> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 219302: make help locale work https://bugzilla.mozilla.org/attachment.cgi?id=219302&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Somewhat annoying, but at least it doesn't seem to conflict with symlinked chrome. ...

superreview cancelled: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 219069] communicator chrome registration changes
Robert Kaiser <kairo@kairo.at> has cancelled Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 219069: communicator chrome registration changes https://bugzilla.mozilla.org/attachment.cgi?id=219069&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> Removing "pltform" is actually wrong. We have to convert locale over to the new registration model instead. ...

superreview cancelled: [Bug 334478] Get suiterunner to actually run (start up a somewhat usable browser window) : [Attachment 219069] communicator chrome registration changes #2
Robert Kaiser <kairo@kairo.at> has cancelled Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 334478: Get suiterunner to actually run (start up a somewhat usable browser window) https://bugzilla.mozilla.org/show_bug.cgi?id=334478 Attachment 219069: communicator chrome registration changes https://bugzilla.mozilla.org/attachment.cgi?id=219069&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> Removing "pltform" is actually wrong. We have to convert locale over to the new registration model instead. ...