superreview requested: [Bug 333315] Can't "Copy Locations to Clipboard" in bookmarks manager : [Attachment 221053] third patch, updated to substitute a set for tracking what we've seen

Stuart Morgan <stuart.morgan@alumni.case.edu> has asked  for superreview:
Bug 333315: Can't "Copy Locations to Clipboard" in bookmarks manager
https://bugzilla.mozilla.org/show_bug.cgi?id=333315

Attachment 221053: third patch, updated to substitute a set for tracking what
we've seen
https://bugzilla.mozilla.org/attachment.cgi?id=221053&action=edit

------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu>
Yep, that's why I said "build a set in parallel with the array".  r=me.

+  NSMutableSet* bookmarkList = [NSMutableSet setWithCapacity:0];

This would be better with an initial capacity of [bookmarkItems count] instead
of 0, but that's not really worth respinning the patch (could be tweaked on
checkin, if someone feels like it).
0
bugzilla
5/6/2006 6:01:43 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
447 Views

Similar Articles

[PageSpeed] 33

Reply:

Similar Artilces:

superreview cancelled: [Bug 333315] Can't "Copy Locations to Clipboard" in bookmarks manager : [Attachment 221053] third patch, updated to substitute a set for tracking what we've seen
Chris Lawson <bugzilla@chrislawson.net> has cancelled Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 333315: Can't "Copy Locations to Clipboard" in bookmarks manager https://bugzilla.mozilla.org/show_bug.cgi?id=333315 Attachment 221053: third patch, updated to substitute a set for tracking what we've seen https://bugzilla.mozilla.org/attachment.cgi?id=221053&action=edit ...

superreview requested: [Bug 333315] Can't "Copy Locations to Clipboard" in bookmarks manager : [Attachment 223255] fixes comments 14 and 15
Chris Lawson <bugzilla@chrislawson.net> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 333315: Can't "Copy Locations to Clipboard" in bookmarks manager https://bugzilla.mozilla.org/show_bug.cgi?id=333315 Attachment 223255: fixes comments 14 and 15 https://bugzilla.mozilla.org/attachment.cgi?id=223255&action=edit ...

superreview granted: [Bug 333315] Can't "Copy Locations to Clipboard" in bookmarks manager : [Attachment 223255] fixes comments 14 and 15
Mike Pinkerton <mikepinkerton@mac.com> has granted Chris Lawson <bugzilla@chrislawson.net>'s request for superreview: Bug 333315: Can't "Copy Locations to Clipboard" in bookmarks manager https://bugzilla.mozilla.org/show_bug.cgi?id=333315 Attachment 223255: fixes comments 14 and 15 https://bugzilla.mozilla.org/attachment.cgi?id=223255&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink ...

superreview requested: [Bug 356411] Can't hide "Bonjour" in "Bookmarks" : [Attachment 242109] Patch
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 356411: Can't hide "Bonjour" in "Bookmarks" https://bugzilla.mozilla.org/show_bug.cgi?id=356411 Attachment 242109: Patch https://bugzilla.mozilla.org/attachment.cgi?id=242109&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Duh, we already have a ref to the bookmarks menu. r=me, assuming my cursory check for docs on that pref didn't miss something official. ...

superreview requested: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Louie Zhao <Louie.Zhao@sun.com> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview requested: [Bug 237228] pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js : [Attachment 158389] patch, add UnregisterPrefCallback
Ginn Chen <ginn.chen@sun.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 237228: pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js http://bugzilla.mozilla.org/show_bug.cgi?id=237228 Attachment 158389: patch, add UnregisterPrefCallback http://bugzilla.mozilla.org/attachment.cgi?id=158389&action=edit ...

superreview requested: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ...

superreview requested: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Andrew Schultz <ajschult@mindspring.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ------- Additional Comments from Andrew Schultz <ajschult@mindspring.com> note that with bug 240929 and bug 236294 fixed, only the ErrorHandler part here is relevant. ...

superreview requested: [Bug 422511] "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" : [Attachment 312549] Patch
H=C3=A5kan Waara <hwaara@gmail.com> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 422511: "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" https://bugzilla.mozilla.org/show_bug.cgi?id=3D422511 Attachment 312549: Patch https://bugzilla.mozilla.org/attachment.cgi?id=3D312549&action=3Dedit= ...

superreview requested: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) : [Attachment 292260] patch
Gavin Sharp <gavin.sharp@gmail.com> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) https://bugzilla.mozilla.org/show_bug.cgi?id=407538 Attachment 292260: patch https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> I'm not sure about the XXX comment in the test - seems like we should probably fix that, too, but I&...

superreview granted: [Bug 356411] Can't hide "Bonjour" in "Bookmarks" : [Attachment 242109] Patch
Mike Pinkerton <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 356411: Can't hide "Bonjour" in "Bookmarks" https://bugzilla.mozilla.org/show_bug.cgi?id=356411 Attachment 242109: Patch https://bugzilla.mozilla.org/attachment.cgi?id=242109&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink ...

superreview granted: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Henry Jia <Henry.Jia@sun.com> has granted Louie Zhao <Louie.Zhao@sun.com>'s request for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ------- Additional Comments from Henry Jia <Henry.Jia@sun.com> sr=Henry ...

superreview requested: [Bug 220451] Popup Manager's "Allowed Sites" dialog doesn't persist size and position : [Attachment 132310] Patch
Stefan Borggraefe <borggraefe@despammed.com> has asked Alec Flett <alecf@flett.org> for superreview: Bug 220451: Popup Manager's "Allowed Sites" dialog doesn't persist size and position http://bugzilla.mozilla.org/show_bug.cgi?id=220451 Attachment 132310: Patch http://bugzilla.mozilla.org/attachment.cgi?id=132310&action=edit ...

Web resources about - superreview requested: [Bug 333315] Can't "Copy Locations to Clipboard" in bookmarks manager : [Attachment 221053] third patch, updated to substitute a set for tracking what we've seen - mozilla.dev.super-review

Resources last updated: 12/13/2015 1:35:04 PM