superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete

Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net>
for superreview:
Bug 330053: Make SeaMonkey capable of generating a reasonable build with
MOZ_XUL_APP set.
https://bugzilla.mozilla.org/show_bug.cgi?id=330053

Attachment 218593: Make mac build complete
https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit

------- Additional Comments from Robert Kaiser <kairo@kairo.at>
This is the pathc to get suiterunner to build on Mac. Some of this is just
correcting the Makefile to things we already do in xpfe/bootstrap (the
Info.plist, .rsrc and PkgInfo lines) and I've removed one line that probably
was accidentally copied from Thunderbird (mail-biff-badge.png). The remaining
line (*.icns) is similar to what Firefox is doing, but with a saner location
for the icons :)

In addition to patching the Makefile.in, the macbuild/ dir has to be copied
from xpfe/bootstrap/ to suite/app/ - excluding the icons, which are copied into
suite/branding/icons/mac/ so that all our icons are in the icons/ dir in the
future.
I'm very much for doing this with normal cvs add this time, as we're only
adding to small files in macbuild in addition to the icons that also need not
have history preserved.
0
bugzilla
4/16/2006 3:11:55 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
460 Views

Similar Articles

[PageSpeed] 23

Reply:

Similar Artilces:

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete
jag (Peter Annema) <jag@tty.nl> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218593: Make mac build complete https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit ...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219055: Patch for the Windows build v2 https://bugzilla.mozilla.org/attachment.cgi?id=219055&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> For this patch to apply you need to copy mozilla.ico from xpfe/bootstrap/ to suite/branding/icons/windows/. ...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219154: Patch for the Windows build v3 https://bugzilla.mozilla.org/attachment.cgi?id=219154&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Removed the ID_DDE_APPLICATION_NAME define since it's not needed in toolkit/ code and so also removed the ifdef change in nsNativeAppSupport...

superreview cancelled: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2
Frank Wein <bugzilla@mcsmurf.de> has cancelled Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219055: Patch for the Windows build v2 https://bugzilla.mozilla.org/attachment.cgi?id=219055&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Removed the ID_DDE_APPLICATION_NAME define since it's not needed in toolkit/ code and so also removed the ifdef change in nsNa...

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219154: Patch for the Windows build v3 https://bugzilla.mozilla.org/attachment.cgi?id=219154&action=edit ...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218079] Part 5 v6
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218079: Part 5 v6 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=218079&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Updated patch to account for bitrot from a checkin earlier today. Also m...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 217688] Part 5 v5
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 217688: Part 5 v5 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=217688&action=edit ...

superreview cancelled: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 217688] Part 5 v5
Mark Banner <bugzilla@standard8.demon.co.uk> has cancelled Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 217688: Part 5 v5 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=217688&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> This has been bitrotted by another checkin. I&...

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218079] Part 5 v6
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218079: Part 5 v6 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=218079&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ifndef MOZ_SUITE >+# XXX Suite doesn't want these j...

superreview requested: [Bug 353841] Add a ".Mac" account type on Mac systems : [Attachment 243813] Eric's change + build magic to make it work on OS X
Scott MacGregor <mscott@mozilla.org> has asked for superreview: Bug 353841: Add a ".Mac" account type on Mac systems https://bugzilla.mozilla.org/show_bug.cgi?id=353841 Attachment 243813: Eric's change + build magic to make it work on OS X https://bugzilla.mozilla.org/attachment.cgi?id=243813&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Eric's rdf file plus some build foo to package this up for mac builds. ...

superreview requested: [Bug 353841] Add a ".Mac" account type on Mac systems : [Attachment 243813] Eric's change + build magic to make it work on OS X #2
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 353841: Add a ".Mac" account type on Mac systems https://bugzilla.mozilla.org/show_bug.cgi?id=353841 Attachment 243813: Eric's change + build magic to make it work on OS X https://bugzilla.mozilla.org/attachment.cgi?id=243813&action=edit ...

superreview requested: [Bug 301341] make building narcissus w/ Makefile.ref easier : [Attachment 189808] support make -f Makefile.ref NARCISSUS=1
Blake Kaplan <mrbkap@gmail.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 301341: make building narcissus w/ Makefile.ref easier https://bugzilla.mozilla.org/show_bug.cgi?id=301341 Attachment 189808: support make -f Makefile.ref NARCISSUS=1 https://bugzilla.mozilla.org/attachment.cgi?id=189808&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> r=me. Brendan, how about a second stamp of approval. ...

superreview requested: [Bug 299404] Can't build dmg of Firefox debug build on Mac : [Attachment 187976] Put DeerPark debug builds in DeerParkDebug.app
Mark Mentovai <mark@moxienet.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 299404: Can't build dmg of Firefox debug build on Mac https://bugzilla.mozilla.org/show_bug.cgi?id=299404 Attachment 187976: Put DeerPark debug builds in DeerParkDebug.app https://bugzilla.mozilla.org/attachment.cgi?id=187976&action=edit ...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183648] Phase 1a: SDK-less builds on 10.4, config/build portion
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183648: Phase 1a: SDK-less builds on 10.4, config/build portion https://bugzilla.mozilla.org/attachment.cgi?id=183648&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Splitting phase 1 into a configure/build half and a Mac-specific implementation half per comment 96. Chris, I do AC_PA...

Web resources about - superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete - mozilla.dev.super-review

Resources last updated: 12/3/2015 10:23:32 PM