superreview requested: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309303] Replace set default function with get default function

Julien Pierre <julien.pierre.boogz@sun.com> has asked  for superreview:
Bug 294531: Design new interfaces for certificate path building and
verification for libPKIX
https://bugzilla.mozilla.org/show_bug.cgi?id=294531

Attachment 309303: Replace set default function with get default function
https://bugzilla.mozilla.org/attachment.cgi?id=309303&action=edit

------- Additional Comments from Julien Pierre <julien.pierre.boogz@sun.com>
This change should help prevent application components from stepping on each
other's toes.

We still have CERT_SetUsePKIXForValidation which is another vexing
process-global setting that may create problems with mixed components, IMO. If
we keep this, I hope we are going to make it return SECFailure when we get rid
of the old PKIX code completely in the future.
0
bugzilla
3/14/2008 1:07:33 AM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
398 Views

Similar Articles

[PageSpeed] 31

Reply:

Similar Artilces:

superreview requested: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309303] Replace set default function with get default function #2
Julien Pierre <julien.pierre.boogz@sun.com> has asked Kai Engert (:kaie) <kengert@redhat.com> for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 309303: Replace set default function with get default function https://bugzilla.mozilla.org/attachment.cgi?id=309303&action=edit ...

superreview denied: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309303] Replace set default function with get default function
Kai Engert (:kaie) <kengert@redhat.com> has denied Julien Pierre <julien.pierre.boogz@sun.com>'s request for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 309303: Replace set default function with get default function https://bugzilla.mozilla.org/attachment.cgi?id=309303&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> Julien, I think this is explicitly not what we would like to happen. Your chang...

superreview requested: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309254] Proposal 8 as patch
Kai Engert (:kaie) <kengert@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 309254: Proposal 8 as patch https://bugzilla.mozilla.org/attachment.cgi?id=309254&action=edit ...

superreview requested: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309006] Proposal 7 as patch
Kai Engert (:kaie) <kengert@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 309006: Proposal 7 as patch https://bugzilla.mozilla.org/attachment.cgi?id=309006&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> I hope this new proposal 7 is self documenting. I hope it does not require a matrix. I've given up on the idea to use a single bitma...

superreview requested: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309517] Proposal 8 as patch (v6)
Robert Relyea <rrelyea@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 309517: Proposal 8 as patch (v6) https://bugzilla.mozilla.org/attachment.cgi?id=309517&action=edit ------- Additional Comments from Robert Relyea <rrelyea@redhat.com> r+ rrelyea. Adding Nelson to bring attention to the change. We forgot the semantic that kicked of the revocation re-examination to begin ...

superreview requested: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309007] Proposal 7 as patch (v2)
Kai Engert (:kaie) <kengert@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 309007: Proposal 7 as patch (v2) https://bugzilla.mozilla.org/attachment.cgi?id=309007&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> Updated the patch to use C style comments and removed the obsolete CERT_REV_* flags. Nelson, please ignore that this has long lines...

superreview requested: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309260] Proposal 8 as patch (v2)
Kai Engert (:kaie) <kengert@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 309260: Proposal 8 as patch (v2) https://bugzilla.mozilla.org/attachment.cgi?id=309260&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> I quickly produced an updated patch of proposal 8. Two comment clarifications (where the comment refered to the name of a variable ...

superreview requested: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 307922] API changes to require revocation checking, proposal 5
Kai Engert (:kaie) <kengert@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 307922: API changes to require revocation checking, proposal 5 https://bugzilla.mozilla.org/attachment.cgi?id=307922&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> Asking Bob and Nelson for review of these bit definitions. I hope I have made possible all combinations ...

superreview requested: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX
Robert Relyea <rrelyea@redhat.com> has asked for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 279930: Update header 2. https://bugzilla.mozilla.org/attachment.cgi?id=279930&action=edit ------- Additional Comments from Robert Relyea <rrelyea@redhat.com> This proposal still uses arrays, but all other issues have been addressed. Some of they type safety has also been addressed by splitting the unions into 3 parts: scalars, pointers, and arrays. ...

superreview requested: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX #2
Robert Relyea <rrelyea@redhat.com> has asked Julien Pierre <julien.pierre.boogz@sun.com> for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 279930: Update header 2. https://bugzilla.mozilla.org/attachment.cgi?id=279930&action=edit ...

superreview canceled: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309006] Proposal 7 as patch
Kai Engert (:kaie) <kengert@redhat.com> has canceled Kai Engert (:kaie) <kengert@redhat.com>'s request for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 309006: Proposal 7 as patch https://bugzilla.mozilla.org/attachment.cgi?id=309006&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> Updated the patch to use C style comments and removed the obsolete CERT_REV_* flags. Nelson, please ignore that thi...

superreview canceled: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309254] Proposal 8 as patch
Kai Engert (:kaie) <kengert@redhat.com> has canceled Kai Engert (:kaie) <kengert@redhat.com>'s request for superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 309254: Proposal 8 as patch https://bugzilla.mozilla.org/attachment.cgi?id=309254&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> I quickly produced an updated patch of proposal 8. Two comment clarifications (where the comment refered to the name...

superreview granted: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309422] Proposal 8 as patch (v3)
Kai Engert (:kaie) <kengert@redhat.com> has granted superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 309422: Proposal 8 as patch (v3) https://bugzilla.mozilla.org/attachment.cgi?id=309422&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> This is a minor revision of the previous patch (proposal 8 as patch v2). I've globally replaced the word "mechanism" with "method", as requested by Nel...

superreview granted: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309454] Proposal 8 as patch (v4)
Kai Engert (:kaie) <kengert@redhat.com> has granted superreview: Bug 294531: Design new interfaces for certificate path building and verification for libPKIX https://bugzilla.mozilla.org/show_bug.cgi?id=294531 Attachment 309454: Proposal 8 as patch (v4) https://bugzilla.mozilla.org/attachment.cgi?id=309454&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> I made minor tweaks to the "proposal 8 patch v3": - removed the old CERT_REV_ flags that are no longer supported - changed the size of the flag integers to 64 bits ...

Web resources about - superreview requested: [Bug 294531] Design new interfaces for certificate path building and verification for libPKIX : [Attachment 309303] Replace set default function with get default function - mozilla.dev.super-review

Resources last updated: 11/23/2015 11:24:49 PM