superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird #2

Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 290678: Port thunderbird's revised vcard attachment display to suite.
https://bugzilla.mozilla.org/show_bug.cgi?id=290678

Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird
https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit
0
bugzilla
3/11/2008 3:57:55 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
1712 Views

Similar Articles

[PageSpeed] 39

Reply:

Similar Artilces:

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> This patch lets SeaMonkey use the same code as Thunderbird and removes the previous used code from mimevcrd.cpp I'll post a fron...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird
David Bienvenu <bienvenu@nventure.com> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit ...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309826] Patch for classic and modern
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309826: Patch for classic and modern https://bugzilla.mozilla.org/attachment.cgi?id=309826&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Updated patch for classic and modern theme. I'll file a separate bug for better icons (at least modern looks quit...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309834] Patch for classic and modern v2
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309834: Patch for classic and modern v2 https://bugzilla.mozilla.org/attachment.cgi?id=309834&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Now with the correct modern icon (not that it would look any better, but at least it's the vcard icon ;-)) ...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309922] Patch for classic and modern v3
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309922: Patch for classic and modern v3 https://bugzilla.mozilla.org/attachment.cgi?id=309922&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Now I believe the theme patch is fine enough to be reviewed (finally ;-)) I had to do some tricks to make modern...

superreview canceled: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309826] Patch for classic and modern
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has canceled Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309826: Patch for classic and modern https://bugzilla.mozilla.org/attachment.cgi?id=309826&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Now with the correct modern icon (not that it would look any better, but at least i...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 310204] Patch for classic and modern v4
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has granted superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 310204: Patch for classic and modern v4 https://bugzilla.mozilla.org/attachment.cgi?id=310204&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Includes the changes from comment #12, taking over r/sr. ...

superreview canceled: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309834] Patch for classic and modern v2
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has canceled Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309834: Patch for classic and modern v2 https://bugzilla.mozilla.org/attachment.cgi?id=309834&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Oh man, I was too blind to see the correct icons for that case. At least I have ...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309922] Patch for classic and modern v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309922: Patch for classic and modern v3 https://bugzilla.mozilla.org/attachment.cgi?id=309922&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> OK, r+sr=me with the noline image in Modern and the tweaked outline styles in both themes. ...

superreview requested: [Bug 349767] Port seamonkey's folder location toolbar button to Thunderbird : [Attachment 235159] the fix
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 349767: Port seamonkey's folder location toolbar button to Thunderbird https://bugzilla.mozilla.org/show_bug.cgi?id=349767 Attachment 235159: the fix https://bugzilla.mozilla.org/attachment.cgi?id=235159&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Ports Neil's work for a location toolbar button to Thunderbird. I had to refactor loadFolderView, splitting it into two methods so I could share some of the code ...

superreview requested: [Bug 343383] cookies don't work in 'suiterunner' seamonkey : [Attachment 227952] nsMsgCookiePolicy is only required for thunderbird. #2
neil@parkwaycc.co.uk <neil@httl.net> has asked for superreview: Bug 343383: cookies don't work in 'suiterunner' seamonkey https://bugzilla.mozilla.org/show_bug.cgi?id=343383 Attachment 227952: nsMsgCookiePolicy is only required for thunderbird. https://bugzilla.mozilla.org/attachment.cgi?id=227952&action=edit ...

superreview requested: [Bug 273977] Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) : [Attachment 220339] Patch that uses MOZ_APP #2
Chris Andrichak <chris@grope.com> has asked for superreview: Bug 273977: Thunderbird does not identify itself correctly to iListen voice rec application (Thunderbird.app vs thunderbird-bin ?) https://bugzilla.mozilla.org/show_bug.cgi?id=273977 Attachment 220339: Patch that uses MOZ_APP_DISPLAYNAME for executable https://bugzilla.mozilla.org/attachment.cgi?id=220339&action=edit ------- Additional Comments from Chris Andrichak <chris@grope.com> Getting the executable name from the variable at mark's suggestion, the make file now swaps it into the plist file also....

superreview requested: [Bug 289376] Fix description and value for combo boxes : [Attachment 179907] 1) Forward focused option's description through combo box, 2) In HTML use focused 's label for comb #2
Aaron Leventhal <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 289376: Fix description and value for combo boxes https://bugzilla.mozilla.org/show_bug.cgi?id=289376 Attachment 179907: 1) Forward focused option's description through combo box, 2) In HTML use focused 's label for combo box value, 3) Fire ValueChange event after old selection option unselected https://bugzilla.mozilla.org/attachment.cgi?id=179907&action=edit ...

superreview granted: [Bug 349767] Port seamonkey's folder location toolbar button to Thunderbird : [Attachment 235159] the fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 349767: Port seamonkey's folder location toolbar button to Thunderbird https://bugzilla.mozilla.org/show_bug.cgi?id=349767 Attachment 235159: the fix https://bugzilla.mozilla.org/attachment.cgi?id=235159&action=edit ...

Web resources about - superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird #2 - mozilla.dev.super-review

Resources last updated: 12/8/2015 3:06:09 PM