superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird

Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked  for superreview:
Bug 290678: Port thunderbird's revised vcard attachment display to suite.
https://bugzilla.mozilla.org/show_bug.cgi?id=290678

Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird
https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit

------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de>
This patch lets SeaMonkey use the same code as Thunderbird and removes the
previous used code from mimevcrd.cpp

I'll post a frontend patch later, have still some things to figure out for
that.
0
bugzilla
3/11/2008 3:56:24 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
653 Views

Similar Articles

[PageSpeed] 3

Reply:

Similar Artilces:

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird #2
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit ...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 308639] Use the same vcard code for SeaMonkey and Thunderbird
David Bienvenu <bienvenu@nventure.com> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 308639: Use the same vcard code for SeaMonkey and Thunderbird https://bugzilla.mozilla.org/attachment.cgi?id=308639&action=edit ...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309826] Patch for classic and modern
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309826: Patch for classic and modern https://bugzilla.mozilla.org/attachment.cgi?id=309826&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Updated patch for classic and modern theme. I'll file a separate bug for better icons (at least modern looks quit...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309834] Patch for classic and modern v2
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309834: Patch for classic and modern v2 https://bugzilla.mozilla.org/attachment.cgi?id=309834&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Now with the correct modern icon (not that it would look any better, but at least it's the vcard icon ;-)) ...

superreview requested: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309922] Patch for classic and modern v3
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309922: Patch for classic and modern v3 https://bugzilla.mozilla.org/attachment.cgi?id=309922&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Now I believe the theme patch is fine enough to be reviewed (finally ;-)) I had to do some tricks to make modern...

superreview canceled: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309826] Patch for classic and modern
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has canceled Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309826: Patch for classic and modern https://bugzilla.mozilla.org/attachment.cgi?id=309826&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Now with the correct modern icon (not that it would look any better, but at least i...

superreview canceled: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309834] Patch for classic and modern v2
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has canceled Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309834: Patch for classic and modern v2 https://bugzilla.mozilla.org/attachment.cgi?id=309834&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Oh man, I was too blind to see the correct icons for that case. At least I have ...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309922] Patch for classic and modern v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309922: Patch for classic and modern v3 https://bugzilla.mozilla.org/attachment.cgi?id=309922&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> OK, r+sr=me with the noline image in Modern and the tweaked outline styles in both themes. ...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 310204] Patch for classic and modern v4
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has granted superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 310204: Patch for classic and modern v4 https://bugzilla.mozilla.org/attachment.cgi?id=310204&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Includes the changes from comment #12, taking over r/sr. ...

superreview requested: [Bug 349767] Port seamonkey's folder location toolbar button to Thunderbird : [Attachment 235159] the fix
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 349767: Port seamonkey's folder location toolbar button to Thunderbird https://bugzilla.mozilla.org/show_bug.cgi?id=349767 Attachment 235159: the fix https://bugzilla.mozilla.org/attachment.cgi?id=235159&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Ports Neil's work for a location toolbar button to Thunderbird. I had to refactor loadFolderView, splitting it into two methods so I could share some of the code ...

superreview granted: [Bug 349767] Port seamonkey's folder location toolbar button to Thunderbird : [Attachment 235159] the fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 349767: Port seamonkey's folder location toolbar button to Thunderbird https://bugzilla.mozilla.org/show_bug.cgi?id=349767 Attachment 235159: the fix https://bugzilla.mozilla.org/attachment.cgi?id=235159&action=edit ...

superreview requested: [Bug 418623] make thunderbird (qute) use toolkit's tree.css : [Attachment 304484] Patch
KUROSAWA, Takeshi <taken.spc@gmail.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 418623: make thunderbird (qute) use toolkit's tree.css https://bugzilla.mozilla.org/show_bug.cgi?id=418623 Attachment 304484: Patch https://bugzilla.mozilla.org/attachment.cgi?id=304484&action=edit ...

superreview requested: [Bug 221381] Add Attach Personal Card (vCard) option to Attach button in compose window toolbar : [Attachment 132880] Revised patch v0.2b that adds Person Card to Attach butto
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 221381: Add Attach Personal Card (vCard) option to Attach button in compose window toolbar http://bugzilla.mozilla.org/show_bug.cgi?id=221381 Attachment 132880: Revised patch v0.2b that adds Person Card to Attach button http://bugzilla.mozilla.org/attachment.cgi?id=132880&action=edit ------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk> Carrying r= forward ...

superreview requested: [Bug 288366] Port Thunderbird's View Layout to MailNews : [Attachment 179717] Tweaked extended patch v0.1f
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 288366: Port Thunderbird's View Layout to MailNews https://bugzilla.mozilla.org/show_bug.cgi?id=288366 Attachment 179717: Tweaked extended patch v0.1f https://bugzilla.mozilla.org/attachment.cgi?id=179717&action=edit ------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk> Changes since v0.1e * Changed broadcaster name from mailHideKeys to mailDisableKeys as suggested by Neil (I think) Carrying forward r= ...