superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 237073] A Patch Not On Crack

Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton
<mikepinkerton@mac.com> for superreview:
Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with
alternate menu items
https://bugzilla.mozilla.org/show_bug.cgi?id=290212

Attachment 237073: A Patch Not On Crack
https://bugzilla.mozilla.org/attachment.cgi?id=237073&action=edit

------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu>
r=me.  Style stuff:

>+    NSMenuItem* menuItem = [[NSMenuItem alloc]
initWithTitle:NSLocalizedString(@"Open in Tabs", nil)
>							 action:nil
>+						  keyEquivalent:@""];
>+    NSMenuItem* altMenuItem;
>+    if ([[PreferenceManager sharedInstance]
getBooleanPref:"browser.tabs.opentabfor.middleclick" withSuccess:NULL])
>+	altMenuItem = [[NSMenuItem alloc]
initWithTitle:NSLocalizedString(@"Open in New Tabs", nil)
>+						  action:nil
>+					   keyEquivalent:@""];
>+    else
>+	altMenuItem = [[NSMenuItem alloc]
initWithTitle:NSLocalizedString(@"Open in Tabs in New Window", nil)
>+						  action:nil
>+					   keyEquivalent:@""];

Fix the |:| alignment here.

>     [menuItem setAction:@selector(openMenuBookmark:)];
...
>+    [altMenuItem setAction:@selector(openMenuBookmark:)];

Set these in the init call, rather than passing nil there and setting it here.
0
bugzilla
10/10/2006 4:05:59 AM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
554 Views

Similar Articles

[PageSpeed] 35

Reply:

Similar Artilces:

superreview cancelled: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 237073] A Patch Not On Crack
froodian (unreliable 10/7-10/12) <stridey@gmail.com> has cancelled Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 237073: A Patch Not On Crack https://bugzilla.mozilla.org/attachment.cgi?id=237073&action=edit ...

superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 241797] r=smorgan patch
froodian (unreliable 10/7-10/12) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 241797: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=241797&action=edit ...

superreview granted: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 241797] r=smorgan patch
Mike Pinkerton <mikepinkerton@mac.com> has granted froodian (unreliable 10/7-10/12) <stridey@gmail.com>'s request for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 241797: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=241797&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink ...

superreview requested: [Bug 275430] change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" : [Attachment 177848] Patch to make
Jeremy Morton <bugzilla@game-point.net> has asked Ben Goodger <bugs@bengoodger.com> for superreview: Bug 275430: change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" https://bugzilla.mozilla.org/show_bug.cgi?id=275430 Attachment 177848: Patch to make externally-launched links open in new window https://bugzilla.mozilla.org/attachment.cgi?id=177848&action=edit ...

superreview requested: [Bug 300485] Launching SeaMonkey when it's already running, with "open in new tab" preference, should opens a new tab rather than window. : [Attachment 189715] Proposed patch (
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 300485: Launching SeaMonkey when it's already running, with "open in new tab" preference, should opens a new tab rather than window. https://bugzilla.mozilla.org/show_bug.cgi?id=300485 Attachment 189715: Proposed patch (Windows) https://bugzilla.mozilla.org/attachment.cgi?id=189715&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> You can't do clever stuff in app startup...

superreview requested: [Bug 355204] Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" : [Attachment 241740] New AddBookmark.nib
froodian (unreliable 10/7-10/12) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 355204: Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" https://bugzilla.mozilla.org/show_bug.cgi?id=355204 Attachment 241740: New AddBookmark.nib https://bugzilla.mozilla.org/attachment.cgi?id=241740&action=edit ------- Additional Comments from froodian (unreliable 10/7-10/12) <stridey@gmail.com> Same as last time, but sets the minimum size to 450, per comment 2. ...

superreview requested: [Bug 355204] Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" : [Attachment 241643] new AddBookmark.nib
Smokey Ardisson (away indefinitely; no bugmail) <alqahira@mindspring.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 355204: Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" https://bugzilla.mozilla.org/show_bug.cgi?id=355204 Attachment 241643: new AddBookmark.nib https://bugzilla.mozilla.org/attachment.cgi?id=241643&action=edit ------- Additional Comments from Smokey Ardisson (away indefinitely; no bugmail) <alqahira@mindspring.com> A minor niggle: the nib ge...

superreview cancelled: [Bug 275430] change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" : [Attachment 177848] Patch to make
Mike Connor <mconnor@steelgryphon.com> has cancelled Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 275430: change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" https://bugzilla.mozilla.org/show_bug.cgi?id=275430 Attachment 177848: Patch to make externally-launched links open in new window https://bugzilla.mozilla.org/attachment.cgi?id=177848&action=edit ------- Additional Comments from Mike Connor <mconnor@steelgryphon.com> New ...

superreview requested: [Bug 275996] Can not open new tab.("Open a new tab" button on personal toolbar) : [Attachment 172464] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 275996: Can not open new tab.("Open a new tab" button on personal toolbar) https://bugzilla.mozilla.org/show_bug.cgi?id=275996 Attachment 172464: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172464&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Don't flag ourselves as previewing unless we actually are. ...

superreview requested: [Bug 422511] "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" : [Attachment 312549] Patch
H=C3=A5kan Waara <hwaara@gmail.com> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 422511: "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" https://bugzilla.mozilla.org/show_bug.cgi?id=3D422511 Attachment 312549: Patch https://bugzilla.mozilla.org/attachment.cgi?id=3D312549&action=3Dedit= ...

superreview cancelled: [Bug 300485] Launching SeaMonkey when it's already running, with "open in new tab" preference, should open a new tab rather than window. : [Attachment 189715] Proposed patch (W
jag (Peter Annema) <jag@tty.nl> has cancelled neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 300485: Launching SeaMonkey when it's already running, with "open in new tab" preference, should open a new tab rather than window. https://bugzilla.mozilla.org/show_bug.cgi?id=300485 Attachment 189715: Proposed patch (Windows) https://bugzilla.mozilla.org/attachment.cgi?id=189715&action=edit ...

superreview cancelled: [Bug 355204] Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" : [Attachment 241643] new AddBookmark.nib
froodian (unreliable 10/7-10/12) <stridey@gmail.com> has cancelled superreview: Bug 355204: Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" https://bugzilla.mozilla.org/show_bug.cgi?id=355204 Attachment 241643: new AddBookmark.nib https://bugzilla.mozilla.org/attachment.cgi?id=241643&action=edit ------- Additional Comments from froodian (unreliable 10/7-10/12) <stridey@gmail.com> Same as last time, but sets the minimum size to 450, per comment 2. ...

superreview granted: [Bug 355204] Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" : [Attachment 241740] New AddBookmark.nib
Mike Pinkerton <mikepinkerton@mac.com> has granted froodian (unreliable 10/7-10/12) <stridey@gmail.com>'s request for superreview: Bug 355204: Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" https://bugzilla.mozilla.org/show_bug.cgi?id=355204 Attachment 241740: New AddBookmark.nib https://bugzilla.mozilla.org/attachment.cgi?id=241740&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> rs=pink ...

superreview requested: [Bug 228803] The contextual menu item "Open Tabs in New Window" does not work : [Attachment 138520] patch v1.0
Josh Aas <josha@mac.com> has asked for superreview: Bug 228803: The contextual menu item "Open Tabs in New Window" does not work http://bugzilla.mozilla.org/show_bug.cgi?id=228803 Attachment 138520: patch v1.0 http://bugzilla.mozilla.org/attachment.cgi?id=138520&action=edit ...

Web resources about - superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 237073] A Patch Not On Crack - mozilla.dev.super-review

Resources last updated: 12/18/2015 6:34:19 AM