superreview requested: [Bug 282189] sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml : [Attachment 219242] (Bv2-XPFE) <toolbarbutton.xml> ++

Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282189: sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282189

Attachment 219242: (Bv2-XPFE) <toolbarbutton.xml> ++
https://bugzilla.mozilla.org/attachment.cgi?id=219242&action=edit

------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Bv1, updated to current Trunk:
in fact, it's now a port, of the (TB+TK) attachment 214196 in bug 252393,
which addresses comment 5 and comment 6.

Untested.
0
bugzilla
4/21/2006 2:22:31 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
526 Views

Similar Articles

[PageSpeed] 39

Reply:

Similar Artilces:

superreview granted: [Bug 282189] sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml : [Attachment 219242] (Bv2-XPFE) <toolbarbutton.xml> ++
neil@parkwaycc.co.uk <neil@httl.net> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 282189: sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282189 Attachment 219242: (Bv2-XPFE) <toolbarbutton.xml> ++ https://bugzilla.mozilla.org/attachment.cgi?id=219242&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> This is fine except for the Modern theme which has its own way of handling this. ...

superreview requested: [Bug 282189] sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml : [Attachment 176675] (Av1) <toolbarbutton.xml>
Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 282189: sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282189 Attachment 176675: (Av1) <toolbarbutton.xml> https://bugzilla.mozilla.org/attachment.cgi?id=176675&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Untested, but so obvious... (What would be the expected non-regression test for this change ?) This came from Toolkit version: {{ 1.3...

superreview granted: [Bug 282189] sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml : [Attachment 176675] (Av1) <toolbarbutton.xml>
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 282189: sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282189 Attachment 176675: (Av1) <toolbarbutton.xml> https://bugzilla.mozilla.org/attachment.cgi?id=176675&action=edit ...

superreview requested: [Bug 282189] sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml : [Attachment 220532] (Cv1) <jar.mn>
Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 282189: sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282189 Attachment 220532: (Cv1) <jar.mn> https://bugzilla.mozilla.org/attachment.cgi?id=220532&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Now, switch to use the toolkit file directly, per comment 14. (untested) This switch would not be welcomed on the 1.8 branch, would it ? ...

superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 221700] (Av4-XPFE) <button.xml>
Serge GAUTHERIE <gautheri@noos.fr> has asked for superreview: Bug 282180: sync xpfe button.xml with toolkit button.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282180 Attachment 221700: (Av4-XPFE) <button.xml> https://bugzilla.mozilla.org/attachment.cgi?id=221700&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Av3-XPFE, with comment 17 suggestion(s). Untested: Would you have a testcase to check this behaviour ? ...

superreview requested: [Bug 282186] sync xpfe text.xml with toolkit text.xml : [Attachment 221205] (Cv1-XPFE) <text.xml>
Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 282186: sync xpfe text.xml with toolkit text.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282186 Attachment 221205: (Cv1-XPFE) <text.xml> https://bugzilla.mozilla.org/attachment.cgi?id=221205&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> This part comes from bug 280065 and followups. Untested. ...

superreview requested: [Bug 282182] sync xpfe general.xml with toolkit general.xml : [Attachment 219626] (Av3-XPFE) <general.xml>++
Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 282182: sync xpfe general.xml with toolkit general.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282182 Attachment 219626: (Av3-XPFE) <general.xml>++ https://bugzilla.mozilla.org/attachment.cgi?id=219626&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Av3-XPFE-Bw, with full diff. Keeping [[ (Av3-XPFE-Bw) <general.xml>++ patch 2006-04-23 16:17 PDT 2.38 KB neil: review+ ]] ...

superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 218477] (Av3-XPFE) <button.xml>
Serge GAUTHERIE <gautheri@noos.fr> has asked for superreview: Bug 282180: sync xpfe button.xml with toolkit button.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282180 Attachment 218477: (Av3-XPFE) <button.xml> https://bugzilla.mozilla.org/attachment.cgi?id=218477&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Av2, with comment 7 suggestion(s). ...

superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 218477] (Av3-XPFE) <button.xml> #2
Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 282180: sync xpfe button.xml with toolkit button.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282180 Attachment 218477: (Av3-XPFE) <button.xml> https://bugzilla.mozilla.org/attachment.cgi?id=218477&action=edit ...

superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 221700] (Av4-XPFE) <button.xml> #2
Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 282180: sync xpfe button.xml with toolkit button.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282180 Attachment 221700: (Av4-XPFE) <button.xml> https://bugzilla.mozilla.org/attachment.cgi?id=221700&action=edit ...

superreview requested: [Bug 282187] sync xpfe textbox.xml with toolkit textbox.xml : [Attachment 178157] (Av1b) <textbox.xml> (full sync ++)
Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 282187: sync xpfe textbox.xml with toolkit textbox.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282187 Attachment 178157: (Av1b) <textbox.xml> (full sync ++) https://bugzilla.mozilla.org/attachment.cgi?id=178157&action=edit ...

superreview granted: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 221700] (Av4-XPFE) <button.xml>
neil@parkwaycc.co.uk <neil@httl.net> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 282180: sync xpfe button.xml with toolkit button.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282180 Attachment 221700: (Av4-XPFE) <button.xml> https://bugzilla.mozilla.org/attachment.cgi?id=221700&action=edit ...

superreview cancelled: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 218477] (Av3-XPFE) <button.xml>
neil@parkwaycc.co.uk <neil@httl.net> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 282180: sync xpfe button.xml with toolkit button.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282180 Attachment 218477: (Av3-XPFE) <button.xml> https://bugzilla.mozilla.org/attachment.cgi?id=218477&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> > <children> > <xul:image class="button-icon" xbl:inherits="src=image"/> >- <xul:label class="b...

superreview granted: [Bug 282182] sync xpfe general.xml with toolkit general.xml : [Attachment 219626] (Av3-XPFE) <general.xml>++
neil@parkwaycc.co.uk <neil@httl.net> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 282182: sync xpfe general.xml with toolkit general.xml https://bugzilla.mozilla.org/show_bug.cgi?id=282182 Attachment 219626: (Av3-XPFE) <general.xml>++ https://bugzilla.mozilla.org/attachment.cgi?id=219626&action=edit ...

Web resources about - superreview requested: [Bug 282189] sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml : [Attachment 219242] (Bv2-XPFE) <toolbarbutton.xml> ++ - mozilla.dev.super-review

Resources last updated: 11/22/2015 3:03:14 PM