superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 222679] additional change

Scott MacGregor (out of town May 11th-14th) <mscott@mozilla.org> has asked
David Bienvenu - not reading bug mail from May 10th-May 18th
<bienvenu@nventure.com> for superreview:
Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings"
https://bugzilla.mozilla.org/show_bug.cgi?id=257990

Attachment 222679: additional change
https://bugzilla.mozilla.org/attachment.cgi?id=222679&action=edit

------- Additional Comments from Scott MacGregor (out of town May 11th-14th)
<mscott@mozilla.org>
When I added manual mark as read to the options UI yesterday, I forgot to
change the spam settings code to make this a read only global option instead of
an account specific option. 

This change does that and it removes mManualMark and mManualMarkMode variables
which aren't used now that those options are global as well.

Note: I did not bump the interface ID for nsISpamSettings because it was
changed with the rest of this checkin yesterday.
0
bugzilla
5/19/2006 9:15:49 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
634 Views

Similar Articles

[PageSpeed] 26

Reply:

Similar Artilces:

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 222679] additional change
David Bienvenu - not reading bug mail from May 10th-May 18th <bienvenu@nventure.com> has granted Scott MacGregor (out of town May 11th-14th) <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 222679: additional change https://bugzilla.mozilla.org/attachment.cgi?id=222679&action=edit ...

superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Here's what I did: 1) nsMsgAccountManagerDS.cpp.h Add code to display a junk mail panel for all accounts but news who h...

superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220052] migrate the new global settings
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220052: migrate the new global settings https://bugzilla.mozilla.org/attachment.cgi?id=220052&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> This extra patch migrates the values for: manualMark, manualMarkMode and spamLogging from the default account to the new...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> my one concern is about migration from the per-server prefs to the global prefs. What happens in that scenar...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220151] updated fix with review comments
Scott MacGregor <mscott@mozilla.org> has granted superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220151: updated fix with review comments https://bugzilla.mozilla.org/attachment.cgi?id=220151&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying forward david's sr and neil's r. ...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220052] migrate the new global settings
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220052: migrate the new global settings https://bugzilla.mozilla.org/attachment.cgi?id=220052&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> great, thx. ...

superreview requested: [Bug 216533] Move the "Composition" settings *above* the "Addressing" settings in the Account Settings : [Attachment 130078] Patch v0.1a
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 216533: Move the "Composition" settings *above* the "Addressing" settings in the Account Settings http://bugzilla.mozilla.org/show_bug.cgi?id=216533 Attachment 130078: Patch v0.1a http://bugzilla.mozilla.org/attachment.cgi?id=130078&action=edit ------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk> r= Neil carried forward ...

superreview requested: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] Fix
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog http://bugzilla.mozilla.org/show_bug.cgi?id=257801 Attachment 157725: Fix http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit ...

superreview requested: [Bug 216789] "Server Settings" tab in "Account Settings" is too big for preferences window : [Attachment 130981] Revised Patch v0.2a
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 216789: "Server Settings" tab in "Account Settings" is too big for preferences window http://bugzilla.mozilla.org/show_bug.cgi?id=216789 Attachment 130981: Revised Patch v0.2a http://bugzilla.mozilla.org/attachment.cgi?id=130981&action=edit ...

superreview granted: [Bug 216533] Move the "Composition" settings *above* the "Addressing" settings in the Account Settings : [Attachment 130078] Patch v0.1a
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 216533: Move the "Composition" settings *above* the "Addressing" settings in the Account Settings http://bugzilla.mozilla.org/show_bug.cgi?id=216533 Attachment 130078: Patch v0.1a http://bugzilla.mozilla.org/attachment.cgi?id=130078&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu ...

superreview granted: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] Fix
David Bienvenu <bienvenu@nventure.com> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog http://bugzilla.mozilla.org/show_bug.cgi?id=257801 Attachment 157725: Fix http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx. I'm in the middle of making changes to this code, but I don't think this wil...

superreview requested: [Bug 234865] when "Regional Options / General" locale is set to "Serbian (Latin)" or "Serbian (Cyrillic)" wrong display of date in Page Info (Ctrl + J) : [Attachment 162030] Pa
Simon Montagu <smontagu@smontagu.org> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 234865: when "Regional Options / General" locale is set to "Serbian (Latin)" or "Serbian (Cyrillic)" wrong display of date in Page Info (Ctrl + J) https://bugzilla.mozilla.org/show_bug.cgi?id=234865 Attachment 162030: Patch https://bugzilla.mozilla.org/attachment.cgi?id=162030&action=edit ------- Additional Comments from Simon Montagu <smontagu@smontagu.org> Thanks for r, requesting sr (In reply to commen...

superreview granted: [Bug 216789] "Server Settings" tab in "Account Settings" is too big for preferences window : [Attachment 130981] Revised Patch v0.2a
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 216789: "Server Settings" tab in "Account Settings" is too big for preferences window http://bugzilla.mozilla.org/show_bug.cgi?id=216789 Attachment 130981: Revised Patch v0.2a http://bugzilla.mozilla.org/attachment.cgi?id=130981&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu ...

superreview requested: [Bug 262300] "Composition & Addressing" and "Advanced Account Settings" should be handeled by Identity Manager : [Attachment 165378] finish implementing multiple identity UI
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 262300: "Composition & Addressing" and "Advanced Account Settings" should be handeled by Identity Manager https://bugzilla.mozilla.org/show_bug.cgi?id=262300 Attachment 165378: finish implementing multiple identity UI https://bugzilla.mozilla.org/attachment.cgi?id=165378&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> David, it's not as big as it looks. You can ignore the two new files (am-cop...

Web resources about - superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 222679] additional change - mozilla.dev.super-review

Resources last updated: 12/26/2015 6:22:06 PM