superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Here's what I did: 1) nsMsgAccountManagerDS.cpp.h Add code to display a junk mail panel for all accounts but news who have identities associated with them. 2) incomingServer I didn't like how the server was responsible for initializing each spam setting attribute so I pushed all of the initialization code into the spam settings object itself. The spam settings object is now readonly, we don't need a setter because the account manager is now setting the prefs for us. 3) spamSettings A lot of interface cleanup here, getting rid of unneeded setter properties (we could still clean up more) now that the account manager actually sets our prefs. I made the following settings global: logging, manual mark, and manual mark mode. Converted the logging code to use nsIFile and removed some logging APIs which we don't need. The log now appears at the top level directory in the profile. Add an initialization method which takes a server and updates the server specific spam settings. I also added code to unset/set the junk folder flag when the junk folder changes. 4) am-junk.xul, am-junk.js Account specific junk mail settings. 5) privacy.xul, privacy.js Global junk mail settings 6) Misc For the prefs I made global (manual mark mode and logging, I didn't try to migrate account settings data. I don't think it's a big deal for a user to reset these values. I would think differently for some of the other settings (like which junk folder to use). I also removed the UI for sanitizing HTML in junk mail, there's no good reason to expose this via the UI.
|
0 |
|
bugzilla
4/15/2006 1:40:15 AM
mozilla.dev.super-review
29307 articles. 
3 followers.
0 Replies
818 Views
Similar Artilces:
superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> my one concern is about migration from the per-server prefs to the global prefs. What happens in that scenar...
superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220151] updated fix with review comments
Scott MacGregor <mscott@mozilla.org> has granted superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220151: updated fix with review comments https://bugzilla.mozilla.org/attachment.cgi?id=220151&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying forward david's sr and neil's r. ...
superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220052] migrate the new global settings
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220052: migrate the new global settings https://bugzilla.mozilla.org/attachment.cgi?id=220052&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> This extra patch migrates the values for: manualMark, manualMarkMode and spamLogging from the default account to the new...
superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 222679] additional change
Scott MacGregor (out of town May 11th-14th) <mscott@mozilla.org> has asked David Bienvenu - not reading bug mail from May 10th-May 18th <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 222679: additional change https://bugzilla.mozilla.org/attachment.cgi?id=222679&action=edit ------- Additional Comments from Scott MacGregor (out of town May 11th-14th) <mscott@mozilla.org> When I added manual mark as read to ...
superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220052] migrate the new global settings
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220052: migrate the new global settings https://bugzilla.mozilla.org/attachment.cgi?id=220052&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> great, thx. ...
superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 222679] additional change
David Bienvenu - not reading bug mail from May 10th-May 18th <bienvenu@nventure.com> has granted Scott MacGregor (out of town May 11th-14th) <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 222679: additional change https://bugzilla.mozilla.org/attachment.cgi?id=222679&action=edit ...
superreview requested: [Bug 216533] Move the "Composition" settings *above* the "Addressing" settings in the Account Settings : [Attachment 130078] Patch v0.1a
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 216533: Move the "Composition" settings *above* the "Addressing" settings in the Account Settings http://bugzilla.mozilla.org/show_bug.cgi?id=216533 Attachment 130078: Patch v0.1a http://bugzilla.mozilla.org/attachment.cgi?id=130078&action=edit ------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk> r= Neil carried forward ...
superreview requested: [Bug 216789] "Server Settings" tab in "Account Settings" is too big for preferences window : [Attachment 130981] Revised Patch v0.2a
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 216789: "Server Settings" tab in "Account Settings" is too big for preferences window http://bugzilla.mozilla.org/show_bug.cgi?id=216789 Attachment 130981: Revised Patch v0.2a http://bugzilla.mozilla.org/attachment.cgi?id=130981&action=edit ...
superreview granted: [Bug 216533] Move the "Composition" settings *above* the "Addressing" settings in the Account Settings : [Attachment 130078] Patch v0.1a
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 216533: Move the "Composition" settings *above* the "Addressing" settings in the Account Settings http://bugzilla.mozilla.org/show_bug.cgi?id=216533 Attachment 130078: Patch v0.1a http://bugzilla.mozilla.org/attachment.cgi?id=130078&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu ...
superreview requested: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] Fix
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog http://bugzilla.mozilla.org/show_bug.cgi?id=257801 Attachment 157725: Fix http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit ...
superreview granted: [Bug 216789] "Server Settings" tab in "Account Settings" is too big for preferences window : [Attachment 130981] Revised Patch v0.2a
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 216789: "Server Settings" tab in "Account Settings" is too big for preferences window http://bugzilla.mozilla.org/show_bug.cgi?id=216789 Attachment 130981: Revised Patch v0.2a http://bugzilla.mozilla.org/attachment.cgi?id=130981&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu ...
superreview requested: [Bug 86132] "Local Folders" (and movemail) should have "Disk Space" settings in account manager : [Attachment 146524] Patch v0.2b
Ian Neal <bugzilla@arlen.demon.co.uk> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 86132: "Local Folders" (and movemail) should have "Disk Space" settings in account manager http://bugzilla.mozilla.org/show_bug.cgi?id=86132 Attachment 146524: Patch v0.2b - altered as per suggestions above (wpud8) http://bugzilla.mozilla.org/attachment.cgi?id=146524&action=edit ...
superreview cancelled: [Bug 199262] Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons are next to each other) : [Attachment 118601] patch that swaps the "Mark" and "Junk" buttons
Adam Becevello <bugs@abecevello.imapmail.org> has cancelled Adam Becevello <bugs@abecevello.imapmail.org>'s request for superreview: Bug 199262: Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons are next to each other) https://bugzilla.mozilla.org/show_bug.cgi?id=199262 Attachment 118601: patch that swaps the "Mark" and "Junk" buttons https://bugzilla.mozilla.org/attachment.cgi?id=118601&action=edit ------- Additional Comments from Adam Becevello <bugs@abecevello.imapmail.org> Remo...
superreview granted: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] Fix
David Bienvenu <bienvenu@nventure.com> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog http://bugzilla.mozilla.org/show_bug.cgi?id=257801 Attachment 157725: Fix http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx. I'm in the middle of making changes to this code, but I don't think this wil...
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> my one concern is about migration from the per-server prefs to the global prefs. What happens in that scenar...
superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220151] updated fix with review comments
Scott MacGregor <mscott@mozilla.org> has granted superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220151: updated fix with review comments https://bugzilla.mozilla.org/attachment.cgi?id=220151&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying forward david's sr and neil's r. ...
superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220052] migrate the new global settings
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220052: migrate the new global settings https://bugzilla.mozilla.org/attachment.cgi?id=220052&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> This extra patch migrates the values for: manualMark, manualMarkMode and spamLogging from the default account to the new...
superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 222679] additional change
Scott MacGregor (out of town May 11th-14th) <mscott@mozilla.org> has asked David Bienvenu - not reading bug mail from May 10th-May 18th <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 222679: additional change https://bugzilla.mozilla.org/attachment.cgi?id=222679&action=edit ------- Additional Comments from Scott MacGregor (out of town May 11th-14th) <mscott@mozilla.org> When I added manual mark as read to ...
superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220052] migrate the new global settings
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220052: migrate the new global settings https://bugzilla.mozilla.org/attachment.cgi?id=220052&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> great, thx. ...
superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 222679] additional change
David Bienvenu - not reading bug mail from May 10th-May 18th <bienvenu@nventure.com> has granted Scott MacGregor (out of town May 11th-14th) <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 222679: additional change https://bugzilla.mozilla.org/attachment.cgi?id=222679&action=edit ...
superreview requested: [Bug 216533] Move the "Composition" settings *above* the "Addressing" settings in the Account Settings : [Attachment 130078] Patch v0.1a
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 216533: Move the "Composition" settings *above* the "Addressing" settings in the Account Settings http://bugzilla.mozilla.org/show_bug.cgi?id=216533 Attachment 130078: Patch v0.1a http://bugzilla.mozilla.org/attachment.cgi?id=130078&action=edit ------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk> r= Neil carried forward ...
superreview requested: [Bug 216789] "Server Settings" tab in "Account Settings" is too big for preferences window : [Attachment 130981] Revised Patch v0.2a
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 216789: "Server Settings" tab in "Account Settings" is too big for preferences window http://bugzilla.mozilla.org/show_bug.cgi?id=216789 Attachment 130981: Revised Patch v0.2a http://bugzilla.mozilla.org/attachment.cgi?id=130981&action=edit ...
superreview granted: [Bug 216533] Move the "Composition" settings *above* the "Addressing" settings in the Account Settings : [Attachment 130078] Patch v0.1a
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 216533: Move the "Composition" settings *above* the "Addressing" settings in the Account Settings http://bugzilla.mozilla.org/show_bug.cgi?id=216533 Attachment 130078: Patch v0.1a http://bugzilla.mozilla.org/attachment.cgi?id=130078&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu ...
superreview requested: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] Fix
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog http://bugzilla.mozilla.org/show_bug.cgi?id=257801 Attachment 157725: Fix http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit ...
superreview granted: [Bug 216789] "Server Settings" tab in "Account Settings" is too big for preferences window : [Attachment 130981] Revised Patch v0.2a
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 216789: "Server Settings" tab in "Account Settings" is too big for preferences window http://bugzilla.mozilla.org/show_bug.cgi?id=216789 Attachment 130981: Revised Patch v0.2a http://bugzilla.mozilla.org/attachment.cgi?id=130981&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu ...
superreview requested: [Bug 86132] "Local Folders" (and movemail) should have "Disk Space" settings in account manager : [Attachment 146524] Patch v0.2b
Ian Neal <bugzilla@arlen.demon.co.uk> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 86132: "Local Folders" (and movemail) should have "Disk Space" settings in account manager http://bugzilla.mozilla.org/show_bug.cgi?id=86132 Attachment 146524: Patch v0.2b - altered as per suggestions above (wpud8) http://bugzilla.mozilla.org/attachment.cgi?id=146524&action=edit ...
superreview cancelled: [Bug 199262] Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons are next to each other) : [Attachment 118601] patch that swaps the "Mark" and "Junk" buttons
Adam Becevello <bugs@abecevello.imapmail.org> has cancelled Adam Becevello <bugs@abecevello.imapmail.org>'s request for superreview: Bug 199262: Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons are next to each other) https://bugzilla.mozilla.org/show_bug.cgi?id=199262 Attachment 118601: patch that swaps the "Mark" and "Junk" buttons https://bugzilla.mozilla.org/attachment.cgi?id=118601&action=edit ------- Additional Comments from Adam Becevello <bugs@abecevello.imapmail.org> Remo...
superreview granted: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] Fix
David Bienvenu <bienvenu@nventure.com> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog http://bugzilla.mozilla.org/show_bug.cgi?id=257801 Attachment 157725: Fix http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx. I'm in the middle of making changes to this code, but I don't think this wil...
Web resources about - superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review - mozilla.dev.super-reviewResources last updated: 12/7/2015 7:18:26 AM