superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews

Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972

Attachment 227973: tweaks in response to reviews
https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit

------- Additional Comments from Marria Nazif <marria@gmail.com>
(In reply to comment #60)
> (From update of attachment 227564 [edit])
> So this window is only closed when the user chooses an action, not as soon as

> the helper dialog appears?

Correct.  I figured that one is no better than the other.  Also, I believe the
refresh header detection happens later as the code is now, so it's easier to
make the window closing code later too.

> docshell/base/nsDocShell.cpp
>	   // Transfer the load to the target DocShell...  Pass nsnull as the
>	   // window target name from to prevent recursive retargeting!
>	   //
>	   if (NS_SUCCEEDED(rv) && targetDocShell) {
> +	       aFlags |= INTERNAL_LOAD_FLAGS_NEW_WINDOW;
> 
> Hm... isn't this case also hit if the load gets targeted to an existing
window?
> 

Yea, I think you are right, moved this up to where we detect that a new window
needs to be opened.

> 
> webshell/public/nsIRefreshURI.idl
> \ No newline at end of file
> 
> please add one :)
> 

added :-)

(In reply to comment #59)
> (From update of attachment 227564 [edit])
> >Index: docshell/base/nsDocShell.cpp
> 
> >	    if (!refreshHeader.IsEmpty()) {
> >		SetupReferrerFromChannel(aChannel);
> >		rv = SetupRefreshURIFromHeader(mCurrentURI, refreshHeader);
> >+		if (NS_SUCCEEDED(rv)) {
> >+		  return NS_REFRESHURI_HEADER_FOUND;
> >+		}
> >	    }
> >	}
> 
> whoops... 4 space indentation
> 
> 
> >+	if (aIsNewWindowTarget) {
> >+	  nsCOMPtr<nsIWritablePropertyBag2> props = do_QueryInterface(channel);

> >+	  if (props) {
> >+	   
props->SetPropertyAsBool(NS_LITERAL_STRING("docshell.newWindowTarget"),
> >+				     PR_TRUE);
> >+	  }
> >+	}
> 
> ditto 

done and done.
0
bugzilla
7/3/2006 8:41:48 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
1058 Views

Similar Articles

[PageSpeed] 27

Reply:

Similar Artilces:


superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> Actually, I'm going to go ahead and check this in on the trunk, since thes...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> > >+ /** > >+ * This is set based on whether the channel indica...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank window
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225294: close blank window https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> This is a first try at closing the window after the external app handler has done its work. This se...

superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's re
Darin Fisher (Google) <darin@meer.net> has granted Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: docshell/base/nsDocShell.cpp > if (!r...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank window
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225294: close blank window https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225651] check that session history is
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225651: check that session history is empty https://bugzilla.mozilla.org/attachment.cgi?id=225651&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226289] pass state in the channel
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 226289: pass state in the channel https://bugzilla.mozilla.org/attachment.cgi?id=226289&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> This is another idea I had - we can pass state on the channel which indicates whether a new ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225903] docshell tracks whether it lo
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225903: docshell tracks whether it loaded any content before https://bugzilla.mozilla.org/attachment.cgi?id=225903&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> I added something to the DocShell which tracks if it ever loaded a...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226606] store state in channel, works
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 226606: store state in channel, works for target= as well as window.open https://bugzilla.mozilla.org/attachment.cgi?id=226606&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> This is a second iteration on the patch that stores s...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226289] pass state in the channel
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 226289: pass state in the channel https://bugzilla.mozilla.org/attachment.cgi?id=226289&action=edit ...

superreview denied: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225651] check that session history is em
Darin Fisher (Google) <darin@meer.net> has denied Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225651: check that session history is empty https://bugzilla.mozilla.org/attachment.cgi?id=225651&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> Marria and I discussed this today. She's got a much bett...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225903] docshell tracks whether it lo
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225903: docshell tracks whether it loaded any content before https://bugzilla.mozilla.org/attachment.cgi?id=225903&action=edit ...

superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226606] store state in channel, works f
Darin Fisher (Google) <darin@meer.net> has granted Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 226606: store state in channel, works for target= as well as window.open https://bugzilla.mozilla.org/attachment.cgi?id=226606&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: docshell/base/nsDoc...

Bug 241972 new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins
Bug 241972 new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins This bug is filed against Firefox but aren't all these files under core? <https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=view> DocShell, WebNavigation, WindowWatcher, etc. Will this patch be picked up by SeaMonkey trunk? Phil -- Philip Chee <philip@aleytys.pc.my>, <philip.chee@gmail.com> http://flashblock.mozdev.org/ http://xsidebar.mozdev.org Guard us from the she-wolf and the wolf, and guard ...

Web resources about - superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews - mozilla.dev.super-review

Resources last updated: 12/3/2015 8:35:43 PM