superreview denied: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225651] check that session history is emDarin Fisher (Google) <darin@meer.net> has denied Marria Nazif
<marria@gmail.com>'s request for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 225651: check that session history is empty
https://bugzilla.mozilla.org/attachment.cgi?id=225651&action=edit
------- Additional Comments from Darin Fisher (Google) <darin@meer.net>
Marria and I discussed this today. She's got a much bett...
superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank windowMarria Nazif <marria@gmail.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 225294: close blank window
https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit
------- Additional Comments from Marria Nazif <marria@gmail.com>
This is a first try at closing the window after the external app handler has
done its work. This se...
superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviewsMarria Nazif <marria@gmail.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 227973: tweaks in response to reviews
https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit
------- Additional Comments from Marria Nazif <marria@gmail.com>
(In reply to comment #60)
> (From update of attachment 227564 [edit])
> So this w...
superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 227564: fixes in response to Darin's review
https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit
------- Additional Comments from Marria Nazif <marria@gmail.com>
> >+ /**
> >+ * This is set based on whether the channel indica...
superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank windowMarria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s
request for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 225294: close blank window
https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit
...
superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviewsMarria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s
request for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 227973: tweaks in response to reviews
https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit
------- Additional Comments from Marria Nazif <marria@gmail.com>
Actually, I'm going to go ahead and check this in on the trunk, since thes...
superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226289] pass state in the channelMarria Nazif <marria@gmail.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 226289: pass state in the channel
https://bugzilla.mozilla.org/attachment.cgi?id=226289&action=edit
------- Additional Comments from Marria Nazif <marria@gmail.com>
This is another idea I had - we can pass state on the channel which indicates
whether a new ...
superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225903] docshell tracks whether it loMarria Nazif <marria@gmail.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 225903: docshell tracks whether it loaded any content before
https://bugzilla.mozilla.org/attachment.cgi?id=225903&action=edit
------- Additional Comments from Marria Nazif <marria@gmail.com>
I added something to the DocShell which tracks if it ever loaded a...
superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226606] store state in channel, worksMarria Nazif <marria@gmail.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 226606: store state in channel, works for target= as well as
window.open
https://bugzilla.mozilla.org/attachment.cgi?id=226606&action=edit
------- Additional Comments from Marria Nazif <marria@gmail.com>
This is a second iteration on the patch that stores s...
superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's reDarin Fisher (Google) <darin@meer.net> has granted Marria Nazif
<marria@gmail.com>'s request for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 227564: fixes in response to Darin's review
https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit
------- Additional Comments from Darin Fisher (Google) <darin@meer.net>
>Index: docshell/base/nsDocShell.cpp
> if (!r...
superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226289] pass state in the channelMarria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s
request for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 226289: pass state in the channel
https://bugzilla.mozilla.org/attachment.cgi?id=226289&action=edit
...
superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225903] docshell tracks whether it loMarria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s
request for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 225903: docshell tracks whether it loaded any content before
https://bugzilla.mozilla.org/attachment.cgi?id=225903&action=edit
...
superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226606] store state in channel, works fDarin Fisher (Google) <darin@meer.net> has granted Marria Nazif
<marria@gmail.com>'s request for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 226606: store state in channel, works for target= as well as
window.open
https://bugzilla.mozilla.org/attachment.cgi?id=226606&action=edit
------- Additional Comments from Darin Fisher (Google) <darin@meer.net>
>Index: docshell/base/nsDoc...
Bug 241972 new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download beginsBug 241972 new window opened by window.open('xxx.exe') or
target="_blank" isn't closed automatically when a download begins
This bug is filed against Firefox but aren't all these files under core?
<https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=view>
DocShell, WebNavigation, WindowWatcher, etc. Will this patch be picked
up by SeaMonkey trunk?
Phil
--
Philip Chee <philip@aleytys.pc.my>, <philip.chee@gmail.com>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard ...