superreview requested: [Bug 230555] Add support for pre-line value of white-space : [Attachment 326243] fix

Robert O'Callahan (:roc) <roc@ocallahan.org> has asked David Baron [:dbaron]
(unreachable June 20-29) <dbaron@mozilla.com> for superreview:
Bug 230555: Add support for pre-line value of white-space
https://bugzilla.mozilla.org/show_bug.cgi?id=230555

Attachment 326243: fix
https://bugzilla.mozilla.org/attachment.cgi?id=326243&action=edit

------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org>
Here's a patch.

One issue here is the interaction with text-align:justify. The spec tries to
disable justification for white-space:pre and pre-line, but it doesn't make
much sense. I raised the issue on www-style. For now I'm leaving our existing
behaviour unchanged; pre-line text can be justified, pre-wrap can't. There's a
test for this now.
0
bugzilla
6/23/2008 5:10:54 AM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
384 Views

Similar Articles

[PageSpeed] 8

Reply:

Similar Artilces:

superreview canceled: [Bug 230555] Add support for pre-line value of white-space : [Attachment 326243] fix
Robert O'Callahan (:roc) <roc@ocallahan.org> has canceled Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 230555: Add support for pre-line value of white-space https://bugzilla.mozilla.org/show_bug.cgi?id=230555 Attachment 326243: fix https://bugzilla.mozilla.org/attachment.cgi?id=326243&action=edit ...

superreview requested: [Bug 230555] Add support for pre-line value of white-space : [Attachment 328820] fix v2, now with tests
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 230555: Add support for pre-line value of white-space https://bugzilla.mozilla.org/show_bug.cgi?id=230555 Attachment 328820: fix v2, now with tests https://bugzilla.mozilla.org/attachment.cgi?id=328820&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> OK, this fixes the text-align behaviour (and adds a test for it of course). ...

superreview granted: [Bug 230555] Add support for pre-line value of white-space : [Attachment 328820] fix v2, now with tests
David Baron [:dbaron] <dbaron@mozilla.com> has granted Robert O'Callahan (:= roc) (Mozilla Corporation) <roc@ocallahan.org>'s request for superreview: Bug 230555: Add support for pre-line value of white-space https://bugzilla.mozilla.org/show_bug.cgi?id=3D230555 Attachment 328820: fix v2, now with tests https://bugzilla.mozilla.org/attachment.cgi?id=3D328820&action=3Dedit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> +static const nsTextFrameUtils::CompressionMode CSSWhitespaceToCompressionMode[] =3D=0D +{=0D + nsTextF...

superreview requested: [Bug 312747] Include line break info for text using white-space: pre : [Attachment 199824] If text has computed style of white-space: pre, then don't expose
Aaron Leventhal (vacation: mostly gone until Oct 17) <aaronleventhal@moonset.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 312747: Include line break info for text using white-space: pre https://bugzilla.mozilla.org/show_bug.cgi?id=312747 Attachment 199824: If text has computed style of white-space: pre, then don't expose https://bugzilla.mozilla.org/attachment.cgi?id=199824&action=edit ...

superreview granted: [Bug 312747] Include line break info for text using white-space: pre : [Attachment 199824] If text has computed style of white-space: pre, then don't expose
Boris Zbarsky <bzbarsky@mit.edu> has granted Aaron Leventhal (vacation: mostly gone until Oct 17) <aaronleventhal@moonset.net>'s request for superreview: Bug 312747: Include line break info for text using white-space: pre https://bugzilla.mozilla.org/show_bug.cgi?id=312747 Attachment 199824: If text has computed style of white-space: pre, then don't expose https://bugzilla.mozilla.org/attachment.cgi?id=199824&action=edit ...

superreview requested: [Bug 246115] Add support for launching calendar to xremote : [Attachment 150389] Proposed fix to add calendar support to xremote
Mike Shaver <shaver@mozilla.org> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 246115: Add support for launching calendar to xremote http://bugzilla.mozilla.org/show_bug.cgi?id=246115 Attachment 150389: Proposed fix to add calendar support to xremote http://bugzilla.mozilla.org/attachment.cgi?id=150389&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> >+nsresult >+XRemoteService::GetCalendarLocation(const char **_retval) >+{ >+ // get the Compose chrome URL >+ *_retval = "chrome:...

superreview requested: [Bug 260563] Add space before parenthesis in label/value accesskey case : [Attachment 159487] Add space before (x) if necessary
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 260563: Add space before parenthesis in label/value accesskey case http://bugzilla.mozilla.org/show_bug.cgi?id=260563 Attachment 159487: Add space before (x) if necessary http://bugzilla.mozilla.org/attachment.cgi?id=159487&action=edit ...

superreview requested: [Bug 260563] Add space before parenthesis in label/value accesskey case : [Attachment 159487] Add space before (x) if necessary #2
Aaron Leventhal <aaronleventhal@moonset.net> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 260563: Add space before parenthesis in label/value accesskey case https://bugzilla.mozilla.org/show_bug.cgi?id=260563 Attachment 159487: Add space before (x) if necessary https://bugzilla.mozilla.org/attachment.cgi?id=159487&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net> Trivial patch ...

superreview requested: [Bug 441418] white-space:pre with first-letter makes content disappear : [Attachment 326401] fix
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked David Baron [:dbaron] (unreachable June 20-29) <dbaron@mozilla.com> for superreview: Bug 441418: white-space:pre with first-letter makes content disappear https://bugzilla.mozilla.org/show_bug.cgi?id=441418 Attachment 326401: fix https://bugzilla.mozilla.org/attachment.cgi?id=326401&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> Don't guess, just add a new reflow status bit to indicate when a break occurred due to a first-letter frame ending. ...

superreview requested: [Bug 428332] Add the MoFo EULA line back to SeaMonkey's about:license now that bug 368091 is fixed : [Attachment 316649] Fix, v1
Smokey Ardisson (behind; no bugmail - do not email) <alqahira@ardisson.org> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 428332: Add the MoFo EULA line back to SeaMonkey's about:license now that bug 368091 is fixed https://bugzilla.mozilla.org/show_bug.cgi?id=428332 Attachment 316649: Fix, v1 https://bugzilla.mozilla.org/attachment.cgi?id=316649&action=edit ------- Additional Comments from Smokey Ardisson (behind; no bugmail - do not email) <alqahira@ardisson.org> This was a breeze to fix :) Some notes: 1) I stuck this in suit...

superreview requested: [Bug 242416] Classic theme: text in highlighted Aqua button turns white while active : [Attachment 147796] One-line fix for white text button problem (fixed)
Stefan <stefan_h@hem.utfors.se> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 242416: Classic theme: text in highlighted Aqua button turns white while active https://bugzilla.mozilla.org/show_bug.cgi?id=242416 Attachment 147796: One-line fix for white text button problem (fixed) https://bugzilla.mozilla.org/attachment.cgi?id=147796&action=edit ------- Additional Comments from Stefan <stefan_h@hem.utfors.se> Neil, can you sr this one-liner? ...

superreview requested: [Bug 285285] Add SINGLE_LINE state to single line text inputbox : [Attachment 176741] Clean up form control and text field state code, add single line extended state support
Louie Zhao <Louie.Zhao@sun.com> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 285285: Add SINGLE_LINE state to single line text inputbox https://bugzilla.mozilla.org/show_bug.cgi?id=285285 Attachment 176741: Clean up form control and text field state code, add single line extended state support https://bugzilla.mozilla.org/attachment.cgi?id=176741&action=edit ...

superreview requested: [Bug 306895] Triple click should select lines, not paragraphs, in "white-space: -moz-pre-wrap;" : [Attachment 196507] patch v1.3
Uri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 306895: Triple click should select lines, not paragraphs, in "white-space: -moz-pre-wrap;" https://bugzilla.mozilla.org/show_bug.cgi?id=306895 Attachment 196507: patch v1.3 https://bugzilla.mozilla.org/attachment.cgi?id=196507&action=edit ------- Additional Comments from Uri Bernstein <uriber@gmail.com> Yes, getting rid of mFound certainly makes it neater. I avoided "== nsnull" comaprisons, as I was once told to do (bug 277553...

superreview requested: [Bug 306895] Triple click should select lines, not paragraphs, in "white-space: -moz-pre-wrap;" and textareas : [Attachment 195007] patch v1.0
Uri Bernstein <uriber@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 306895: Triple click should select lines, not paragraphs, in "white-space: -moz-pre-wrap;" and textareas https://bugzilla.mozilla.org/show_bug.cgi?id=306895 Attachment 195007: patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=195007&action=edit ------- Additional Comments from Uri Bernstein <uriber@gmail.com> This is the "correct" solution: for pre-formatted text frames, look for a newline character at the end of the frame, and if one i...