superreview requested: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 238736] patch v3

Jason Barnabe (np) <jason_barnabe@fastmail.fm> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 226819: Javascript Object window should allow sort properties and methods
by name
https://bugzilla.mozilla.org/show_bug.cgi?id=226819

Attachment 238736: patch v3
https://bugzilla.mozilla.org/attachment.cgi?id=238736&action=edit

------- Additional Comments from Jason Barnabe (np) <jason_barnabe@fastmail.fm>
Addresses all comments.

I've tweaked the sort order a bit to handle arrays better: constants with
numeric values sorted numerically by value then alphanumerically by name, all
other constants sorted alphanumerically by name, non-constants with numeric
names sorted numerically by name (ex: array indices), all other non-constants
sorted alphanumerically by name. (Forgive the contrived example)

ELEMENT_TYPE = 1
APP_MODE = 2
DOCUMENT_TYPE = 2
DEFAULT_NAMESPACE = HTML
URI = http://example.com
0 = foo
1 = bar
2 = baz
10 = nih
app = Firefox
extension = domi
version = 3
0
bugzilla
9/16/2006 3:53:50 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
273 Views

Similar Articles

[PageSpeed] 38

Reply:

Similar Artilces:

superreview granted: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 238736] patch v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Jason Barnabe (np) <jason_barnabe@fastmail.fm>'s request for superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 238736: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=238736&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ function sortNumeric(a, b) { >+ var aIsNumeric = !isNaN(a); >+ var bIsNumeric = !isNaN(b); I'd say it's clear w...

superreview requested: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 223253] patch v1
Jason Barnabe (np) <jason_barnabe@fastmail.fm> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 223253: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=223253&action=edit ------- Additional Comments from Jason Barnabe (np) <jason_barnabe@fastmail.fm> This patch makes the properties sorted alphabetically, case-sensitive. ...

superreview requested: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 238584] patch v2
Jason Barnabe (np) <jason_barnabe@fastmail.fm> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 238584: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=238584&action=edit ------- Additional Comments from Jason Barnabe (np) <jason_barnabe@fastmail.fm> Bug 339396 doesn't seem to be causing errors with this patch any more. ...

superreview denied: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 238584] patch v2
neil@parkwaycc.co.uk <neil@httl.net> has denied Jason Barnabe (np) <jason_barnabe@fastmail.fm>'s request for superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 238584: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=238584&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+/** >+ * A sorter for the JavaScript Object view. Sort order: numeric constants, >+ * non-numeric constants, variables. The t...

superreview cancelled: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 223253] patch v1
Jason Barnabe (np) <jason_barnabe@fastmail.fm> has cancelled superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 223253: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=223253&action=edit ...

superreview granted: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 223253] patch v1
neil@parkwaycc.co.uk <neil@httl.net> has granted Jason Barnabe (np) <jason_barnabe@fastmail.fm>'s request for superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 223253: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=223253&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> sr=me assuming we come up with an agreeable sort function. ...

superreview requested: [Bug 208121] Some String properties of a Java object are read as 'null' by Javascript : [Attachment 137276] new patch addressed review comments, also add some null pointer che
Kyle Yuan <kyle.yuan@sun.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 208121: Some String properties of a Java object are read as 'null' by Javascript http://bugzilla.mozilla.org/show_bug.cgi?id=208121 Attachment 137276: new patch addressed review comments, also add some null pointer checking http://bugzilla.mozilla.org/attachment.cgi?id=137276&action=edit ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit ...

superreview requested: [Bug 193942] JavaScript object panel needs more features : [Attachment 127854] patch, v3
Alex Vincent <ajvincent@juno.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 193942: JavaScript object panel needs more features http://bugzilla.mozilla.org/show_bug.cgi?id=193942 Attachment 127854: patch, v3 http://bugzilla.mozilla.org/attachment.cgi?id=127854&action=edit ...

superreview requested: [Bug 441087] NS_ERROR_XPC_SECURITY_MANAGER_VETO in Greasemonkey JavaScript eval containing object.property : [Attachment 335735] Lastest patch
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky (todo: 200+ items) [gone 8/9--8/17] <bzbarsky@mit.edu> for superreview: Bug 441087: NS_ERROR_XPC_SECURITY_MANAGER_VETO in Greasemonkey JavaScript eval containing object.property https://bugzilla.mozilla.org/show_bug.cgi?id=441087 Attachment 335735: Lastest patch https://bugzilla.mozilla.org/attachment.cgi?id=335735&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> Sigh, yeah. ...

superreview requested: [Bug 296639] Split windows into an inner and outer object : [Attachment 192477] Followup patch that was checked in (reviews pending).
Johnny Stenback <jst@mozilla.org> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 296639: Split windows into an inner and outer object https://bugzilla.mozilla.org/show_bug.cgi?id=296639 Attachment 192477: Followup patch that was checked in (reviews pending). https://bugzilla.mozilla.org/attachment.cgi?id=192477&action=edit ...

superreview requested: [Bug 441087] NS_ERROR_XPC_SECURITY_MANAGER_VETO in Greasemonkey JavaScript eval containing object.property : [Attachment 334050] Possible 1.8 branch patch
Blake Kaplan <mrbkap@gmail.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 441087: NS_ERROR_XPC_SECURITY_MANAGER_VETO in Greasemonkey JavaScript eval containing object.property https://bugzilla.mozilla.org/show_bug.cgi?id=441087 Attachment 334050: Possible 1.8 branch patch https://bugzilla.mozilla.org/attachment.cgi?id=334050&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> Here's a potential backport to the 1.8 branch. Unfortunately, I'm having trouble testing this testcase in particular (or any test...

superreview requested: [Bug 38447] Implement Handling of URI Values on CSS "cursor" Properties : [Attachment 157887] windows patch, v3
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 38447: Implement Handling of URI Values on CSS "cursor" Properties http://bugzilla.mozilla.org/show_bug.cgi?id=38447 Attachment 157887: windows patch, v3 http://bugzilla.mozilla.org/attachment.cgi?id=157887&action=edit ...

superreview requested: [Bug 231426] CJK native font names are not recognized on non-CJK Windows and English names are not on CJK windows : [Attachment 174441] patch without caching per rbs' comment
Jungshik Shin <jshin1987@gmail.com> has asked David Baron <dbaron@mozilla.org> for superreview: Bug 231426: CJK native font names are not recognized on non-CJK Windows and English names are not on CJK windows https://bugzilla.mozilla.org/show_bug.cgi?id=231426 Attachment 174441: patch without caching per rbs' comment https://bugzilla.mozilla.org/attachment.cgi?id=174441&action=edit ...

Web resources about - superreview requested: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 238736] patch v3 - mozilla.dev.super-review

Resources last updated: 12/25/2015 11:31:07 AM