superreview requested: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 238584] patch v2

Jason Barnabe (np) <jason_barnabe@fastmail.fm> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 226819: Javascript Object window should allow sort properties and methods
by name
https://bugzilla.mozilla.org/show_bug.cgi?id=226819

Attachment 238584: patch v2
https://bugzilla.mozilla.org/attachment.cgi?id=238584&action=edit

------- Additional Comments from Jason Barnabe (np) <jason_barnabe@fastmail.fm>
Bug 339396 doesn't seem to be causing errors with this patch any more.
0
bugzilla
9/15/2006 4:20:00 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
302 Views

Similar Articles

[PageSpeed] 29

Reply:

Similar Artilces:

superreview denied: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 238584] patch v2
neil@parkwaycc.co.uk <neil@httl.net> has denied Jason Barnabe (np) <jason_barnabe@fastmail.fm>'s request for superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 238584: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=238584&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+/** >+ * A sorter for the JavaScript Object view. Sort order: numeric constants, >+ * non-numeric constants, variables. The t...

superreview requested: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 238736] patch v3
Jason Barnabe (np) <jason_barnabe@fastmail.fm> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 238736: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=238736&action=edit ------- Additional Comments from Jason Barnabe (np) <jason_barnabe@fastmail.fm> Addresses all comments. I've tweaked the sort order a bit to handle arrays better: constants with numeric values sorted numerically by ...

superreview requested: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 223253] patch v1
Jason Barnabe (np) <jason_barnabe@fastmail.fm> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 223253: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=223253&action=edit ------- Additional Comments from Jason Barnabe (np) <jason_barnabe@fastmail.fm> This patch makes the properties sorted alphabetically, case-sensitive. ...

superreview granted: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 238736] patch v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Jason Barnabe (np) <jason_barnabe@fastmail.fm>'s request for superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 238736: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=238736&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ function sortNumeric(a, b) { >+ var aIsNumeric = !isNaN(a); >+ var bIsNumeric = !isNaN(b); I'd say it's clear w...

superreview granted: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 223253] patch v1
neil@parkwaycc.co.uk <neil@httl.net> has granted Jason Barnabe (np) <jason_barnabe@fastmail.fm>'s request for superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 223253: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=223253&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> sr=me assuming we come up with an agreeable sort function. ...

superreview cancelled: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 223253] patch v1
Jason Barnabe (np) <jason_barnabe@fastmail.fm> has cancelled superreview: Bug 226819: Javascript Object window should allow sort properties and methods by name https://bugzilla.mozilla.org/show_bug.cgi?id=226819 Attachment 223253: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=223253&action=edit ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit ...

superreview requested: [Bug 208121] Some String properties of a Java object are read as 'null' by Javascript : [Attachment 137276] new patch addressed review comments, also add some null pointer che
Kyle Yuan <kyle.yuan@sun.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 208121: Some String properties of a Java object are read as 'null' by Javascript http://bugzilla.mozilla.org/show_bug.cgi?id=208121 Attachment 137276: new patch addressed review comments, also add some null pointer checking http://bugzilla.mozilla.org/attachment.cgi?id=137276&action=edit ...

superreview denied: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has denied Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't displ= ay server name https://bugzilla.mozilla.org/show_bug.cgi?id=3D393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=3D292031&action=3Dedit ------- Additional Comments from Boris Zbarsky (reviews very slow until spr= ing) <bzbarsky@mit.edu> You don't need the QI. ...

superreview requested: [Bug 339054] JavaScript object subject should be expanded when the view is loaded : [Attachment 223238] patch v2
Jason Barnabe (np) <jason_barnabe@fastmail.fm> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 339054: JavaScript object subject should be expanded when the view is loaded https://bugzilla.mozilla.org/show_bug.cgi?id=339054 Attachment 223238: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=223238&action=edit ------- Additional Comments from Jason Barnabe (np) <jason_barnabe@fastmail.fm> The right way. ...

superreview requested: [Bug 441087] NS_ERROR_XPC_SECURITY_MANAGER_VETO in Greasemonkey JavaScript eval containing object.property : [Attachment 335735] Lastest patch
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky (todo: 200+ items) [gone 8/9--8/17] <bzbarsky@mit.edu> for superreview: Bug 441087: NS_ERROR_XPC_SECURITY_MANAGER_VETO in Greasemonkey JavaScript eval containing object.property https://bugzilla.mozilla.org/show_bug.cgi?id=441087 Attachment 335735: Lastest patch https://bugzilla.mozilla.org/attachment.cgi?id=335735&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> Sigh, yeah. ...

superreview requested: [Bug 340560] Integrate the replication progress dialog into the LDAP directory properties window : [Attachment 225137] Patch v2
Mark Banner <bugzilla@standard8.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 340560: Integrate the replication progress dialog into the LDAP directory properties window https://bugzilla.mozilla.org/show_bug.cgi?id=340560 Attachment 225137: Patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=225137&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Addressed Neil's comments and carried forward his sr. ...

superreview requested: [Bug 296639] Split windows into an inner and outer object : [Attachment 192477] Followup patch that was checked in (reviews pending).
Johnny Stenback <jst@mozilla.org> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 296639: Split windows into an inner and outer object https://bugzilla.mozilla.org/show_bug.cgi?id=296639 Attachment 192477: Followup patch that was checked in (reviews pending). https://bugzilla.mozilla.org/attachment.cgi?id=192477&action=edit ...

superreview requested: [Bug 257739] [ATK] Can't read the title name of windows/dialogs : [Attachment 170938] Patch v2
Aaron Leventhal <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 257739: [ATK] Can't read the title name of windows/dialogs https://bugzilla.mozilla.org/show_bug.cgi?id=257739 Attachment 170938: Patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=170938&action=edit ...

superreview requested: [Bug 441087] NS_ERROR_XPC_SECURITY_MANAGER_VETO in Greasemonkey JavaScript eval containing object.property : [Attachment 334050] Possible 1.8 branch patch
Blake Kaplan <mrbkap@gmail.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 441087: NS_ERROR_XPC_SECURITY_MANAGER_VETO in Greasemonkey JavaScript eval containing object.property https://bugzilla.mozilla.org/show_bug.cgi?id=441087 Attachment 334050: Possible 1.8 branch patch https://bugzilla.mozilla.org/attachment.cgi?id=334050&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> Here's a potential backport to the 1.8 branch. Unfortunately, I'm having trouble testing this testcase in particular (or any test...

superreview requested: [Bug 231426] CJK native font names are not recognized on non-CJK Windows and English names are not on CJK windows : [Attachment 174441] patch without caching per rbs' comment
Jungshik Shin <jshin1987@gmail.com> has asked David Baron <dbaron@mozilla.org> for superreview: Bug 231426: CJK native font names are not recognized on non-CJK Windows and English names are not on CJK windows https://bugzilla.mozilla.org/show_bug.cgi?id=231426 Attachment 174441: patch without caching per rbs' comment https://bugzilla.mozilla.org/attachment.cgi?id=174441&action=edit ...

superreview requested: [Bug 224454] Prompts should not be application modal but just window modal : [Attachment 172346] updated patch with reviewer's objections addressed
Christian Persch <chpe@gnome.org> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 224454: Prompts should not be application modal but just window modal https://bugzilla.mozilla.org/show_bug.cgi?id=224454 Attachment 172346: updated patch with reviewer's objections addressed https://bugzilla.mozilla.org/attachment.cgi?id=172346&action=edit ...

superreview granted: [Bug 208121] Some String properties of a Java object are read as 'null' by Javascript : [Attachment 137276] new patch addressed review comments, also add some null pointer check
Brendan Eich <brendan@mozilla.org> has granted Kyle Yuan <kyle.yuan@sun.com>'s request for superreview: Bug 208121: Some String properties of a Java object are read as 'null' by Javascript http://bugzilla.mozilla.org/show_bug.cgi?id=208121 Attachment 137276: new patch addressed review comments, also add some null pointer checking http://bugzilla.mozilla.org/attachment.cgi?id=137276&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> How about a followup bug to add an Init method and move fallible code from the ctor to...

superreview requested: [Bug 103638] targets with same name in different windows open in wrong window with javascript : [Attachment 170288] Proposed fix, bz's fix with window.open() etc fixed.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 103638: targets with same name in different windows open in wrong window with javascript https://bugzilla.mozilla.org/show_bug.cgi?id=103638 Attachment 170288: Proposed fix, bz's fix with window.open() etc fixed. https://bugzilla.mozilla.org/attachment.cgi?id=170288&action=edit ...

superreview requested: [Bug 256822] JS window objects leaked when opening / closing windows : [Attachment 156960] patch
David Baron <dbaron@dbaron.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 256822: JS window objects leaked when opening / closing windows http://bugzilla.mozilla.org/show_bug.cgi?id=256822 Attachment 156960: patch http://bugzilla.mozilla.org/attachment.cgi?id=156960&action=edit ...

superreview requested: [Bug 103638] targets with same name in different windows open in wrong window with javascript : [Attachment 170310] Updated diff -w
Johnny Stenback <jst@mozilla.jstenback.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 103638: targets with same name in different windows open in wrong window with javascript https://bugzilla.mozilla.org/show_bug.cgi?id=103638 Attachment 170310: Updated diff -w https://bugzilla.mozilla.org/attachment.cgi?id=170310&action=edit ...

superreview requested: [Bug 287648] Unify 'request' object interface for DNS and PPS asyncResolve methods : [Attachment 178888] v1 patch
Darin Fisher <darin@meer.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 287648: Unify 'request' object interface for DNS and PPS asyncResolve methods https://bugzilla.mozilla.org/show_bug.cgi?id=287648 Attachment 178888: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=178888&action=edit ...

superreview requested: [Bug 425078] not showing authentication dialog box when request is made throught XMLHttpRequest in chrome window : [Attachment 314302] Patch v2
Jonas Sicking (:sicking) <jonas@sicking.cc> has asked Johnny Stenback (:jst) <jst@mozilla.org> for superreview: Bug 425078: not showing authentication dialog box when request is made throught XMLHttpRequest in chrome window https://bugzilla.mozilla.org/show_bug.cgi?id=425078 Attachment 314302: Patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=314302&action=edit ------- Additional Comments from Jonas Sicking (:sicking) <jonas@sicking.cc> That does indeed seem like the simplest solution. ...

superreview requested: [Bug 240491] in the search results window sorting columns don't show the `sorted by` arrow : [Attachment 154240] Proposed patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 240491: in the search results window sorting columns don't show the `sorted by` arrow http://bugzilla.mozilla.org/show_bug.cgi?id=240491 Attachment 154240: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=154240&action=edit ...

Web resources about - superreview requested: [Bug 226819] Javascript Object window should allow sort properties and methods by name : [Attachment 238584] patch v2 - mozilla.dev.super-review

Microsoft Updates Windows, Browsers to Patch Critical Flaws
The 13 security bulletins released by Microsoft as part of the March 2016 Patch Tuesday address tens of vulnerabilities in Windows, Internet ...

Resources last updated: 3/15/2016 9:31:02 AM