superreview granted: [Bug 216479] when opening drafts and templates for editing, we don't use the saved " return receipts" and "attach vcard" info : [Attachment 295016] proposed fix
David Bienvenu <bienvenu@nventure.com> has granted Magnus Melin <mkmelin+mozilla@iki.fi>'s request for superreview: Bug 216479: when opening drafts and templates for editing, we don't use the saved "return receipts" and "attach vcard" info https://bugzilla.mozilla.org/show_bug.cgi?id=216479 Attachment 295016: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=295016&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx, Magnus, makes sense. ...

superreview requested: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fix
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> for superreview: Bug 416063: "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) https://bugzilla.mozilla.org/show_bug.cgi?id=416063 Attachment 304041: fix https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit ...

superreview granted: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fix
Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 416063: "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) https://bugzilla.mozilla.org/show_bug.cgi?id=416063 Attachment 304041: fix https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit ------- Additional Comments from Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> sr=pink ...

superreview requested: [Bug 193698] "attachment" content shows a checkbox for "don't ask" : [Attachment 126900] fix other implementers
Christian Biesinger <cbiesinger@web.de> has asked Darin Fisher <darin@netscape.com> for superreview: Bug 193698: "attachment" content shows a checkbox for "don't ask" http://bugzilla.mozilla.org/show_bug.cgi?id=193698 Attachment 126900: fix other implementers http://bugzilla.mozilla.org/attachment.cgi?id=126900&action=edit ------- Additional Comments from Christian Biesinger <cbiesinger@web.de> bz: ok, I'll file those bugs when I checkin this patch ...

superreview requested: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1
Edward Lee (Mardak) <edilee@gmail.com> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't show completion https://bugzilla.mozilla.org/show_bug.cgi?id=418961 Attachment 305432: v1 https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit ------- Additional Comments from Edward Lee (Mardak) <edilee@gmail.com> Similar to what we needed to do for exthandler.. set the NETWORK bit. All places in webbrowserpersist that have a STATE_START ...

superreview requested: [Bug 338753] don't confuse "Sender:"-header with "From:" in quick search, thread columns : [Attachment 242434] proposed fix, v4
Magnus Melin <mkmelin+mozilla@iki.fi> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 338753: don't confuse "Sender:"-header with "From:" in quick search, thread columns https://bugzilla.mozilla.org/show_bug.cgi?id=338753 Attachment 242434: proposed fix, v4 https://bugzilla.mozilla.org/attachment.cgi?id=242434&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> Updated patch, this doesn't touch the tree col ID. Quick search doesn't match also "Sender:" for online I...

superreview requested: [Bug 338753] don't confuse "Sender:"-header with "From:" in quick search, thread columns : [Attachment 240930] proposed fix, v3
Magnus Melin <mkmelin+mozilla@iki.fi> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 338753: don't confuse "Sender:"-header with "From:" in quick search, thread columns https://bugzilla.mozilla.org/show_bug.cgi?id=338753 Attachment 240930: proposed fix, v3 https://bugzilla.mozilla.org/attachment.cgi?id=240930&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> Changes from v2: made search for From match "Sender:" also. One caveat: For some reason matching "Sender:"...

superreview requested: [Bug 193698] "attachment" content shows a checkbox for "don't ask" : [Attachment 126870] patch
Christian Biesinger <cbiesinger@web.de> has asked Darin Fisher <darin@netscape.com> for superreview: Bug 193698: "attachment" content shows a checkbox for "don't ask" http://bugzilla.mozilla.org/show_bug.cgi?id=193698 Attachment 126870: patch http://bugzilla.mozilla.org/attachment.cgi?id=126870&action=edit ...

superreview requested: [Bug 299699] don't check for "Internet" property in "Email" line of vCard : [Attachment 188272] patch to make vCard parsing more lenient
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 299699: don't check for "Internet" property in "Email" line of vCard https://bugzilla.mozilla.org/show_bug.cgi?id=299699 Attachment 188272: patch to make vCard parsing more lenient https://bugzilla.mozilla.org/attachment.cgi?id=188272&action=edit ...

superreview granted: [Bug 193698] "attachment" content shows a checkbox for "don't ask" : [Attachment 126900] fix other implementers
Darin Fisher <darin@netscape.com> has granted Christian Biesinger <cbiesinger@web.de>'s request for superreview: Bug 193698: "attachment" content shows a checkbox for "don't ask" http://bugzilla.mozilla.org/show_bug.cgi?id=193698 Attachment 126900: fix other implementers http://bugzilla.mozilla.org/attachment.cgi?id=126900&action=edit ------- Additional Comments from Darin Fisher <darin@netscape.com> sr=darin ...

superreview requested: [Bug 383545] "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" : [Attachment 294627] Don 't Quit, now with better caps
Chris Lawson (cl-bugs) <cl-bugs@chrislawson.net> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 383545: "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" https://bugzilla.mozilla.org/show_bug.cgi?id=383545 Attachment 294627: Don't Quit, now with better caps https://bugzilla.mozilla.org/attachment.cgi?id=294627&action=edit ------- Additional Comments from Chris Lawson (cl-bugs) <cl-bugs@chrislawson.net> r=me. Thanks for fixing the code as well. ...

superreview granted: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1
Christian :Biesinger <cbiesinger@gmail.com> has granted Edward Lee (Mardak) <edilee@gmail.com>'s request for superreview: Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't show completion https://bugzilla.mozilla.org/show_bug.cgi?id=418961 Attachment 305432: v1 https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit ...

superreview cancelled: [Bug 338753] don't confuse "Sender:"-header with "From:" in quick search, thread columns : [Attachment 240930] proposed fix, v3
Magnus Melin <mkmelin+mozilla@iki.fi> has cancelled Magnus Melin <mkmelin+mozilla@iki.fi>'s request for superreview: Bug 338753: don't confuse "Sender:"-header with "From:" in quick search, thread columns https://bugzilla.mozilla.org/show_bug.cgi?id=338753 Attachment 240930: proposed fix, v3 https://bugzilla.mozilla.org/attachment.cgi?id=240930&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> Updated patch, this doesn't touch the tree col ID. Quick search doesn't match also "Sender:...

superreview cancelled: [Bug 338753] don't confuse "Sender:"-header with "From:" in quick search, thread columns : [Attachment 234683] proposed fix, v2
Magnus Melin <mkmelin+mozilla@iki.fi> has cancelled David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 338753: don't confuse "Sender:"-header with "From:" in quick search, thread columns https://bugzilla.mozilla.org/show_bug.cgi?id=338753 Attachment 234683: proposed fix, v2 https://bugzilla.mozilla.org/attachment.cgi?id=234683&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> Changes from v2: made search for From match "Sender:" also. One caveat: For some reason matching...