superreview requested: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly #2

David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 216456: 'font' with system font keyword and 'font-family' with generic font
family keyword behaving incorrectly
https://bugzilla.mozilla.org/show_bug.cgi?id=216456

Attachment 271263: patch
https://bugzilla.mozilla.org/attachment.cgi?id=271263&action=edit

------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com>
....but I can effectively skip the optimization by changing SetGenericFont,
which fixes the major problems with this interaction (although I think some
remain; see the XXXldb comment being added).
0
bugzilla
7/6/2007 8:42:15 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
553 Views

Similar Articles

[PageSpeed] 41

Reply:

Similar Artilces:

superreview requested: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly
David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky (not available till July 4) <bzbarsky@mit.edu> for superreview: Bug 216456: 'font' with system font keyword and 'font-family' with generic font family keyword behaving incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=216456 Attachment 271007: patch https://bugzilla.mozilla.org/attachment.cgi?id=271007&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> We can't stomp on aFont as temporary storage because it's sometimes the only...

superreview canceled: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly
David Baron [:dbaron] <dbaron@mozilla.com> has canceled David Baron [:dbaron] <dbaron@mozilla.com>'s request for superreview: Bug 216456: 'font' with system font keyword and 'font-family' with generic font family keyword behaving incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=216456 Attachment 271007: patch https://bugzilla.mozilla.org/attachment.cgi?id=271007&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> This seems to break generic fonts entirely, though. ...

superreview granted: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly
Boris Zbarsky <bzbarsky@mit.edu> has granted David Baron [:dbaron] <dbaron@mozilla.com>'s request for superreview: Bug 216456: 'font' with system font keyword and 'font-family' with generic = font family keyword behaving incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=3D216456 Attachment 271263: patch https://bugzilla.mozilla.org/attachment.cgi?id=3D271263&action=3Dedit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >+ if (i !=3D 0)=0D >+ fontData.mFamily.Reset(); // avoid unnecessary operations in Set...

superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> This proved to be pretty simple to fix, with some caveats. The attached pa= tch passes Hixie's test linke...

superreview canceled: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has canceled Zack Weinberg <zweinberg@mozilla.com>'s request for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=323226&action=edit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> retracting review request. ...

superreview requested: [Bug 420822] Hiragino fonts display as bold for 'font-weight:500' : [Attachment 307170] patch, missing 500 weight font should fallback to lighter weights #2
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 420822: Hiragino fonts display as bold for 'font-weight:500' https://bugzilla.mozilla.org/show_bug.cgi?id=420822 Attachment 307170: patch, missing 500 weight font should fallback to lighter weights https://bugzilla.mozilla.org/attachment.cgi?id=307170&action=edit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> (In reply to comment #5) > I've never looked at this code before in my life, maybe Stuart should re...

superreview requested: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) #2
Robert O'Callahan <roc@ocallahan.org> has asked David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 281245: updated patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=281245&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> Updated patch ... still nee...

superreview requested: [Bug 366138] The line-height should refer to adjusted font size, not 'font-size' #2
Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 366138: The line-height should refer to adjusted font size, not 'font-size' https://bugzilla.mozilla.org/show_bug.cgi?id=366138 Attachment 260557: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=260557&action=edit ...

superreview requested: [Bug 420822] Hiragino fonts display as bold for 'font-weight:500' : [Attachment 307170] patch, missing 500 weight font should fallback to lighter weights
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 420822: Hiragino fonts display as bold for 'font-weight:500' https://bugzilla.mozilla.org/show_bug.cgi?id=420822 Attachment 307170: patch, missing 500 weight font should fallback to lighter weights https://bugzilla.mozilla.org/attachment.cgi?id=307170&action=edit ...

superreview requested: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem)
Robert O'Callahan <roc@ocallahan.org> has asked David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 278456: updated patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=278456&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> The layout changes need rev...

superreview requested: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) #3
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 281783: updated patch v6 https://bugzilla.mozilla.org/attachment.cgi?id=281783&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> updated to th...

superreview canceled: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) #2
Robert O'Callahan (:roc) <roc@ocallahan.org> has canceled Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 281245: updated patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=281245&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> updated to those comments ...

superreview granted: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) #2
David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> has granted superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 282043: updated patch v7 https://bugzilla.mozilla.org/attachment.cgi?id=282043&action=edit ------- Additional Comments from David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> File a bug on the XXX comment in nsBu...

superreview requested: [Bug 366138] The line-height should refer to adjusted font size, not 'font-size'
Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 366138: The line-height should refer to adjusted font size, not 'font-size' https://bugzilla.mozilla.org/show_bug.cgi?id=366138 Attachment 259881: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=259881&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> fix. We should use actual font size for any relative sizes. ...

Web resources about - superreview requested: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly #2 - mozilla.dev.super-review

Resources last updated: 1/12/2016 4:09:20 PM