superreview requested: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly

David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky (not
available till July 4) <bzbarsky@mit.edu> for superreview:
Bug 216456: 'font' with system font keyword and 'font-family' with generic font
family keyword behaving incorrectly
https://bugzilla.mozilla.org/show_bug.cgi?id=216456

Attachment 271007: patch
https://bugzilla.mozilla.org/attachment.cgi?id=271007&action=edit

------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com>
We can't stomp on aFont as temporary storage because it's sometimes the only
copy of aStartStruct we have, and we're not allowed to modify it.

I'm comfortable passing parentFont twice, since the COMPUTE_START_* macros
often set up the parent struct as the same as the struct, so we have to be able
to handle that in general.  And the code looks like it handles it fine.

This code still scares me a little, but I think this is right.
0
bugzilla
7/5/2007 7:39:02 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
519 Views

Similar Articles

[PageSpeed] 18

Reply:

Similar Artilces:

superreview requested: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly #2
David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 216456: 'font' with system font keyword and 'font-family' with generic font family keyword behaving incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=216456 Attachment 271263: patch https://bugzilla.mozilla.org/attachment.cgi?id=271263&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> ....but I can effectively skip the optimization by changing SetGenericFont, which fixes the major problems with...

superreview canceled: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly
David Baron [:dbaron] <dbaron@mozilla.com> has canceled David Baron [:dbaron] <dbaron@mozilla.com>'s request for superreview: Bug 216456: 'font' with system font keyword and 'font-family' with generic font family keyword behaving incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=216456 Attachment 271007: patch https://bugzilla.mozilla.org/attachment.cgi?id=271007&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> This seems to break generic fonts entirely, though. ...

superreview granted: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly
Boris Zbarsky <bzbarsky@mit.edu> has granted David Baron [:dbaron] <dbaron@mozilla.com>'s request for superreview: Bug 216456: 'font' with system font keyword and 'font-family' with generic = font family keyword behaving incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=3D216456 Attachment 271263: patch https://bugzilla.mozilla.org/attachment.cgi?id=3D271263&action=3Dedit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >+ if (i !=3D 0)=0D >+ fontData.mFamily.Reset(); // avoid unnecessary operations in Set...

superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> This proved to be pretty simple to fix, with some caveats. The attached pa= tch passes Hixie's test linke...

superreview canceled: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has canceled Zack Weinberg <zweinberg@mozilla.com>'s request for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=323226&action=edit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> retracting review request. ...

superreview requested: [Bug 420822] Hiragino fonts display as bold for 'font-weight:500' : [Attachment 307170] patch, missing 500 weight font should fallback to lighter weights
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 420822: Hiragino fonts display as bold for 'font-weight:500' https://bugzilla.mozilla.org/show_bug.cgi?id=420822 Attachment 307170: patch, missing 500 weight font should fallback to lighter weights https://bugzilla.mozilla.org/attachment.cgi?id=307170&action=edit ...

superreview requested: [Bug 420822] Hiragino fonts display as bold for 'font-weight:500' : [Attachment 307170] patch, missing 500 weight font should fallback to lighter weights #2
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 420822: Hiragino fonts display as bold for 'font-weight:500' https://bugzilla.mozilla.org/show_bug.cgi?id=420822 Attachment 307170: patch, missing 500 weight font should fallback to lighter weights https://bugzilla.mozilla.org/attachment.cgi?id=307170&action=edit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> (In reply to comment #5) > I've never looked at this code before in my life, maybe Stuart should re...

superreview requested: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem)
Robert O'Callahan <roc@ocallahan.org> has asked David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 278456: updated patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=278456&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> The layout changes need rev...

superreview requested: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) #2
Robert O'Callahan <roc@ocallahan.org> has asked David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 281245: updated patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=281245&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> Updated patch ... still nee...

superreview requested: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) #3
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 281783: updated patch v6 https://bugzilla.mozilla.org/attachment.cgi?id=281783&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> updated to th...

superreview requested: [Bug 366138] The line-height should refer to adjusted font size, not 'font-size'
Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 366138: The line-height should refer to adjusted font size, not 'font-size' https://bugzilla.mozilla.org/show_bug.cgi?id=366138 Attachment 259881: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=259881&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> fix. We should use actual font size for any relative sizes. ...

IMP for indian national language"Hindi fonts 'or' u can say Devanagri font 'or' known as mangal font in word pad"
Name: sourabh verma Email: sourabh.iitm_at_gmail.com Product: Firefox Summary: IMP for indian national language"Hindi fonts 'or' u can say Devanagri font 'or' known as mangal font in word pad" Comments: Sir, I would like to tell you that "Hindi fonts 'or' u can say Devanagri font 'or' known as mangal font in word pad" are not coming properly in mozilla. They r coming properly in internet explorer.. words like &#2354;&#2375;&#2325;&#2367;&#2344; , &#2348;&#2361;&#2369;&#2340; ,&#2311;...

superreview requested: [Bug 366138] The line-height should refer to adjusted font size, not 'font-size' #2
Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 366138: The line-height should refer to adjusted font size, not 'font-size' https://bugzilla.mozilla.org/show_bug.cgi?id=366138 Attachment 260557: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=260557&action=edit ...

superreview requested: [Bug 366138] The line-height should refer to adjusted font size, not 'font-size' #3
Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 366138: The line-height should refer to adjusted font size, not 'font-size' https://bugzilla.mozilla.org/show_bug.cgi?id=366138 Attachment 260565: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=260565&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> Sorry. The patch has a gfx code. We need some easy work in gfx after this. ...

Web resources about - superreview requested: [Bug 216456] 'font' with system font keyword and ' font-family' with generic font family keyword behaving incorrectly - mozilla.dev.super-review

Resources last updated: 12/10/2015 10:03:58 PM