superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update

Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang
<wtchang@redhat.com> for superreview:
Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just
using /dev/urandom
https://bugzilla.mozilla.org/show_bug.cgi?id=182758

Attachment 236342: update
https://bugzilla.mozilla.org/attachment.cgi?id=236342&action=edit

------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com>
This patch contains several changes :
1) More comments
2) CollectEntropy and RNG_kstat are both changed to return a SECStatus . This
is to ease future work in bug 350798 to check for success
3) CollectEntropy has an extra PRUint32 *total_fed argument which gets
incremented
4) RNG_kstat has an extra PRUInt32* fed argument to return the number of bytes
of entropy that it generated and fed to the RNG
5) CollectEntropy now only feeds data to the RNG if the buffer is full, and
will never pass a zero length to RNG_RandomUpdate
6) CollectEntropy local variable buffered renamed to processed
7) CollectEntropy argument entropy_collected renamed to entropy_buffered. Same
for RNG_kstat local
0
bugzilla
9/1/2006 12:47:16 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
561 Views

Similar Articles

[PageSpeed] 6

Reply:

Similar Artilces:

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235522] On Solaris, use only /dev/urandom if it is available. If
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235522: On Solaris, use only /dev/urandom if it is available. If not, use libkstat https://bugzilla.mozilla.org/attachment.cgi?id=235522&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> In the libkstat case, I am feeding all kernel statistics to the PRNG, 4 KB ...

superreview granted: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update
Wan-Teh Chang <wtchang@redhat.com> has granted Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236342: update https://bugzilla.mozilla.org/attachment.cgi?id=236342&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> r=wtc. Please remove the 4 extraneous semicolons after closing curly braces. Just search for "};" in the file and remove ...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235586] Update
Julien Pierre <julien.pierre.bugs@sun.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235586: Update https://bugzilla.mozilla.org/attachment.cgi?id=235586&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> Wan-Teh, This was written from scratch, it wasn't sample code. I switched from assert to PORT_Assert, as well as from malloc/free to ...

superreview denied: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235522] On Solaris, use only /dev/urandom if it is available. If not
Wan-Teh Chang <wtchang@redhat.com> has denied Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235522: On Solaris, use only /dev/urandom if it is available. If not, use libkstat https://bugzilla.mozilla.org/attachment.cgi?id=235522&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> These are just some minor problems. But since there are many, I wa...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236154: Update with feedback from Nelson and Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=236154&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> - remove kprintf statements - rename max_entropy_len to max_entropy_buf_len - initialize buffered to zer...

superreview cancelled: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235586] Update
Nelson Bolyard <nelson@bolyard.com> has cancelled Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235586: Update https://bugzilla.mozilla.org/attachment.cgi?id=235586&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> I have some minor quibbles with this patch. 1) rather than seeing all the new code be "ifdef solaris" and "ifndef ...

superreview cancelled: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh
Julien Pierre <julien.pierre.bugs@sun.com> has cancelled Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236154: Update with feedback from Nelson and Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=236154&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> This patch contains several changes : 1) More comments 2) CollectEntropy and R...

superreview requested: [Bug 128673] jprof should use Linux's /dev/rtc for up-to-8KHz sampling : [Attachment 134273] slightly improved patch
Brian Ryner <bryner@brianryner.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 128673: jprof should use Linux's /dev/rtc for up-to-8KHz sampling http://bugzilla.mozilla.org/show_bug.cgi?id=128673 Attachment 134273: slightly improved patch http://bugzilla.mozilla.org/attachment.cgi?id=134273&action=edit ...

superreview requested: [Bug 128673] jprof should use Linux's /dev/rtc for up-to-8KHz sampling : [Attachment 143092] Patch to make pausing work
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 128673: jprof should use Linux's /dev/rtc for up-to-8KHz sampling http://bugzilla.mozilla.org/show_bug.cgi?id=128673 Attachment 143092: Patch to make pausing work http://bugzilla.mozilla.org/attachment.cgi?id=143092&action=edit ...

superreview requested: [Bug 249903] nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it : [Attachment 152362] updated patch as requested by the reviewer
Christian Persch <chpe@gnome.org> has asked Boris Zbarsky (out of town June 14 -- July 11, no email then) <bzbarsky@mit.edu> for superreview: Bug 249903: nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it http://bugzilla.mozilla.org/show_bug.cgi?id=249903 Attachment 152362: updated patch as requested by the reviewer http://bugzilla.mozilla.org/attachment.cgi?id=152362&action=edit ------- Additional Comments from Christian Persch <chpe@gnome.org> Carrying forward bryner's r+, and asking for sr ...

superreview requested: [Bug 422848] cycle collector warnings about insufficient traverse/unlink should print path to expected garbage : [Attachment 309311] interdiff -w /dev/null <attachment 309310>
David Baron [:dbaron] <dbaron@mozilla.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 422848: cycle collector warnings about insufficient traverse/unlink should print path to expected garbage https://bugzilla.mozilla.org/show_bug.cgi?id=422848 Attachment 309311: interdiff -w /dev/null <attachment 309310> https://bugzilla.mozilla.org/attachment.cgi?id=309311&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> This is the same thing, ignoring all the reindentation. ...

Merging dev-gaia and dev-b2g into dev-fxos
--001a113ce93ebce35d051e4c0c73 Content-Type: text/plain; charset=UTF-8 Hello people of Firefox OS, After a discussion we have decided that the distinction between dev-gaia and dev-b2g mailing lists is not enough to warrant maintaining two lists. So we are deprecating both in favor of dev-fxos. So if you are subscribed to one of the aforementioned lists, you will be subscribed to the new dev-fxos list and we will shortly be decommissioning dev-gaia and dev-b2g. Thanks! Michael --001a113ce93ebce35d051e4c0c73 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: qu...

Merging dev-gaia and dev-b2g into dev-fxos
--001a113ce93ebce35d051e4c0c73 Content-Type: text/plain; charset=UTF-8 Hello people of Firefox OS, After a discussion we have decided that the distinction between dev-gaia and dev-b2g mailing lists is not enough to warrant maintaining two lists. So we are deprecating both in favor of dev-fxos. So if you are subscribed to one of the aforementioned lists, you will be subscribed to the new dev-fxos list and we will shortly be decommissioning dev-gaia and dev-b2g. Thanks! Michael --001a113ce93ebce35d051e4c0c73 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: qu...

superreview requested: [Bug 326076] Use menulist for server secure connection (instead of radiogroup) : [Attachment 314075] Updated for review comments
Giacomo Magnini <prometeo.bugs@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 326076: Use menulist for server secure connection (instead of radiogroup) https://bugzilla.mozilla.org/show_bug.cgi?id=326076 Attachment 314075: Updated for review comments https://bugzilla.mozilla.org/attachment.cgi?id=314075&action=edit ------- Additional Comments from Giacomo Magnini <prometeo.bugs@gmail.com> Carrying over r+, asking sr? ...

superreview granted: [Bug 227986] EmbedPrompter should use GtkComboBox on gtk+ 2.4 : [Attachment 137398] updated patch with the changes requested by the reviewer
Christopher Blizzard <blizzard@mozilla.org> has granted Christopher Blizzard <blizzard@mozilla.org>'s request for superreview: Bug 227986: EmbedPrompter should use GtkComboBox on gtk+ 2.4 http://bugzilla.mozilla.org/show_bug.cgi?id=227986 Attachment 137398: updated patch with the changes requested by the reviewer http://bugzilla.mozilla.org/attachment.cgi?id=137398&action=edit ...

superreview granted: [Bug 249903] nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it : [Attachment 152362] updated patch as requested by the reviewer
Darin Fisher (IBM) <darin@meer.net> has granted Christian Persch <chpe@gnome.org>'s request for superreview: Bug 249903: nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it http://bugzilla.mozilla.org/show_bug.cgi?id=249903 Attachment 152362: updated patch as requested by the reviewer http://bugzilla.mozilla.org/attachment.cgi?id=152362&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> >Index: nsGNOMERegistry.cpp >+ return isEnabled ? PR_TRUE : PR_FALSE; return isEnabled != FALSE; ...

superreview granted: [Bug 128673] jprof should use Linux's /dev/rtc for up-to-8KHz sampling : [Attachment 134273] slightly improved patch
David Baron <dbaron@dbaron.org> has granted Brian Ryner <bryner@brianryner.com>'s request for superreview: Bug 128673: jprof should use Linux's /dev/rtc for up-to-8KHz sampling http://bugzilla.mozilla.org/show_bug.cgi?id=128673 Attachment 134273: slightly improved patch http://bugzilla.mozilla.org/attachment.cgi?id=134273&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> >+ if (!IS_POWER_OF_TWO(rtcHz) || rtcHz < 2) { >+ fprintf(stderr, "JP_RTC_HZ must be power of two and > 2, " Slight dis...

superreview requested: [Bug 224454] Prompts should not be application modal but just window modal : [Attachment 172346] updated patch with reviewer's objections addressed
Christian Persch <chpe@gnome.org> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 224454: Prompts should not be application modal but just window modal https://bugzilla.mozilla.org/show_bug.cgi?id=224454 Attachment 172346: updated patch with reviewer's objections addressed https://bugzilla.mozilla.org/attachment.cgi?id=172346&action=edit ...

superreview requested: [Bug 149834] Enhance PSM speed by using new NSS API CERT_VerifyCertificateNow : [Attachment 202387] Same patch as before, just updated to apply cleanly to the trunk
Kai Engert (kaie) <kengert@redhat.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 149834: Enhance PSM speed by using new NSS API CERT_VerifyCertificateNow https://bugzilla.mozilla.org/show_bug.cgi?id=149834 Attachment 202387: Same patch as before, just updated to apply cleanly to the trunk https://bugzilla.mozilla.org/attachment.cgi?id=202387&action=edit ...

superreview requested: [Bug 250386] Camino should look for user defined earchURLList.plist first before using the default list. : [Attachment 163203] Updated patch addressing review comments
Ludovic Hirlimann <qa-mozilla@hirlimann.net> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 250386: Camino should look for user defined earchURLList.plist first before using the default list. https://bugzilla.mozilla.org/show_bug.cgi?id=250386 Attachment 163203: Updated patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=163203&action=edit ------- Additional Comments from Ludovic Hirlimann <qa-mozilla@hirlimann.net> asking for sr ...

superreview requested: [Bug 240943] Update bidi data files to Unicode 4.0.1 : [Attachment 152143] Patch using Peter Kirk's suggestion in comment 27
Simon Montagu <smontagu@smontagu.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 240943: Update bidi data files to Unicode 4.0.1 http://bugzilla.mozilla.org/show_bug.cgi?id=240943 Attachment 152143: Patch using Peter Kirk's suggestion in comment 27 http://bugzilla.mozilla.org/attachment.cgi?id=152143&action=edit ...

superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 293819] patch, v.1.4, updated based on review comments
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 293819: patch, v.1.4, updated based on review comments https://bugzilla.mozilla.org/attachment.cgi?id=293819&action=edit ...

superreview requested: [Bug 348160] Ad-blocking blocks attachments in Gmail : [Attachment 233200] uses block rather than inline
Smokey Ardisson (gone) <alqahira@mindspring.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 348160: Ad-blocking blocks attachments in Gmail https://bugzilla.mozilla.org/show_bug.cgi?id=348160 Attachment 233200: uses block rather than inline https://bugzilla.mozilla.org/attachment.cgi?id=233200&action=edit ------- Additional Comments from Smokey Ardisson (gone) <alqahira@mindspring.com> Per philippe, restores the div as block rather than inline. ...

superreview requested: [Bug 328159] Wire up the Session-data Service : [Attachment 218774] minor update with some changes requested by mconnor
dietrich ayala <dietrich@mozilla.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 328159: Wire up the Session-data Service https://bugzilla.mozilla.org/show_bug.cgi?id=328159 Attachment 218774: minor update with some changes requested by mconnor https://bugzilla.mozilla.org/attachment.cgi?id=218774&action=edit ...

Web resources about - superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update - mozilla.dev.super-review

Resources last updated: 3/6/2016 11:31:34 PM