superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh

Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang
<wtchang@redhat.com> for superreview:
Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just
using /dev/urandom
https://bugzilla.mozilla.org/show_bug.cgi?id=182758

Attachment 236154: Update with feedback from Nelson and Wan-Teh
https://bugzilla.mozilla.org/attachment.cgi?id=236154&action=edit

------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com>
- remove kprintf statements
- rename max_entropy_len to max_entropy_buf_len
- initialize buffered to zero
- replace recursion with a while loop
- replace struct kstat with kstat_t
- add one-liners for CollectEntropy and RNG_kstat
- add and use DO_NETSTAT feature macro
- make RNG_kstat return number of entropy bytes and assert that it is non-zero
(the caller returns void, so this is the most I can do in this bug).

Wan-Teh, the doc on libkstat is available at
http://developers.sun.com/solaris/articles/kstatc.html .
0
bugzilla
8/30/2006 11:33:04 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
550 Views

Similar Articles

[PageSpeed] 38

Reply:

Similar Artilces:

superreview cancelled: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh
Julien Pierre <julien.pierre.bugs@sun.com> has cancelled Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236154: Update with feedback from Nelson and Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=236154&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> This patch contains several changes : 1) More comments 2) CollectEntropy and R...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235522] On Solaris, use only /dev/urandom if it is available. If
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235522: On Solaris, use only /dev/urandom if it is available. If not, use libkstat https://bugzilla.mozilla.org/attachment.cgi?id=235522&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> In the libkstat case, I am feeding all kernel statistics to the PRNG, 4 KB ...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235586] Update
Julien Pierre <julien.pierre.bugs@sun.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235586: Update https://bugzilla.mozilla.org/attachment.cgi?id=235586&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> Wan-Teh, This was written from scratch, it wasn't sample code. I switched from assert to PORT_Assert, as well as from malloc/free to ...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236342: update https://bugzilla.mozilla.org/attachment.cgi?id=236342&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> This patch contains several changes : 1) More comments 2) CollectEntropy and RNG_kstat are both changed to return a SECStatus . This is to ea...

superreview denied: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235522] On Solaris, use only /dev/urandom if it is available. If not
Wan-Teh Chang <wtchang@redhat.com> has denied Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235522: On Solaris, use only /dev/urandom if it is available. If not, use libkstat https://bugzilla.mozilla.org/attachment.cgi?id=235522&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> These are just some minor problems. But since there are many, I wa...

superreview granted: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update
Wan-Teh Chang <wtchang@redhat.com> has granted Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236342: update https://bugzilla.mozilla.org/attachment.cgi?id=236342&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> r=wtc. Please remove the 4 extraneous semicolons after closing curly braces. Just search for "};" in the file and remove ...

superreview cancelled: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235586] Update
Nelson Bolyard <nelson@bolyard.com> has cancelled Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235586: Update https://bugzilla.mozilla.org/attachment.cgi?id=235586&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> I have some minor quibbles with this patch. 1) rather than seeing all the new code be "ifdef solaris" and "ifndef ...

superreview requested: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 193985] Updated changes to files based on review feedback from Wan-Teh
Sandeep Konchady <Sandeep.Konchady@Sun.COM> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 193985: Updated changes to files based on review feedback from Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=193985&action=edit ------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM> 1. coreconf/import.pl Removed $var{ZIP} 2. coreconf/jdk.mk Replaced spaces with tabs to stick to the ex...

superreview requested: [Bug 115951] freebl dynamic library is never unloaded by libsoftoken or libssl. Also tiny one-time leak in freebl's loader.c : [Attachment 239727] Incorporate Wan-Teh's feedback
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 115951: freebl dynamic library is never unloaded by libsoftoken or libssl. Also tiny one-time leak in freebl's loader.c https://bugzilla.mozilla.org/show_bug.cgi?id=115951 Attachment 239727: Incorporate Wan-Teh's feedback https://bugzilla.mozilla.org/attachment.cgi?id=239727&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> 1) This patch no longer has the freebl init callback mechanism that the previous one...

superreview requested: [Bug 128673] jprof should use Linux's /dev/rtc for up-to-8KHz sampling : [Attachment 134273] slightly improved patch
Brian Ryner <bryner@brianryner.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 128673: jprof should use Linux's /dev/rtc for up-to-8KHz sampling http://bugzilla.mozilla.org/show_bug.cgi?id=128673 Attachment 134273: slightly improved patch http://bugzilla.mozilla.org/attachment.cgi?id=134273&action=edit ...

superreview requested: [Bug 128673] jprof should use Linux's /dev/rtc for up-to-8KHz sampling : [Attachment 143092] Patch to make pausing work
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 128673: jprof should use Linux's /dev/rtc for up-to-8KHz sampling http://bugzilla.mozilla.org/show_bug.cgi?id=128673 Attachment 143092: Patch to make pausing work http://bugzilla.mozilla.org/attachment.cgi?id=143092&action=edit ...

superreview denied: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 193985] Updated changes to files based on review feedback from Wan-Teh
Wan-Teh Chang <wtchang@redhat.com> has denied Sandeep Konchady <Sandeep.Konchady@Sun.COM>'s request for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 193985: Updated changes to files based on review feedback from Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=193985&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> Sandeep, Some of the changes in this patch are wrong. 1. coreconf/import.pl Just remove the $var{ZI...

superreview requested: [Bug 249903] nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it : [Attachment 152362] updated patch as requested by the reviewer
Christian Persch <chpe@gnome.org> has asked Boris Zbarsky (out of town June 14 -- July 11, no email then) <bzbarsky@mit.edu> for superreview: Bug 249903: nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it http://bugzilla.mozilla.org/show_bug.cgi?id=249903 Attachment 152362: updated patch as requested by the reviewer http://bugzilla.mozilla.org/attachment.cgi?id=152362&action=edit ------- Additional Comments from Christian Persch <chpe@gnome.org> Carrying forward bryner's r+, and asking for sr ...

superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195821] Additional patch for lib/freebl from Wan-Teh
Wan-Teh Chang <wtchang@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 195821: Additional patch for lib/freebl from Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=195821&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> This patch implements some of my suggested changes for Sun's lib/freebl patch. I eliminated the need to set the FREEBL_PARENT variable for the...

Web resources about - superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh - mozilla.dev.super-review

Resources last updated: 1/18/2016 9:45:23 AM