superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235586] Update

Julien Pierre <julien.pierre.bugs@sun.com> has asked Nelson Bolyard
<nelson@bolyard.com> for superreview:
Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just
using /dev/urandom
https://bugzilla.mozilla.org/show_bug.cgi?id=182758

Attachment 235586: Update
https://bugzilla.mozilla.org/attachment.cgi?id=235586&action=edit

------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com>
Wan-Teh,

This was written from scratch, it wasn't sample code.

I switched from assert to PORT_Assert, as well as from malloc/free to
PORT_Alloc/PORT_Free .

I made both entropy_collected and entropy_buf static locals in RNG_kstat.

I fixed the include path.

Regarding comment 8 and the ifdef, I had put it at the end rather than near the
BSDI ifdef, because if I did the later, I would get a compiler warning about
unreachable statement in the call to safe_popen . I agree it makes more logical
sense to group the BSDI and SOLARIS ifdefs, but getting rid of the compiler
warning requires an extra "ifndef SOLARIS" on the netstat forking code, which I
have included in this patch.
0
bugzilla
8/26/2006 7:37:05 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
487 Views

Similar Articles

[PageSpeed] 18

Reply:

Similar Artilces:

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235522] On Solaris, use only /dev/urandom if it is available. If
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235522: On Solaris, use only /dev/urandom if it is available. If not, use libkstat https://bugzilla.mozilla.org/attachment.cgi?id=235522&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> In the libkstat case, I am feeding all kernel statistics to the PRNG, 4 KB ...

superreview cancelled: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235586] Update
Nelson Bolyard <nelson@bolyard.com> has cancelled Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235586: Update https://bugzilla.mozilla.org/attachment.cgi?id=235586&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> I have some minor quibbles with this patch. 1) rather than seeing all the new code be "ifdef solaris" and "ifndef ...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236342: update https://bugzilla.mozilla.org/attachment.cgi?id=236342&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> This patch contains several changes : 1) More comments 2) CollectEntropy and RNG_kstat are both changed to return a SECStatus . This is to ea...

superreview denied: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235522] On Solaris, use only /dev/urandom if it is available. If not
Wan-Teh Chang <wtchang@redhat.com> has denied Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235522: On Solaris, use only /dev/urandom if it is available. If not, use libkstat https://bugzilla.mozilla.org/attachment.cgi?id=235522&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> These are just some minor problems. But since there are many, I wa...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236154: Update with feedback from Nelson and Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=236154&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> - remove kprintf statements - rename max_entropy_len to max_entropy_buf_len - initialize buffered to zer...

superreview granted: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update
Wan-Teh Chang <wtchang@redhat.com> has granted Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236342: update https://bugzilla.mozilla.org/attachment.cgi?id=236342&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> r=wtc. Please remove the 4 extraneous semicolons after closing curly braces. Just search for "};" in the file and remove ...

superreview cancelled: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh
Julien Pierre <julien.pierre.bugs@sun.com> has cancelled Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236154: Update with feedback from Nelson and Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=236154&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> This patch contains several changes : 1) More comments 2) CollectEntropy and R...

superreview requested: [Bug 128673] jprof should use Linux's /dev/rtc for up-to-8KHz sampling : [Attachment 134273] slightly improved patch
Brian Ryner <bryner@brianryner.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 128673: jprof should use Linux's /dev/rtc for up-to-8KHz sampling http://bugzilla.mozilla.org/show_bug.cgi?id=128673 Attachment 134273: slightly improved patch http://bugzilla.mozilla.org/attachment.cgi?id=134273&action=edit ...

superreview requested: [Bug 128673] jprof should use Linux's /dev/rtc for up-to-8KHz sampling : [Attachment 143092] Patch to make pausing work
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 128673: jprof should use Linux's /dev/rtc for up-to-8KHz sampling http://bugzilla.mozilla.org/show_bug.cgi?id=128673 Attachment 143092: Patch to make pausing work http://bugzilla.mozilla.org/attachment.cgi?id=143092&action=edit ...

superreview requested: [Bug 249903] nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it : [Attachment 152362] updated patch as requested by the reviewer
Christian Persch <chpe@gnome.org> has asked Boris Zbarsky (out of town June 14 -- July 11, no email then) <bzbarsky@mit.edu> for superreview: Bug 249903: nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it http://bugzilla.mozilla.org/show_bug.cgi?id=249903 Attachment 152362: updated patch as requested by the reviewer http://bugzilla.mozilla.org/attachment.cgi?id=152362&action=edit ------- Additional Comments from Christian Persch <chpe@gnome.org> Carrying forward bryner's r+, and asking for sr ...

superreview requested: [Bug 422848] cycle collector warnings about insufficient traverse/unlink should print path to expected garbage : [Attachment 309311] interdiff -w /dev/null <attachment 309310>
David Baron [:dbaron] <dbaron@mozilla.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 422848: cycle collector warnings about insufficient traverse/unlink should print path to expected garbage https://bugzilla.mozilla.org/show_bug.cgi?id=422848 Attachment 309311: interdiff -w /dev/null <attachment 309310> https://bugzilla.mozilla.org/attachment.cgi?id=309311&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> This is the same thing, ignoring all the reindentation. ...

Merging dev-gaia and dev-b2g into dev-fxos
--001a113ce93ebce35d051e4c0c73 Content-Type: text/plain; charset=UTF-8 Hello people of Firefox OS, After a discussion we have decided that the distinction between dev-gaia and dev-b2g mailing lists is not enough to warrant maintaining two lists. So we are deprecating both in favor of dev-fxos. So if you are subscribed to one of the aforementioned lists, you will be subscribed to the new dev-fxos list and we will shortly be decommissioning dev-gaia and dev-b2g. Thanks! Michael --001a113ce93ebce35d051e4c0c73 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: qu...

Merging dev-gaia and dev-b2g into dev-fxos
--001a113ce93ebce35d051e4c0c73 Content-Type: text/plain; charset=UTF-8 Hello people of Firefox OS, After a discussion we have decided that the distinction between dev-gaia and dev-b2g mailing lists is not enough to warrant maintaining two lists. So we are deprecating both in favor of dev-fxos. So if you are subscribed to one of the aforementioned lists, you will be subscribed to the new dev-fxos list and we will shortly be decommissioning dev-gaia and dev-b2g. Thanks! Michael --001a113ce93ebce35d051e4c0c73 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: qu...

superreview requested: [Bug 326076] Use menulist for server secure connection (instead of radiogroup) : [Attachment 314075] Updated for review comments
Giacomo Magnini <prometeo.bugs@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 326076: Use menulist for server secure connection (instead of radiogroup) https://bugzilla.mozilla.org/show_bug.cgi?id=326076 Attachment 314075: Updated for review comments https://bugzilla.mozilla.org/attachment.cgi?id=314075&action=edit ------- Additional Comments from Giacomo Magnini <prometeo.bugs@gmail.com> Carrying over r+, asking sr? ...