superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235522] On Solaris, use only /dev/urandom if it is available. If

Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang
<wtchang@redhat.com> for superreview:
Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just
using /dev/urandom
https://bugzilla.mozilla.org/show_bug.cgi?id=182758

Attachment 235522: On Solaris, use only /dev/urandom if it is available. If
not, use libkstat
https://bugzilla.mozilla.org/attachment.cgi?id=235522&action=edit

------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com>
In the libkstat case, I am feeding all kernel statistics to the PRNG, 4 KB at a
time. This can be about 800 - 1200 KB of data on the machines I have tested. I
don't have time to sort through which parts really change, but many do. I have
benchmarked that this code path takes between 65 and 100% of the CPU and wall
time of forking netstat, in other words, it is no worse, and sometimes better,
depending on the machiine. I came to that conclusion by timing a script that
executes certutil -L on a blank DB 100 times. I tried both on Sparc and x86 .
0
bugzilla
8/26/2006 3:35:11 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
735 Views

Similar Articles

[PageSpeed] 47

Reply:

Similar Artilces:

superreview denied: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235522] On Solaris, use only /dev/urandom if it is available. If not
Wan-Teh Chang <wtchang@redhat.com> has denied Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235522: On Solaris, use only /dev/urandom if it is available. If not, use libkstat https://bugzilla.mozilla.org/attachment.cgi?id=235522&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> These are just some minor problems. But since there are many, I wa...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236342: update https://bugzilla.mozilla.org/attachment.cgi?id=236342&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> This patch contains several changes : 1) More comments 2) CollectEntropy and RNG_kstat are both changed to return a SECStatus . This is to ea...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235586] Update
Julien Pierre <julien.pierre.bugs@sun.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235586: Update https://bugzilla.mozilla.org/attachment.cgi?id=235586&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> Wan-Teh, This was written from scratch, it wasn't sample code. I switched from assert to PORT_Assert, as well as from malloc/free to ...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236154: Update with feedback from Nelson and Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=236154&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> - remove kprintf statements - rename max_entropy_len to max_entropy_buf_len - initialize buffered to zer...

superreview cancelled: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235586] Update
Nelson Bolyard <nelson@bolyard.com> has cancelled Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235586: Update https://bugzilla.mozilla.org/attachment.cgi?id=235586&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> I have some minor quibbles with this patch. 1) rather than seeing all the new code be "ifdef solaris" and "ifndef ...

superreview granted: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update
Wan-Teh Chang <wtchang@redhat.com> has granted Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236342: update https://bugzilla.mozilla.org/attachment.cgi?id=236342&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> r=wtc. Please remove the 4 extraneous semicolons after closing curly braces. Just search for "};" in the file and remove ...

superreview cancelled: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh
Julien Pierre <julien.pierre.bugs@sun.com> has cancelled Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236154: Update with feedback from Nelson and Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=236154&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> This patch contains several changes : 1) More comments 2) CollectEntropy and R...

superreview requested: [Bug 128673] jprof should use Linux's /dev/rtc for up-to-8KHz sampling : [Attachment 134273] slightly improved patch
Brian Ryner <bryner@brianryner.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 128673: jprof should use Linux's /dev/rtc for up-to-8KHz sampling http://bugzilla.mozilla.org/show_bug.cgi?id=128673 Attachment 134273: slightly improved patch http://bugzilla.mozilla.org/attachment.cgi?id=134273&action=edit ...

superreview requested: [Bug 128673] jprof should use Linux's /dev/rtc for up-to-8KHz sampling : [Attachment 143092] Patch to make pausing work
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 128673: jprof should use Linux's /dev/rtc for up-to-8KHz sampling http://bugzilla.mozilla.org/show_bug.cgi?id=128673 Attachment 143092: Patch to make pausing work http://bugzilla.mozilla.org/attachment.cgi?id=143092&action=edit ...

Merging dev-gaia and dev-b2g into dev-fxos
--001a113ce93ebce35d051e4c0c73 Content-Type: text/plain; charset=UTF-8 Hello people of Firefox OS, After a discussion we have decided that the distinction between dev-gaia and dev-b2g mailing lists is not enough to warrant maintaining two lists. So we are deprecating both in favor of dev-fxos. So if you are subscribed to one of the aforementioned lists, you will be subscribed to the new dev-fxos list and we will shortly be decommissioning dev-gaia and dev-b2g. Thanks! Michael --001a113ce93ebce35d051e4c0c73 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: qu...

Merging dev-gaia and dev-b2g into dev-fxos
--001a113ce93ebce35d051e4c0c73 Content-Type: text/plain; charset=UTF-8 Hello people of Firefox OS, After a discussion we have decided that the distinction between dev-gaia and dev-b2g mailing lists is not enough to warrant maintaining two lists. So we are deprecating both in favor of dev-fxos. So if you are subscribed to one of the aforementioned lists, you will be subscribed to the new dev-fxos list and we will shortly be decommissioning dev-gaia and dev-b2g. Thanks! Michael --001a113ce93ebce35d051e4c0c73 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: qu...

superreview granted: [Bug 128673] jprof should use Linux's /dev/rtc for up-to-8KHz sampling : [Attachment 134273] slightly improved patch
David Baron <dbaron@dbaron.org> has granted Brian Ryner <bryner@brianryner.com>'s request for superreview: Bug 128673: jprof should use Linux's /dev/rtc for up-to-8KHz sampling http://bugzilla.mozilla.org/show_bug.cgi?id=128673 Attachment 134273: slightly improved patch http://bugzilla.mozilla.org/attachment.cgi?id=134273&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> >+ if (!IS_POWER_OF_TWO(rtcHz) || rtcHz < 2) { >+ fprintf(stderr, "JP_RTC_HZ must be power of two and > 2, " Slight dis...

[PATCH] File::Path::mkpath, /dev, /dev/dir and /dev/000000 changes
While fetching GD with CPAN.PM, I ran into some problems with File::Path::mkpath, in particular with rooted logicals: $ define/job/trans=conceal root_abcd_1 disk:[perl.cpan.build.id.blah.] mkpath('/root_abcd_1/lds') fails with a "invalid parameter" error when it tries to mkdir('/root_abcd_1'). There's a test in the code for a '000000' directory, but not for the lack of a directory....I suspect that the test was put in to prevent endless loops, prior to a modification of the File::Basename code. So here's a change that does the...

*.dev = docs/dev/*.pod ??
Hi all, I've been reading through some of the pdd's and have noticed mention of *.dev files for actual implementation of features. I'm fairly sure these are actually the pod files under docs/dev, but I just wanted to make sure of this before I make the pdd's point to the files in this directory instead of the *.dev files. Thanks! Paul Paul Cochrane wrote: > Hi all, > > I've been reading through some of the pdd's and have noticed mention > of *.dev files for actual implementation of features. I'm fairly sure > these are actually ...

Web resources about - superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235522] On Solaris, use only /dev/urandom if it is available. If - mozilla.dev.super-review

Resources last updated: 12/17/2015 7:08:16 PM