superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 238262] fix login page

David Bienvenu <bienvenu@nventure.com> has asked  for superreview:
Bug 170520: Allow SMTP server to be specified when creating new account
https://bugzilla.mozilla.org/show_bug.cgi?id=170520

Attachment 238262: fix login page
https://bugzilla.mozilla.org/attachment.cgi?id=238262&action=edit

------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
I'm going to see what Neil thinks of this patch, but I need to see if it
applies first.
0
bugzilla
7/19/2008 12:42:42 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
345 Views

Similar Articles

[PageSpeed] 56

Reply:

Similar Artilces:

superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 238262] fix login page
Alexander Ihrig <AlexIhrig@thunderbird-mail.de> has asked for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 238262: fix login page https://bugzilla.mozilla.org/attachment.cgi?id=238262&action=edit ------- Additional Comments from Alexander Ihrig <AlexIhrig@thunderbird-mail.de> David, I've taken your last patch and fixed the remaining login page bug by removing/changing the related XUL- and JS-code. Additionaly we could remove the entities "haveSmtp2****...

superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 238262] fix login page #2
Alexander Ihrig <AlexIhrig@thunderbird-mail.de> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 238262: fix login page https://bugzilla.mozilla.org/attachment.cgi?id=238262&action=edit ...

superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 236717] fix issues with previous patch
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 236717: fix issues with previous patch https://bugzilla.mozilla.org/attachment.cgi?id=236717&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I think this fixes the bugs you were seeing with the previous patch, Alex - can you try it out? I hope I haven't broken the ability for isp rdf ...

superreview cancelled: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 236717] fix issues with previous patch
David Bienvenu <bienvenu@nventure.com> has cancelled David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 236717: fix issues with previous patch https://bugzilla.mozilla.org/attachment.cgi?id=236717&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Alexander, this fixes the null smtp server problem, and perhaps the outgoing server name problem. I was not able to reproduce the p...

superreview requested: [Bug 285921] SMTP server improperly resets to default server when viewing account settings : [Attachment 179985] the fix
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 285921: SMTP server improperly resets to default server when viewing account settings https://bugzilla.mozilla.org/show_bug.cgi?id=285921 Attachment 179985: the fix https://bugzilla.mozilla.org/attachment.cgi?id=179985&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> A bit of a stop gap measure. For some reason the smtp menulist (when you don't change its value) ends up adding an undefined entry in the account manager...

superreview requested: [Bug 30057] Use one Local Mail tree for all POP3 accounts : [Attachment 148629] allow servers to defer get new mail to other account
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 30057: Use one Local Mail tree for all POP3 accounts http://bugzilla.mozilla.org/show_bug.cgi?id=30057 Attachment 148629: allow servers to defer get new mail to other account http://bugzilla.mozilla.org/attachment.cgi?id=148629&action=edit ...

superreview requested: [Bug 434978] Addressbook view not updated when a new card is created while creating a new mailing list : [Attachment 322548] Fix
Siva <sivakrishna@synovel.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 434978: Addressbook view not updated when a new card is created while creating a new mailing list https://bugzilla.mozilla.org/show_bug.cgi?id=434978 Attachment 322548: Fix https://bugzilla.mozilla.org/attachment.cgi?id=322548&action=edit ------- Additional Comments from Siva <sivakrishna@synovel.com> Neil, can you superreview the patch? ...

superreview requested: [Bug 299133] New POP account not created correctly, unusable : [Attachment 187703] mailnews part of proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 299133: New POP account not created correctly, unusable https://bugzilla.mozilla.org/show_bug.cgi?id=299133 Attachment 187703: mailnews part of proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=187703&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Doug has a patch that allows the nsIFileSpec consumer to indicate that they want to create a unique directory, and this mailnews patch uses that call. ...

superreview requested: [Bug 436848] Make it possible to specify the ldap_2.servers. preference when creating an address book : [Attachment 323357] Addressed review comments
neil@parkwaycc.co.uk <neil@httl.net> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 436848: Make it possible to specify the ldap_2.servers. preference when creating an address book https://bugzilla.mozilla.org/show_bug.cgi?id=436848 Attachment 323357: Addressed review comments https://bugzilla.mozilla.org/attachment.cgi?id=323357&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> I'm not sure what you want me to test - this feature is only intended to make it easier to (re)add the OSX, MAPI and Windows addre...

superreview requested: [Bug 300783] Fix for bug 290354 introduced unsafe firing of events : [Attachment 190321] 1) Fix unsafe firing events by creating a new class for general use called nsPLDOMEvent
Aaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 300783: Fix for bug 290354 introduced unsafe firing of events https://bugzilla.mozilla.org/show_bug.cgi?id=300783 Attachment 190321: 1) Fix unsafe firing events by creating a new class for general use called nsPLDOMEvent, 2) Remove DOM prefix from new event names, 3) For perf check to see if select has focus before firing events https://bugzilla.mozilla.org/attachment.cgi?id=190321&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventha...

superreview requested: [Bug 243837] UI for Global Inbox and deferring storage for pop3 servers to other accounts : [Attachment 150299] cumulative patch, including fix creating of inbox in local folde
David Bienvenu <bienvenu@nventure.com> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 243837: UI for Global Inbox and deferring storage for pop3 servers to other accounts http://bugzilla.mozilla.org/show_bug.cgi?id=243837 Attachment 150299: cumulative patch, including fix creating of inbox in local folders if first pop3 account is deferred http://bugzilla.mozilla.org/attachment.cgi?id=150299&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Seth said he's interesting in reviewing this. ...

superreview requested: [Bug 90507] when using authenticated SMTP smtp username value has "@{smtp server hostname}" appended to it : [Attachment 134113] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 90507: when using authenticated SMTP smtp username value has "@{smtp server hostname}" appended to it http://bugzilla.mozilla.org/show_bug.cgi?id=90507 Attachment 134113: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=134113&action=edit ...

superreview requested: [Bug 222388] Set initial SMTP server setting to "Always Use Deafult SMTP Server" instead of specific SMTP server : [Attachment 134109] patch v2
David Bienvenu <bienvenu@nventure.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 222388: Set initial SMTP server setting to "Always Use Deafult SMTP Server" instead of specific SMTP server http://bugzilla.mozilla.org/show_bug.cgi?id=222388 Attachment 134109: patch v2 http://bugzilla.mozilla.org/attachment.cgi?id=134109&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Asking Neil for r= ...

superreview granted: [Bug 285921] SMTP server improperly resets to default server when viewing account settings : [Attachment 179985] the fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 285921: SMTP server improperly resets to default server when viewing account settings https://bugzilla.mozilla.org/show_bug.cgi?id=285921 Attachment 179985: the fix https://bugzilla.mozilla.org/attachment.cgi?id=179985&action=edit ...

Web resources about - superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 238262] fix login page - mozilla.dev.super-review

Resources last updated: 11/26/2015 9:25:43 AM