superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 236717] fix issues with previous patch

David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 170520: Allow SMTP server to be specified when creating new account
https://bugzilla.mozilla.org/show_bug.cgi?id=170520

Attachment 236717: fix issues with previous patch
https://bugzilla.mozilla.org/attachment.cgi?id=236717&action=edit

------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
I think this fixes the bugs you were seeing with the previous patch, Alex - can
you try it out?

I hope I haven't broken the ability for isp rdf files to specify the smtp
server. There are two cases here - one where there are no accounts specified
when the account wizard is run, and one where there is an existing account or
accounts - most of these changes mainly affect the second case.
0
bugzilla
9/4/2006 5:53:11 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
368 Views

Similar Articles

[PageSpeed] 46

Reply:

Similar Artilces:

superreview cancelled: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 236717] fix issues with previous patch
David Bienvenu <bienvenu@nventure.com> has cancelled David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 236717: fix issues with previous patch https://bugzilla.mozilla.org/attachment.cgi?id=236717&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Alexander, this fixes the null smtp server problem, and perhaps the outgoing server name problem. I was not able to reproduce the p...

superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 238262] fix login page
Alexander Ihrig <AlexIhrig@thunderbird-mail.de> has asked for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 238262: fix login page https://bugzilla.mozilla.org/attachment.cgi?id=238262&action=edit ------- Additional Comments from Alexander Ihrig <AlexIhrig@thunderbird-mail.de> David, I've taken your last patch and fixed the remaining login page bug by removing/changing the related XUL- and JS-code. Additionaly we could remove the entities "haveSmtp2****...

superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 238262] fix login page
David Bienvenu <bienvenu@nventure.com> has asked for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 238262: fix login page https://bugzilla.mozilla.org/attachment.cgi?id=238262&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I'm going to see what Neil thinks of this patch, but I need to see if it applies first. ...

superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 238262] fix login page #2
Alexander Ihrig <AlexIhrig@thunderbird-mail.de> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 238262: fix login page https://bugzilla.mozilla.org/attachment.cgi?id=238262&action=edit ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit ...

superreview requested: [Bug 213461] Want a way to specify single-sided or double-sided printing : [Attachment 128748] Patch to fix all issues listed in previous comments
Roland Mainz (not reading bugmail) <Roland.Mainz@informatik.med.uni-giessen.de> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 213461: Want a way to specify single-sided or double-sided printing http://bugzilla.mozilla.org/show_bug.cgi?id=213461 Attachment 128748: Patch to fix all issues listed in previous comments http://bugzilla.mozilla.org/attachment.cgi?id=128748&action=edit ------- Additional Comments from Roland Mainz (not reading bugmail) <Roland.Mainz@informatik.med.uni-giessen.de> ...

superreview requested: [Bug 213461] Want a way to specify single-sided or double-sided printing : [Attachment 128748] Patch to fix all issues listed in previous comments #2
Roland Mainz (not reading bugmail) <Roland.Mainz@informatik.med.uni-giessen.de> has asked rbs@maths.uq.edu.au for superreview: Bug 213461: Want a way to specify single-sided or double-sided printing http://bugzilla.mozilla.org/show_bug.cgi?id=213461 Attachment 128748: Patch to fix all issues listed in previous comments http://bugzilla.mozilla.org/attachment.cgi?id=128748&action=edit ------- Additional Comments from Roland Mainz (not reading bugmail) <Roland.Mainz@informatik.med.uni-giessen.de> Moving sr= request over to someone with a less filled-up queue (rbs@ma...

superreview requested: [Bug 243837] UI for Global Inbox and deferring storage for pop3 servers to other accounts : [Attachment 150299] cumulative patch, including fix creating of inbox in local folde
David Bienvenu <bienvenu@nventure.com> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 243837: UI for Global Inbox and deferring storage for pop3 servers to other accounts http://bugzilla.mozilla.org/show_bug.cgi?id=243837 Attachment 150299: cumulative patch, including fix creating of inbox in local folders if first pop3 account is deferred http://bugzilla.mozilla.org/attachment.cgi?id=150299&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Seth said he's interesting in reviewing this. ...

superreview requested: [Bug 222388] Set initial SMTP server setting to "Always Use Deafult SMTP Server" instead of specific SMTP server : [Attachment 134109] patch v2
David Bienvenu <bienvenu@nventure.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 222388: Set initial SMTP server setting to "Always Use Deafult SMTP Server" instead of specific SMTP server http://bugzilla.mozilla.org/show_bug.cgi?id=222388 Attachment 134109: patch v2 http://bugzilla.mozilla.org/attachment.cgi?id=134109&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Asking Neil for r= ...

superreview requested: [Bug 285921] SMTP server improperly resets to default server when viewing account settings : [Attachment 179985] the fix
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 285921: SMTP server improperly resets to default server when viewing account settings https://bugzilla.mozilla.org/show_bug.cgi?id=285921 Attachment 179985: the fix https://bugzilla.mozilla.org/attachment.cgi?id=179985&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> A bit of a stop gap measure. For some reason the smtp menulist (when you don't change its value) ends up adding an undefined entry in the account manager...

superreview requested: [Bug 301945] Account Wizard won't offer to create new RSS or Movemail accounts : [Attachment 230828] patch
Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 301945: Account Wizard won't offer to create new RSS or Movemail accounts https://bugzilla.mozilla.org/show_bug.cgi?id=301945 Attachment 230828: patch https://bugzilla.mozilla.org/attachment.cgi?id=230828&action=edit ...

superreview requested: [Bug 337305] Can't create new bookmark from the bookmarks manager : [Attachment 221474] patch v1: minimal fix for the bug
Myk Melez <myk@mozilla.org> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 337305: Can't create new bookmark from the bookmarks manager https://bugzilla.mozilla.org/show_bug.cgi?id=337305 Attachment 221474: patch v1: minimal fix for the bug https://bugzilla.mozilla.org/attachment.cgi?id=221474&action=edit ------- Additional Comments from Myk Melez <myk@mozilla.org> The better fix is for the microsummary picker to detect when the URL field has changed and update the list of available microsummaries ac...

superreview requested: [Bug 30057] Use one Local Mail tree for all POP3 accounts : [Attachment 148629] allow servers to defer get new mail to other account
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 30057: Use one Local Mail tree for all POP3 accounts http://bugzilla.mozilla.org/show_bug.cgi?id=30057 Attachment 148629: allow servers to defer get new mail to other account http://bugzilla.mozilla.org/attachment.cgi?id=148629&action=edit ...

superreview requested: [Bug 334407] [FIX]data: loads should default to the null principal if no owner is set : [Attachment 219560] Fix a view-source issue in the previous patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 334407: [FIX]data: loads should default to the null principal if no owner is set https://bugzilla.mozilla.org/show_bug.cgi?id=334407 Attachment 219560: Fix a view-source issue in the previous patch https://bugzilla.mozilla.org/attachment.cgi?id=219560&action=edit ...

Web resources about - superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 236717] fix issues with previous patch - mozilla.dev.super-review

Resources last updated: 12/21/2015 12:58:03 AM