superreview requested: [Bug 126802] Printing while in print preview disabled on Unix : [Attachment 333675] patch to enable printing while in print preview

Leon Sha <leon.sha@sun.com> has asked Robert O'Callahan (:roc) (Mozilla
Corporation) <roc@ocallahan.org> for superreview:
Bug 126802: Printing while in print preview disabled on Unix
https://bugzilla.mozilla.org/show_bug.cgi?id=126802

Attachment 333675: patch to enable printing while in print preview
https://bugzilla.mozilla.org/attachment.cgi?id=333675&action=edit
0
bugzilla
8/18/2008 5:22:18 AM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
706 Views

Similar Articles

[PageSpeed] 18

Reply:

Similar Artilces:

superreview granted: [Bug 126802] Printing while in print preview disabled on Unix : [Attachment 333675] patch to enable printing while in print preview
Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has granted Leon Sha <leon.sha@sun.com>'s request for superreview: Bug 126802: Printing while in print preview disabled on Unix https://bugzilla.mozilla.org/show_bug.cgi?id=126802 Attachment 333675: patch to enable printing while in print preview https://bugzilla.mozilla.org/attachment.cgi?id=333675&action=edit ...

superreview requested: [Bug 267422] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 198372] print-preview-fix.patch
Scott MacGregor <mscott@mozilla.org> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 267422: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=267422 Attachment 198372: print-preview-fix.patch https://bugzilla.mozilla.org/attachment.cgi?id=198372&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> switching to mike for the 2nd review since bz is gone. I've been testing with this patch and can confirm that it makes things better for...

superreview requested: [Bug 267422] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 198372] print-preview-fix.patch #2
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 267422: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=267422 Attachment 198372: print-preview-fix.patch https://bugzilla.mozilla.org/attachment.cgi?id=198372&action=edit ------- Additional Comments from Vladimir Vukicevic (:vlad) <vladimir@pobox.com> This is not an ideal fix. However, it does work. This also fixes bug 302495. Whenever a print setting is changed, to ...

superreview requested: [Bug 267422] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 198379] print-preview-fix.patch (version 2)
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 267422: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=267422 Attachment 198379: print-preview-fix.patch (version 2) https://bugzilla.mozilla.org/attachment.cgi?id=198379&action=edit ------- Additional Comments from Vladimir Vukicevic (:vlad) <vladimir@pobox.com> Much better patch. Just hide/show the print preview toolbar; it doesn't even look horrible doing it thi...

superreview requested: [Bug 226973] Print Preview Error (Previewing During Page Rendering/No Printer Installed) Shows Print Preview Toolbar : [Attachment 155015] fix
Jan Varga <varga@mozilla-europe.org> has asked Ben Goodger <bugs@bengoodger.com> for superreview: Bug 226973: Print Preview Error (Previewing During Page Rendering/No Printer Installed) Shows Print Preview Toolbar http://bugzilla.mozilla.org/show_bug.cgi?id=226973 Attachment 155015: fix http://bugzilla.mozilla.org/attachment.cgi?id=155015&action=edit ...

superreview granted: [Bug 226600] [ps] Print Preview overwrites printed file : [Attachment 149593] Add a print preview flag to the device context spec
Robert O'Callahan <roc@ocallahan.org> has granted Kenneth Herron <kherron+mozilla@fmailbox.com>'s request for superreview: Bug 226600: [ps] Print Preview overwrites printed file http://bugzilla.mozilla.org/show_bug.cgi?id=226600 Attachment 149593: Add a print preview flag to the device context spec http://bugzilla.mozilla.org/attachment.cgi?id=149593&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> Okay, this looks good ...

superreview granted: [Bug 340564] Print/Print Preview does not print text in <input text> or <textarea> : [Attachment 243735] Patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340564: Print/Print Preview does not print text in <input text> or <textarea> https://bugzilla.mozilla.org/show_bug.cgi?id=340564 Attachment 243735: Patch https://bugzilla.mozilla.org/attachment.cgi?id=243735&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> thanks! the new textframe kills all this horrible code. ...

superreview requested: [Bug 263738] crash on print/print preview [@ nsTableRowFrame::InsertCellFrame] : [Attachment 161761] revised patch
Bernd <bernd_mozilla@gmx.de> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 263738: crash on print/print preview [@ nsTableRowFrame::InsertCellFrame] https://bugzilla.mozilla.org/show_bug.cgi?id=263738 Attachment 161761: revised patch https://bugzilla.mozilla.org/attachment.cgi?id=161761&action=edit ...

superreview requested: [Bug 231823] When attempting to print or print preview the map is separated into hundreds of pages : [Attachment 145770] patch
David Baron <dbaron@dbaron.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 231823: When attempting to print or print preview the map is separated into hundreds of pages http://bugzilla.mozilla.org/show_bug.cgi?id=231823 Attachment 145770: patch http://bugzilla.mozilla.org/attachment.cgi?id=145770&action=edit ...

superreview cancelled: [Bug 267422] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 198372] print-preview-fix.patch
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has cancelled Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 267422: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=267422 Attachment 198372: print-preview-fix.patch https://bugzilla.mozilla.org/attachment.cgi?id=198372&action=edit ...

superreview requested: [Bug 292124] Print (and print preview) drops some lines when trying to render a TABLE with a CAPTION : [Attachment 207172] patch
Bernd <bernd_mozilla@gmx.de> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 292124: Print (and print preview) drops some lines when trying to render a TABLE with a CAPTION https://bugzilla.mozilla.org/show_bug.cgi?id=292124 Attachment 207172: patch https://bugzilla.mozilla.org/attachment.cgi?id=207172&action=edit ...

superreview granted: [Bug 267422] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 198379] print-preview-fix.patch (version 2)
Mike Connor <mconnor@mozilla.com> has granted Vladimir Vukicevic (:vlad) <vladimir@pobox.com>'s request for superreview: Bug 267422: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=267422 Attachment 198379: print-preview-fix.patch (version 2) https://bugzilla.mozilla.org/attachment.cgi?id=198379&action=edit ...

superreview requested: [Bug 347367] crash when print preview is opened on a certain file styled with meda=print [@ BasicTableLayoutStrategy::CalcPctAdjTableWidth] : [Attachment 238671] patch
Bernd <bernd_mozilla@gmx.de> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 347367: crash when print preview is opened on a certain file styled with meda=print [@ BasicTableLayoutStrategy::CalcPctAdjTableWidth] https://bugzilla.mozilla.org/show_bug.cgi?id=347367 Attachment 238671: patch https://bugzilla.mozilla.org/attachment.cgi?id=238671&action=edit ------- Additional Comments from Bernd <bernd_mozilla@gmx.de> Robert, I think this is the right thing to do, however once checked in the testcase will not crash but hang due to...

superreview requested: [Bug 307367] [BC] print preview doesn't match print for thin borders on windows : [Attachment 207175] patch
Bernd <bernd_mozilla@gmx.de> has asked Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> for superreview: Bug 307367: [BC] print preview doesn't match print for thin borders on windows https://bugzilla.mozilla.org/show_bug.cgi?id=307367 Attachment 207175: patch https://bugzilla.mozilla.org/attachment.cgi?id=207175&action=edit ------- Additional Comments from Bernd <bernd_mozilla@gmx.de> This removes any reference inside the table code to PixelstoTwips and ensures that always the scaled version is used. I could not resist to kick some PresCon...

Web resources about - superreview requested: [Bug 126802] Printing while in print preview disabled on Unix : [Attachment 333675] patch to enable printing while in print preview - mozilla.dev.super-review

Resources last updated: 1/6/2016 10:58:12 PM