superreview requested: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313624] Patch v3

H=C3=A5kan Waara <hwaara@gmail.com> has asked Robert O'Callahan (:roc) (red=
uced
activity March 18 to April 9) <roc@ocallahan.org> for superreview:
Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X]
https://bugzilla.mozilla.org/show_bug.cgi?id=3D125995

Attachment 313624: Patch v3
https://bugzilla.mozilla.org/attachment.cgi?id=3D313624&action=3Dedit

------- Additional Comments from H=C3=A5kan Waara <hwaara@gmail.com>
Here's a much cleaned up version. I've sanitized the CF stuff, generalized
methods, and other things, so this patch is a good bit lighter now. =0D
=0D
Depending on how strongly roc feels about moving the SCProxySettings code i=
nto
nsOSXSystemProxySettings class, this may be ready for review (again).=0D
=0D
However, it needs testing. It compiles, but I have no proxy, and no way to
test, so please do that.=
0
bugzilla
4/4/2008 4:10:52 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
389 Views

Similar Articles

[PageSpeed] 43

Reply:

Similar Artilces:

superreview canceled: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313624] Patch v3
H=C3=A5kan Waara <hwaara@gmail.com> has canceled H=C3=A5kan Waara <hwaara@g= mail.com>'s request for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=3D125995 Attachment 313624: Patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=3D313624&action=3Dedit= ...

superreview requested: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313868] Mac OSX implementation of system proxy settings
H=C3=A5kan Waara <hwaara@gmail.com> has asked Robert O'Callahan (:roc) (red= uced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=3D125995 Attachment 313868: Mac OSX implementation of system proxy settings - #4 https://bugzilla.mozilla.org/attachment.cgi?id=3D313868&action=3Dedit ------- Additional Comments from H=C3=A5kan Waara <hwaara@gmail.com> Good work= ...

superreview requested: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313576] Mac OSX implementation of system proxy settings
Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> has asked Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=125995 Attachment 313576: Mac OSX implementation of system proxy settings - #2 https://bugzilla.mozilla.org/attachment.cgi?id=313576&action=edit ------- Additional Comments from Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@o...

superreview requested: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 314082] Mac OSX implementation of system proxy settings
James Bunton <jamesbunton@fastmail.fm> has asked for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=125995 Attachment 314082: Mac OSX implementation of system proxy settings - #6 https://bugzilla.mozilla.org/attachment.cgi?id=314082&action=edit ------- Additional Comments from James Bunton <jamesbunton@fastmail.fm> Sorry, I obviously didn't "get" the flags :) Changes: * Flattened out Init() * mContext needs to be around for the life of mSystemDynamicStore * break in...

superreview requested: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 314082] Mac OSX implementation of system proxy settings
James Bunton <jamesbunton@fastmail.fm> has asked Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=125995 Attachment 314082: Mac OSX implementation of system proxy settings - #6 https://bugzilla.mozilla.org/attachment.cgi?id=314082&action=edit ...

superreview canceled: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313576] Mac OSX implementation of system proxy settings
H=C3=A5kan Waara <hwaara@gmail.com> has canceled Robert O'Callahan (:roc) (= reduced activity March 18 to April 9) <roc@ocallahan.org>'s request for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=3D125995 Attachment 313576: Mac OSX implementation of system proxy settings - #2 https://bugzilla.mozilla.org/attachment.cgi?id=3D313576&action=3Dedit ------- Additional Comments from H=C3=A5kan Waara <hwaara@gmail.com> Here's a much cleaned up version. I've sanitized the C...

superreview canceled: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313868] Mac OSX implementation of system proxy settings
James Bunton <jamesbunton@fastmail.fm> has canceled H=C3=A5kan Waara <hwaara@gmail.com>'s request for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=3D125995 Attachment 313868: Mac OSX implementation of system proxy settings - #4 https://bugzilla.mozilla.org/attachment.cgi?id=3D313868&action=3Dedit ------- Additional Comments from James Bunton <jamesbunton@fastmail.fm> Thanks Roc. Consistency is indeed important :)=0D =0D Changes:=0D * Made suggested changes to the build sys...

superreview granted: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 314082] Mac OSX implementation of system proxy settings
Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> has granted James Bunton <jamesbunton@fastmail.fm>'s request for superreview: Bug 125995: Proxy: Take settings from Network Preferences [Mac OS X] https://bugzilla.mozilla.org/show_bug.cgi?id=125995 Attachment 314082: Mac OSX implementation of system proxy settings - #6 https://bugzilla.mozilla.org/attachment.cgi?id=314082&action=edit ------- Additional Comments from Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> excellent! ...

superreview requested: [Bug 432533] two mac key tests fail on Mac OS X 10.5 : [Attachment 320286] patch v3
Matthew Gregan <kinetik@flim.org> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 432533: two mac key tests fail on Mac OS X 10.5 https://bugzilla.mozilla.org/show_bug.cgi?id=432533 Attachment 320286: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=320286&action=edit ------- Additional Comments from Matthew Gregan <kinetik@flim.org> Turn gOverrideKeyboardLayout into a pair which holds the layout ID and a bool indicating whether the override is active. The override is active while SynthesizeNativeKeyEvents is on the sta...

superreview requested: [Bug 304147] progressmeter in undetermined mode does not work in Mac OS X : [Attachment 312480] Fix v3.2: address review comments
Markus Stange <mstange@themasta.com> has asked Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 304147: progressmeter in undetermined mode does not work in Mac OS X https://bugzilla.mozilla.org/show_bug.cgi?id=304147 Attachment 312480: Fix v3.2: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=312480&action=edit ...

superreview requested: [Bug 274374] Mac OS X Shell Service ("Set default browser" support, etc.) : [Attachment 186667] patch
Asaf Romano (use mozilla.mano@ for email) <bugs.mano@sent.com> has asked Mike Connor <mconnor@steelgryphon.com> for superreview: Bug 274374: Mac OS X Shell Service ("Set default browser" support, etc.) https://bugzilla.mozilla.org/show_bug.cgi?id=274374 Attachment 186667: patch https://bugzilla.mozilla.org/attachment.cgi?id=186667&action=edit ------- Additional Comments from Asaf Romano (use mozilla.mano@ for email) <bugs.mano@sent.com> Rewrite |IsDefaultBrowser()| to use bundle identifiers. Javier, could you re-review that part? ...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183870] Phase 2, v3: changes inspired by wtc's review of ph3
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183870: Phase 2, v3: changes inspired by wtc's review of ph3 https://bugzilla.mozilla.org/attachment.cgi?id=183870&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Changes since ph2v2 and ph2v3: - SDK_C_INCLUDE needs to use GCC_VERSION_FULL in lib for gcc4 - use ${target_os} inste...

superreview requested: [Bug 66057] Proxy: $http_proxy should influence proxy settings : [Attachment 242611] Merged in Josh's requested updates from bug 125995
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked Christian Biesinger (:bi) <cbiesinger@gmx.at> for superreview: Bug 66057: Proxy: $http_proxy should influence proxy settings https://bugzilla.mozilla.org/show_bug.cgi?id=66057 Attachment 242611: Merged in Josh's requested updates from bug 125995 https://bugzilla.mozilla.org/attachment.cgi?id=242611&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> still needs biesi love ...

superreview requested: [Bug 437035] Remove Mac OS X AB specific override for creating a Mac OS X AB via UI. : [Attachment 323538] The fix
Mark Banner <bugzilla@standard8.plus.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 437035: Remove Mac OS X AB specific override for creating a Mac OS X AB via UI. https://bugzilla.mozilla.org/show_bug.cgi?id=437035 Attachment 323538: The fix https://bugzilla.mozilla.org/attachment.cgi?id=323538&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> Bug 379811 added a Mac OS X AB specific ifdef so that we could create Mac OS X Address books via the UI. In bug 436848, Neil added a parameter to nsIAbM...

Web resources about - superreview requested: [Bug 125995] Proxy: Take settings from Network Preferences [Mac OS X] : [Attachment 313624] Patch v3 - mozilla.dev.super-review

Resources last updated: 12/23/2015 4:47:47 PM