superreview granted: [Bug 58048] [Pref Stylesheet]`Always use my colors' shouldn't remove colors from form controls [CASCADE]

Boris Zbarsky <bzbarsky@mit.edu> has granted David Baron [:dbaron]
<dbaron@mozilla.com>'s request for superreview:
Bug 58048: [Pref Stylesheet]`Always use my colors' shouldn't remove colors =
from
form controls [CASCADE]
https://bugzilla.mozilla.org/show_bug.cgi?id=3D58048

Attachment 264970: patch
https://bugzilla.mozilla.org/attachment.cgi?id=3D264970&action=3Dedit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
>+++ b/layout/style/nsCSSDataBlock.cpp=0D
>+			  else if (iProp =3D=3D eCSSProperty_color ||=0D
....=0D
=0D
What about moz-border-colors?  I know the old code didn't handle them, but
maybe it should.=0D
=0D
I almost wonder whether this is worth a field in nsCSSPropList so we can ju=
st
do an array index operation here or something instead of having the conditi=
onal
cascade....=0D
=0D
r+sr=3Dbzbarsky either way; file followup bugs as needed.=
0
bugzilla
5/16/2007 5:42:48 PM
mozilla.dev.super-review 29307 articles. 2 followers. Post Follow

0 Replies
488 Views

Similar Articles

[PageSpeed] 24

Reply:

Similar Artilces:

superreview requested: [Bug 58048] [Pref Stylesheet]`Always use my colors' shouldn't remove colors from form controls [CASCADE]
David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 58048: [Pref Stylesheet]`Always use my colors' shouldn't remove colors from form controls [CASCADE] https://bugzilla.mozilla.org/show_bug.cgi?id=58048 Attachment 264970: patch https://bugzilla.mozilla.org/attachment.cgi?id=264970&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> This patch fixes this bug and bug 255829 and improves on the fix for bug 255411. It reimplements the preference at the rule mapping...

superreview granted: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a
neil@parkwaycc.co.uk <neil@httl.net> has granted Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313971: Label disabling patch v1.1a https://bugzilla.mozilla.org/attachment.cgi?id=313971&action=edit ...

superreview granted: [Bug 419167] right/left borders don't adopt user-defined color (colour) scheme (untick 'Allow pages to choose their own colors') : [Attachment 305371] patch without the array
David Baron [:dbaron] <dbaron@mozilla.com> has granted superreview: Bug 419167: right/left borders don't adopt user-defined color (colour) sche= me (untick 'Allow pages to choose their own colors') https://bugzilla.mozilla.org/show_bug.cgi?id=3D419167 Attachment 305371: patch without the array https://bugzilla.mozilla.org/attachment.cgi?id=3D305371&action=3Dedit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> r+sr=3Ddbaron.=0D =0D Why don't we just get this one in and I'll worry about converting this code over later...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313728] Onchange patch v1.1
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313728: Onchange patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=313728&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Changes since v1.0a - addressed review comments: * use onchange on preference. * use preference value instead of checkbox setting. * set disabled prop...

superreview canceled: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313728] Onchange patch v1.1
Ian Neal <iann_bugzilla@blueyonder.co.uk> has canceled Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313728: Onchange patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=313728&action=edit ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313971: Label disabling patch v1.1a https://bugzilla.mozilla.org/attachment.cgi?id=313971&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Changes since v1.1: * Labels now have the same disabled status as their associated colorpicker. ...

superreview granted: [Bug 193332] about:config doesn't remove deleted prefs with no default : [Attachment 219490] don't remove entries while enumerating
Darin Fisher (Google) <darin@meer.net> has granted Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 193332: about:config doesn't remove deleted prefs with no default https://bugzilla.mozilla.org/show_bug.cgi?id=193332 Attachment 219490: don't remove entries while enumerating https://bugzilla.mozilla.org/attachment.cgi?id=219490&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> r+sr=darin with BOGUS_DEFAULT_BOOL_PREF_VALUE ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312933: Disable and lock checking patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> This patch: * Disables the color pickers when system colors box is checked as long as picker pref is not locked. * Re-enables the col...

superreview canceled: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0
Ian Neal <iann_bugzilla@blueyonder.co.uk> has canceled Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312933: Disable and lock checking patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312934: Disable and lock checking patch v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=312934&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Correct patch that doesn't try adding a second pref-appearance.js entry to jar.mn ...

superreview denied: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a
neil@parkwaycc.co.uk <neil@httl.net> has denied Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=3D79603 Attachment 312934: Disable and lock checking patch v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=3D312934&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Unfortunately disabling colourpickers doesn't work correctly - the binding simply makes a bold claim that it's...

superreview granted: [Bug 289625] color pickers in mail compose don't mirror focused color : [Attachment 183832] Use getvaluetype
T Rowley (IBM) <tor@acm.org> has granted Michael Kaply (IBM) (mkaply) <mozilla@kaply.com>'s request for superreview: Bug 289625: color pickers in mail compose don't mirror focused color https://bugzilla.mozilla.org/show_bug.cgi?id=289625 Attachment 183832: Use getvaluetype https://bugzilla.mozilla.org/attachment.cgi?id=183832&action=edit ...

superreview granted: [Bug 211657] [FIX]Should use '::' for anonymous boxes and other -moz pseudo-elements : [Attachment 127207] Patch to remove support for the single-':' form of -moz pseudos
David Baron <dbaron@dbaron.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 211657: [FIX]Should use '::' for anonymous boxes and other -moz pseudo-elements http://bugzilla.mozilla.org/show_bug.cgi?id=211657 Attachment 127207: Patch to remove support for the single-':' form of -moz pseudos http://bugzilla.mozilla.org/attachment.cgi?id=127207&action=edit ...

superreview granted: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem)
David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 281783: updated patch v6 https://bugzilla.mozilla.org/attachment.cgi?id=281783&action=edit ------- Additional Comments from David Baron [:dbaron] (less responsive until Septem...

Web resources about - superreview granted: [Bug 58048] [Pref Stylesheet]`Always use my colors' shouldn't remove colors from form controls [CASCADE] - mozilla.dev.super-review

LESS (stylesheet language) - Wikipedia, the free encyclopedia
1.3.3 (December 30, 2012 ; 2 months ago ( 2012-12-30 ) ) LESS is open-source . Its first version was written in Ruby , however in the later versions, ...

Using Chrome's "Inspect Element" for Reddit Stylesheet editing - YouTube
This is an updated tutorial showing how to use the built-in "Inspect Element" feature in Google Chrome to aid in the creating and editing of ...

Introducing Closure Stylesheets
... principle that is exhibited in good software engineering. For example, if there is a color that should be used for multiple classes in a stylesheet, ...

Different Stylesheets for Differently Sized Browser Windows - CSS-Tricks
Otherwise known as "resolution dependent layouts". Single website, different CSS files for rearranging a website to take advantage of the size ...

CSS Stylesheet Browser
One of my favorite tools, John Carpenter's exceptionally useful and cool finally has a permanent home of its own. Also, today my Google toolbar ...

compass/frameworks/compass/stylesheets/_compass.scss at stable · chriseppstein/compass · GitHub
compass - Compass is a Stylesheet Authoring Environment that makes your website design simpler to implement and easier to maintain.

Conditional Stylesheets vs CSS Hacks? Answer: Neither!
…or… ’s conditional classes From what I’ve seen a good number of developers these days are split between conditional …

Google: One URL With Special Stylesheet Is Easy Mobile SEO
I love SEO topics where there is no solid firm answer and one of those areas is mobile SEO. Google has no clear guidelines on how you should ...

Bear CSS creates the perfect stylesheet template based on your HTML
... of time, many devs start working off of their own templates as a starting point. In the end, there’s often no need to write out your stylesheet ...

Stylesheet Download Tests ➟
Scott Jehl:The point of this page is to test whether today's browsers will download stylesheets that are referenced with media queries that would ...

Resources last updated: 12/25/2015 10:00:53 PM