superreview granted: [Bug 430624] Crash [@ nsDocShellEditorData::DetachFromWindow] with spellcheck attribute : [Attachment 318752] Patch v2 - Bug 386782's regression fix patch

Peter Van der Beken <peterv@propagandism.org> has granted  superreview:
Bug 430624: Crash [@ nsDocShellEditorData::DetachFromWindow] with spellcheck
attribute
https://bugzilla.mozilla.org/show_bug.cgi?id=430624

Attachment 318752: Patch v2 - Bug 386782's regression fix patch
https://bugzilla.mozilla.org/attachment.cgi?id=318752&action=edit

------- Additional Comments from Peter Van der Beken <peterv@propagandism.org>
>Index: docshell/shistory/public/nsISHEntry.idl
>===================================================================

> %{ C++
>-// {BFD1A791-AD9F-11d3-BDC7-0050040A9B44}
>+// {720570e7-838a-4d65-8a6e-b51709966f1d}
> #define NS_SHENTRY_CID \
>-{0xbfd1a791, 0xad9f, 0x11d3, {0xbd, 0xc7, 0x0, 0x50, 0x4, 0xa, 0x9b, 0x44}}
>+{ 0x720570e7, 0x838a, 0x4d65, { 0x8a, 0x6e, 0xb5, 0x17, 0x09, 0x96, 0x6f,
0x1d } }

Don't change the CID.

>Index: docshell/test/navigation/test_bug430624.html
>===================================================================

>+function onLoad() {
>+  window.frames[0].frameElement.onload = onReload;
>+  window.frames[0].location = window.frames[0].location;
>+}
>+
>+function onReload() {
>+  var bodyElement = window.frames[0].frameElement.contentDocument.body;
>+  sendChar('S', bodyElement);
>+  sendChar('t', bodyElement);
>+  sendChar('i', bodyElement);
>+  sendChar('l', bodyElement);
>+  sendChar('l', bodyElement);
>+  sendChar(' ', bodyElement);
>+
>+  is(bodyElement.innerHTML, "Still contentEditable", "Check we're
contentEditable after reload");
>+}
>+
>+

I think you need to call SimpleTest.waitForExplicitFinish() here and
SimpleTest.finish() at the end of onReload?

Previous version also got sr=jst in bug 386782.
0
bugzilla
5/1/2008 2:22:39 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
470 Views

Similar Articles

[PageSpeed] 3

Reply:

Similar Artilces:

Patches, patches, patches...
To forestall potential incidents of Warnock's Dillemma... I'm about to apply a whole heap 'o patches to Parrot. (With appropriate [APPLIED] responses, I hope) If, at the end of the day, I have *not* applied or commented on a patch you've sent, it means I've Officially Missed It, so give another try. Sorry 'bout this. Too much mail in the mailbox, and going back in time is tricky, as it can miss subsequent discussions on patches 'n stuff. -- Dan --------------------------------------"it's like th...

[PATCH] Re: Fix previous patch. Actually it's written PAREN, not PARENT.
------_=_NextPart_001_01C98C47.A69E38F9 Content-Type: multipart/alternative; boundary="----_=_NextPart_002_01C98C47.A69E38F9" ------_=_NextPart_002_01C98C47.A69E38F9 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable There is a typo in English.pm test Robin Barker <<0001-typo-in-English.pm-test.patch>>=20 ------------------------------------------------------------------- This e-mail and any attachments may contain confidential and/or privileged material; it is for the intended addressee(s) onl...

[PATCH] 'threads' patch to fix threaded build on Win32
---901761347-1842621296-1147109013=:22104 Content-Type: TEXT/plain; CHARSET=US-ASCII Rafael Garcia-Suarez wrote: > > Subj: Change 28104: [PATCH] threads - stack size support > > Change 28104 by rgs@stencil on 2006/05/05 11:32:36 > This has broken the threaded build on Win32: > threads.xs(274) : warning C4013: 'Perl_Gmmap_page_size_ptr' undefined; > assuming extern returning int > threads.xs(274) : error C2100: illegal indirection > NMAKE : fatal error U1077: 'cl' : return code '0x2' I think the attached patch will fix this. ...

[PATCH] It's the Barbie bus patch
--tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I do most of my C hacking here on the couch in my living room. Next to the coffee table where my daughter Quinn plays is a purple Barbie bus that she uses as a chair. It was $5 at a garage sale, and it still has the tag on it. It's as much a piece of furniture as anything else. So I figured it's worth naming a patch of stuff after. "Nothing freaky" means one or more of: * Changing 0 pointers to NULL * Changing Null(sv|gv|etc) to NULL * Consting * Fixing indentation ...

Maintenance patch. What's the patch that fits to me?
I have Sql Anywhere 5.5.03 build 1666. What patch i have to download from the server, the patch version 5.5.03 or 5.5.04? Is the build that changes or the version? Thanks. Paolo Caroli. paolo.caroli@it.eyi.com 5.5.04 would be the next step for you. -- Jim Egan [TeamPS] Houston, TX Paolo Caroli <finaudit@tin.it> wrote in article <LGa6d7k39GA.217@forums.powersoft.com>... > I have Sql Anywhere 5.5.03 build 1666. > What patch i have to download from the server, the patch version 5.5.03 or > 5.5.04? > > Is the build that changes or the ver...

[PATCH] undouble Jarkko's patch
--7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline While Jarrko's patch was excellent, it wasn't so good that it should have been put in perlhack twice, as it was. xoxo, Andy -- Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="undouble.diff" Index: pod/perlhack.pod =================================================================== --- pod/perlhack.pod (revision 962) +++ pod/per...

[PATCH] Test for attributes.pm 'reserved' warning fix
---901720387-143264303-1156530967=:2165 Content-Type: TEXT/plain; CHARSET=US-ASCII Rafael Garcia-Suarez wrote: > That probably comes from the fact that attributes::_warn_reserved > (defined in xsutils.c) checks that the warning is enabled in the wrong > package. Jerry D. Hedden replied: > The attached patch fixes this problem. Rafael Garcia-Suarez replied: > Thanks, applied as change 28756. (A regression test would be nice) Attached. ---901720387-143264303-1156530967=:2165 Content-Type: TEXT/plain,English; name="attrs.patch"; CHARSET=US-ASCII C...

Patches, patches, patches... #2
OK, this is advance warning that I'm about to be reposting a bunch of patches of mine which appear to have succumbed to Warnock's Dilemma. The first three should be uncontroversial: there's a documentation fix-up for core.ops, and new tests for strings and stacks. The last one is rather larger, and consists of a greatly expanded set of tests for PerlString's, plus a bunch of bug-fixes. I'd be grateful if Jeff or Dan could take a look at this, as I have the feeling that a lot of the scalar PMCs are going to need similar fixes. Simon ...

[PATCH] Updated 'mod' patch
--=-KocO8wR8x/lsqQq/R8W0 Content-Type: text/plain Content-Transfer-Encoding: 7bit All -- I've updated my mod patch to work with the latest CVS... Regards, -- _____________________________________________________________________ / perl -e 'srand(-2091643526); print chr rand 90 for (0..4)' \ Gregor N. Purdy gregor@focusresearch.com Focus Research, Inc. http://www.focusresearch.com/ 8080 Beckett Center Drive #203 513-860-3570 vox West Chester, OH 45069 51...

Re: [PATCH lib/ExtUtils/MM_VMS.pm] Re: [PATCH] 'all ::' for one and one for 'all ::'
(Apolgies for the late reply) Jarkko wrote: !> Looks good to me. So apparently the VMS make utilities really aren't !> different from the rest of the world; it's just that the rest of the !> world already had a workaround in place. ! !Thanks, applied. (As was the original 'all ::' patch, hope that's okay.) Perhaps that addition of the "all" target to vms/descrip_mms.template ought to be reconsidered. Isn't it serving as a useful check that the four line mantra: perl Makefile.PL make make test make install s...

Delayed patch ends Microsoft's patch-free month early
A glitch in Microsoft's Windows Update automated patching service caused a security fix that was released last month to be delivered to computer users on Tuesday, the same day Microsoft proclaimed December would be a patch-free month. The software patch fixes a serious vulnerability in a set of Web site management tools called FrontPage Server Extensions, which are part of Microsoft's Windows 2000, Windows XP and Office XP software, according to Microsoft Security Bulletin MS03-051 released Nov. 11. Exploiting the flaw could allow an attacker to gain control over a user's PC...

[PATCH] Fix 'abs' and 'neg' overloading for 64-bit ints
------=_Part_6106_12709475.1191939143425 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline This is my first patch for tackling the 64-bit int overloading issues. It corrects the behavior of 'abs' and 'neg' (unary minus): perl -lwe '{ package t0; sub mynum { -36028797018963971 } use overload "0+" => \&mynum, fallback => 1; } printf "%d\n", abs(t0::mynum); printf "%d\n", abs(bless({}, "t0"))' perl -lwe '{ package t0; sub mynum { -36028797018963971 }...

[PATCH] pp_pack.c redux, to work w/Jarkko's recent patches
Here's a patch, at rgs' request, for pp_pack.c. Lots of consting, pulled in the struct information to pp_pack.c, out of perl.h. Let's get this applied before we worry about localizing the prototypes that are in proto.h? xoxo, Andy -- Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 25, 2005 at 04:28:27PM -0500, Andy Lester (andy@petdance.com) wrote: > Here's a patch, at rgs' request, for pp_pack.c. Lots of consting, &...

[PATCH] MAD: rename mad key for sub or var attributes from 'a' to 'h'
--ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline MAD: rename mad key for sub or var attributes from 'a' to 'h' Because the 'a' key is also used by the "non-method arrow operator" -- Gerard Goossen TTY Internet Solutions --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename=mad_rename_attributes_to_h commit dbbcfc5fc7f24e07a1acc65a426b1f6bcd7b99c8 Author: gerard <gerard@tty.nl> Date: Tue Mar 11 18:30:29 2008 +0100 MAD: rename mad key for s...

[PATCH] Fix 'abs' and 'neg' overloading for 64-bit ints (revised)
------=_Part_7334_7031372.1191954936102 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline This is my first patch for tackling the 64-bit int overloading issues. It corrects the behavior of 'abs' and 'neg' (unary minus): perl -lwe '{ package t0; sub mynum { -36028797018963971 } use overload "0+" => \&mynum, fallback => 1; } printf "%d\n", abs(t0::mynum); printf "%d\n", abs(bless({}, "t0"))' perl -lwe '{ package t0; sub mynum { -36028797018963971 } ...

Web resources about - superreview granted: [Bug 430624] Crash [@ nsDocShellEditorData::DetachFromWindow] with spellcheck attribute : [Attachment 318752] Patch v2 - Bug 386782's regression fix patch - mozilla.dev.super-review

Resources last updated: 11/22/2015 10:05:28 PM