superreview granted: [Bug 430413] Port Mozilla to GDK : [Attachment 320147] The patch was modified with Bugzilla's style.

Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has granted Jiny Sung
<jh0421.sung@samsung.com>'s request for superreview:
Bug 430413: Port Mozilla to GDK
https://bugzilla.mozilla.org/show_bug.cgi?id=430413

Attachment 320147: The patch was modified with Bugzilla's style.
https://bugzilla.mozilla.org/attachment.cgi?id=320147&action=edit

------- Additional Comments from Vladimir Vukicevic (:vlad)
<vladimir@pobox.com>
This looks fine, thanks!
0
bugzilla
5/9/2008 8:48:49 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
260 Views

Similar Articles

[PageSpeed] 33

Reply:

Similar Artilces:

superreview granted: [Bug 287943] Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp : [Attachment 180579] patch v4: address biesi's review nits
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 287943: Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp https://bugzilla.mozilla.org/show_bug.cgi?id=287943 Attachment 180579: patch v4: address biesi's review nits https://bugzilla.mozilla.org/attachment.cgi?id=180579&action=edit ...

superreview granted: [Bug 245751] Can't drag scrollbars in Print Preview anymore (after bug 245024's patch landed) : [Attachment 150428] Proposed patch
Johnny Stenback <jst@mozilla.jstenback.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 245751: Can't drag scrollbars in Print Preview anymore (after bug 245024's patch landed) http://bugzilla.mozilla.org/show_bug.cgi?id=245751 Attachment 150428: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=150428&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> Maybe, maybe not, but none of this printing code is "safe" to start with, so I don...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 309922] Patch for classic and modern v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 309922: Patch for classic and modern v3 https://bugzilla.mozilla.org/attachment.cgi?id=309922&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> OK, r+sr=me with the noline image in Modern and the tweaked outline styles in both themes. ...

superreview granted: [Bug 290678] Port thunderbird's revised vcard attachment display to suite. : [Attachment 310204] Patch for classic and modern v4
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has granted superreview: Bug 290678: Port thunderbird's revised vcard attachment display to suite. https://bugzilla.mozilla.org/show_bug.cgi?id=290678 Attachment 310204: Patch for classic and modern v4 https://bugzilla.mozilla.org/attachment.cgi?id=310204&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> Includes the changes from comment #12, taking over r/sr. ...

superreview requested: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) : [Attachment 292260] patch
Gavin Sharp <gavin.sharp@gmail.com> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) https://bugzilla.mozilla.org/show_bug.cgi?id=407538 Attachment 292260: patch https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> I'm not sure about the XXX comment in the test - seems like we should probably fix that, too, but I&...

superreview granted: [Bug 275960] document.lastModified cannot handle non-ascii characters when the page's HTTP header doesn't have Last-Modified : [Attachment 190024] Patch rv3.0
Boris Zbarsky <bzbarsky@mit.edu> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 275960: document.lastModified cannot handle non-ascii characters when the page's HTTP header doesn't have Last-Modified https://bugzilla.mozilla.org/show_bug.cgi?id=275960 Attachment 190024: Patch rv3.0 https://bugzilla.mozilla.org/attachment.cgi?id=190024&action=edit ...

superreview granted: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to its default value by setting .spec) : [Attachment 292260] patch
Christian :Biesinger <cbiesinger@gmx.at> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to its default value by setting .spec) https://bugzilla.mozilla.org/show_bug.cgi?id=407538 Attachment 292260: patch https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmx.at> would be good to also test that .spec doesn't include the :80 either + //XXX URL ...

superreview granted: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 294611] patch, v.1.6, updated based on pav's comments on 1. 5 patch
Stuart Parmenter <pavlov@pavlov.net> has granted John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 294611: patch, v.1.6, updated based on pav's comments on 1.5 patch https://bugzilla.mozilla.org/attachment.cgi?id=294611&action=edit ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173127] patch v1
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173127: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173127&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but it sounds like some cleanup of incremental vs final chunk is in order.... ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview granted: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> D'oh! ;-) ...

superreview granted: [Bug 353906] Modernize mail's registry code to implement toolkit's nsIShellService : [Attachment 240565] a patch
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 353906: Modernize mail's registry code to implement toolkit's nsIShellService https://bugzilla.mozilla.org/show_bug.cgi?id=353906 Attachment 240565: a patch https://bugzilla.mozilla.org/attachment.cgi?id=240565&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> + DWORD len = sizeof buf; hmm, I'd not seen that usage before... Wow, that's a lot of work! ...

superreview granted: [Bug 430624] Crash [@ nsDocShellEditorData::DetachFromWindow] with spellcheck attribute : [Attachment 318752] Patch v2
Peter Van der Beken <peterv@propagandism.org> has granted superreview: Bug 430624: Crash [@ nsDocShellEditorData::DetachFromWindow] with spellcheck attribute https://bugzilla.mozilla.org/show_bug.cgi?id=430624 Attachment 318752: Patch v2 - Bug 386782's regression fix patch https://bugzilla.mozilla.org/attachment.cgi?id=318752&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> >Index: docshell/shistory/public/nsISHEntry.idl >=================================================================== > %{ C++ >-// {...

superreview granted: [Bug 292355] Plugins send document's base URI as referrer, instead of document's URI : [Attachment 182225] patch
Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 292355: Plugins send document's base URI as referrer, instead of document's URI https://bugzilla.mozilla.org/show_bug.cgi?id=292355 Attachment 182225: patch https://bugzilla.mozilla.org/attachment.cgi?id=182225&action=edit ...

superreview granted: [Bug 285404] faster access to XPConnectWrappedNative's native pointer : [Attachment 176853] -w patch for reviewing
Darin Fisher <darin@meer.net> has granted Brian Ryner (IBM) <bryner@brianryner.com>'s request for superreview: Bug 285404: faster access to XPConnectWrappedNative's native pointer https://bugzilla.mozilla.org/show_bug.cgi?id=285404 Attachment 176853: -w patch for reviewing https://bugzilla.mozilla.org/attachment.cgi?id=176853&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> sr=darin maybe comment in the IDL file that Native() never returns null. ...

Web resources about - superreview granted: [Bug 430413] Port Mozilla to GDK : [Attachment 320147] The patch was modified with Bugzilla's style. - mozilla.dev.super-review

Resources last updated: 1/4/2016 12:07:38 AM