superreview granted: [Bug 430413] Port Mozilla to GDK : [Attachment 317215] gfx.patch for GDK porting

Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has granted Jiny Sung
<jh0421.sung@samsung.com>'s request for superreview:
Bug 430413: Port Mozilla to GDK
https://bugzilla.mozilla.org/show_bug.cgi?id=430413

Attachment 317215: gfx.patch for GDK porting
https://bugzilla.mozilla.org/attachment.cgi?id=317215&action=edit

------- Additional Comments from Vladimir Vukicevic (:vlad)
<vladimir@pobox.com>
This looks fine, but please don't nest the #ifdefs.. e.g.,

#ifdef MOZ_ENABLE_GTK2
#ifdef MOZ_X11

should just be

#if defined(MOZ_ENABLE_GTK2) && defined(MOZ_X11)

I'll take a look at the other patch in a bit.
0
bugzilla
4/24/2008 5:31:06 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
293 Views

Similar Articles

[PageSpeed] 54

Reply: