superreview granted: [Bug 429230] memory leak in pkix_CheckCert function : [Attachment 315876] Patch v1(remove debug code that leaks memory)

Kai Engert (:kaie) <kengert@redhat.com> has granted Alexei Volkov
<alexei.volkov.bugs@sun.com>'s request for superreview:
Bug 429230: memory leak in pkix_CheckCert function
https://bugzilla.mozilla.org/show_bug.cgi?id=429230

Attachment 315876: Patch v1(remove debug code that leaks memory)
https://bugzilla.mozilla.org/attachment.cgi?id=315876&action=edit

------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com>
You remove a lot of code, is that all equivalent to PKIX_CHECK ?
0
bugzilla
4/22/2008 3:04:11 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
607 Views

Similar Articles

[PageSpeed] 11

Reply:

Similar Artilces:

superreview requested: [Bug 429230] memory leak in pkix_CheckCert function : [Attachment 315876] Patch v1(remove debug code that leaks memory)
Alexei Volkov <alexei.volkov.bugs@sun.com> has asked Kai Engert (:kaie) <kengert@redhat.com> for superreview: Bug 429230: memory leak in pkix_CheckCert function https://bugzilla.mozilla.org/show_bug.cgi?id=429230 Attachment 315876: Patch v1(remove debug code that leaks memory) https://bugzilla.mozilla.org/attachment.cgi?id=315876&action=edit ------- Additional Comments from Alexei Volkov <alexei.volkov.bugs@sun.com> Nominating the bug for 3.12.0. checkerCheck(a pointer to pkix_PolicyChecker_Check) will throw an error in case when cert does not pass the che...

superreview granted: [Bug 431414] Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks : [Attachment 318566] Fix memory leaks
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 431414: Review MailNews uses of idl functions that return xpcom allocat= ed arrays [..., array, ...] for memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=3D431414 Attachment 318566: Fix memory leaks https://bugzilla.mozilla.org/attachment.cgi?id=3D318566&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ // Ensure any old data is freed if necessary.=0D >+ if (mSearchAttrs) {=0D ...

superreview granted: [Bug 431414] Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks : [Attachment 319371] Fix memory leaks v2
Mark Banner <bugzilla@standard8.plus.com> has granted superreview: Bug 431414: Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=431414 Attachment 319371: Fix memory leaks v2 https://bugzilla.mozilla.org/attachment.cgi?id=319371&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> Fixes Neil's comments, carrying forward his sr. ...

superreview granted: [Bug 262758] live bookmarks leak memory/RDF resources : [Attachment 161801] 262758-livemark-refresh-leaks-memory-0.patch
Mike Shaver <shaver@mozilla.org> has granted vladimir@pobox.com's request for superreview: Bug 262758: live bookmarks leak memory/RDF resources https://bugzilla.mozilla.org/show_bug.cgi?id=262758 Attachment 161801: 262758-livemark-refresh-leaks-memory-0.patch https://bugzilla.mozilla.org/attachment.cgi?id=161801&action=edit ...

superreview requested: [Bug 431414] Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks : [Attachment 318566] Fix memory leaks
Mark Banner <bugzilla@standard8.plus.com> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 431414: Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=431414 Attachment 318566: Fix memory leaks https://bugzilla.mozilla.org/attachment.cgi?id=318566&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> This fixes the memory leaks I have found by going through: http://mxr.mozilla.org/seamonkey/search?string=array&...

superreview granted: [Bug 295074] POST responses remain in the memory cache when using XMLHttpRequest => huge memory leak : [Attachment 184211] v1 patch
Johnny Stenback <jst@mozilla.org> has granted Darin Fisher <darin@meer.net>'s request for superreview: Bug 295074: POST responses remain in the memory cache when using XMLHttpRequest => huge memory leak https://bugzilla.mozilla.org/show_bug.cgi?id=295074 Attachment 184211: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=184211&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> sr=jst ...

superreview denied: [Bug 397832] libpkix leaks memory if a macro calls a function that returns an error : [Attachment 305807] Object leak test(patch v1)
Nelson Bolyard <nelson@bolyard.com> has denied superreview: Bug 397832: libpkix leaks memory if a macro calls a function that returns an error https://bugzilla.mozilla.org/show_bug.cgi?id=3D397832 Attachment 305807: Object leak test(patch v1) https://bugzilla.mozilla.org/attachment.cgi?id=3D305807&action=3Dedit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> 1. In source file lib/certhigh/certvfypkix.c Please move the declaration = =0D of this function:=0D =0D > extern void=0D > cert_AddToVerifyLog(CERTVerifyLog *log, CERTCertificate *...

superreview granted: [Bug 306785] memory leaks in PQG_ParamGenSeedLen : [Attachment 194622] fix for memory leaks
Robert Relyea <rrelyea@redhat.com> has granted Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 306785: memory leaks in PQG_ParamGenSeedLen https://bugzilla.mozilla.org/show_bug.cgi?id=306785 Attachment 194622: fix for memory leaks https://bugzilla.mozilla.org/attachment.cgi?id=194622&action=edit ------- Additional Comments from Robert Relyea <rrelyea@redhat.com> Your code is correct wrt getPQseed(). We know seedBytes doesn't change, so it's clearly a waste to allocate each time through. bob ...

superreview granted: [Bug 270215] Memory leak in wallet_GetLine : [Attachment 166131] Patch v1
Darin Fisher (IBM) <darin@meer.net> has granted Philip K. Warren (IBM) <pkwarren@gmail.com>'s request for superreview: Bug 270215: Memory leak in wallet_GetLine https://bugzilla.mozilla.org/show_bug.cgi?id=270215 Attachment 166131: Patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=166131&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> It might be good to turn sublist->item into a nsCString as well :) sr=darin ...

superreview granted: [Bug 297592] Need a JSS Selfserv test for checking memory leaks : [Attachment 189371] JSS_SelfServServer and JSS_SelfServClient program for testing memory leaks
glen beasley <glen.beasley@sun.com> has granted Sandeep Konchady <Sandeep.Konchady@Sun.COM>'s request for superreview: Bug 297592: Need a JSS Selfserv test for checking memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=297592 Attachment 189371: JSS_SelfServServer and JSS_SelfServClient program for testing memory leaks https://bugzilla.mozilla.org/attachment.cgi?id=189371&action=edit ...

superreview requested: [Bug 262758] live bookmarks leak memory/RDF resources : [Attachment 161801] 262758-livemark-refresh-leaks-memory-0.patch
vladimir@pobox.com has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 262758: live bookmarks leak memory/RDF resources https://bugzilla.mozilla.org/show_bug.cgi?id=262758 Attachment 161801: 262758-livemark-refresh-leaks-memory-0.patch https://bugzilla.mozilla.org/attachment.cgi?id=161801&action=edit ...

superreview granted: [Bug 283564] possible memory leak with innerHTML : [Attachment 175601] patch v1
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 283564: possible memory leak with innerHTML https://bugzilla.mozilla.org/show_bug.cgi?id=283564 Attachment 175601: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=175601&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, but document on the fragment sink api that once you've parsed one fragment the sink will not work unless you reset it as the sink on the parser (which is pretty backwards, but t...

superreview granted: [Bug 251267] Memory leak in XRemoteService.cpp : [Attachment 153083] Patch v1
Christopher Blizzard <blizzard@mozilla.org> has granted Philip K. Warren (IBM) <pkwarren@gmail.com>'s request for superreview: Bug 251267: Memory leak in XRemoteService.cpp http://bugzilla.mozilla.org/show_bug.cgi?id=251267 Attachment 153083: Patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=153083&action=edit ...

superreview granted: [Bug 240724] Memory leak in nsAccessibleWrap.cpp : [Attachment 146287] Patch v1
Henry Jia <Henry.Jia@sun.com> has granted Philip K. Warren <pkw@us.ibm.com>'s request for superreview: Bug 240724: Memory leak in nsAccessibleWrap.cpp http://bugzilla.mozilla.org/show_bug.cgi?id=240724 Attachment 146287: Patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=146287&action=edit ------- Additional Comments from Henry Jia <Henry.Jia@sun.com> sr=Henry ...

Web resources about - superreview granted: [Bug 429230] memory leak in pkix_CheckCert function : [Attachment 315876] Patch v1(remove debug code that leaks memory) - mozilla.dev.super-review

Resources last updated: 11/21/2015 1:03:33 PM