superreview granted: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 316186] patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac

Robert O'Callahan (:roc) <roc@ocallahan.org> has granted John Daggett (:jtd)
<jdaggett@mozilla.com>'s request for superreview:
Bug 428458: text input size="n" is too wide with monospace font
https://bugzilla.mozilla.org/show_bug.cgi?id=428458

Attachment 316186: patch, v.0.2, explicitly set Courier to be fixed-pitch font
on mac
https://bugzilla.mozilla.org/attachment.cgi?id=316186&action=edit
0
bugzilla
4/17/2008 8:28:30 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
472 Views

Similar Articles

[PageSpeed] 8

Reply:

Similar Artilces:

superreview requested: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 316186] patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 428458: text input size="n" is too wide with monospace font https://bugzilla.mozilla.org/show_bug.cgi?id=428458 Attachment 316186: patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac https://bugzilla.mozilla.org/attachment.cgi?id=316186&action=edit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> Based on Smokey's screenshots, setting Courier New as the default monospace font doesn...

superreview granted: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 315051] use ceil consistently
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted superreview: Bug 428458: text input size="n" is too wide with monospace font https://bugzilla.mozilla.org/show_bug.cgi?id=428458 Attachment 315051: use ceil consistently https://bugzilla.mozilla.org/attachment.cgi?id=315051&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> Looks ok to me but really Stuart should review this ...

superreview granted: [Bug 181712] Menu item for "default font size" (also indicate current text/font zoom value/size?) : [Attachment 237374] r=smorgan patch
Mike Pinkerton <mikepinkerton@mac.com> has granted froodian <stridey@gmail.com>'s request for superreview: Bug 181712: Menu item for "default font size" (also indicate current text/font zoom value/size?) https://bugzilla.mozilla.org/show_bug.cgi?id=181712 Attachment 237374: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=237374&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink. are we sure those getter_addrefs -> dont_addrefs are correct? ...

superreview requested: [Bug 181712] Menu item for "default font size" (also indicate current text/font zoom value/size?) : [Attachment 237374] r=smorgan patch
froodian <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 181712: Menu item for "default font size" (also indicate current text/font zoom value/size?) https://bugzilla.mozilla.org/show_bug.cgi?id=181712 Attachment 237374: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=237374&action=edit ------- Additional Comments from froodian <stridey@gmail.com> Pink, this blocks all the menu cleanup work for 1.1, so a speedy sr would be most helpful for me. :) ...

superreview granted: [Bug 232487] Text identified as lang="sa" (Sanskrit) uses Western fonts, not Devanagari fonts : [Attachment 152111] Fix duplicate line
Christopher Blizzard <blizzard@mozilla.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 232487: Text identified as lang="sa" (Sanskrit) uses Western fonts, not Devanagari fonts http://bugzilla.mozilla.org/show_bug.cgi?id=232487 Attachment 152111: Fix duplicate line http://bugzilla.mozilla.org/attachment.cgi?id=152111&action=edit ...

superreview granted: [Bug 292487] Remove duplication of "font" in pref-viewing_messages.xul : [Attachment 182295] Patch v 0.1
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 292487: Remove duplication of "font" in pref-viewing_messages.xul https://bugzilla.mozilla.org/show_bug.cgi?id=292487 Attachment 182295: Patch v 0.1 https://bugzilla.mozilla.org/attachment.cgi?id=182295&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I guess this will do. ...

superreview granted: [Bug 418479] CG glyph rendering always anti-aliases even when system preference is to disable for font size < x : [Attachment 313541] patch, v.0.2, without cairo fixes
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has granted John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 418479: CG glyph rendering always anti-aliases even when system preference is to disable for font size < x https://bugzilla.mozilla.org/show_bug.cgi?id=418479 Attachment 313541: patch, v.0.2, without cairo fixes https://bugzilla.mozilla.org/attachment.cgi?id=313541&action=edit ------- Additional Comments from Vladimir Vukicevic (:vlad) <vladimir@pobox.com> Looks good! ...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220151] updated fix with review comments
Scott MacGregor <mscott@mozilla.org> has granted superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220151: updated fix with review comments https://bugzilla.mozilla.org/attachment.cgi?id=220151&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying forward david's sr and neil's r. ...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> my one concern is about migration from the per-server prefs to the global prefs. What happens in that scenar...

superreview granted: [Bug 62429] The "Start my reply above the quoted text" setting should ALSO allow to prepend the signature above the quote text. (top) : [Attachment 130529] Patch v0.6c
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 62429: The "Start my reply above the quoted text" setting should ALSO allow to prepend the signature above the quote text. (top) http://bugzilla.mozilla.org/show_bug.cgi?id=62429 Attachment 130529: Patch v0.6c http://bugzilla.mozilla.org/attachment.cgi?id=130529&action=edit ...

superreview granted: [Bug 62429] The "Start my reply above the quoted text" setting should ALSO allow to prepend the signature above the quote text. (top) : [Attachment 131996] Patch v0.6f
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 62429: The "Start my reply above the quoted text" setting should ALSO allow to prepend the signature above the quote text. (top) http://bugzilla.mozilla.org/show_bug.cgi?id=62429 Attachment 131996: Patch v0.6f http://bugzilla.mozilla.org/attachment.cgi?id=131996&action=edit ...

superreview granted: [Bug 245819] Can't get accessibility info from 2 pages in a row, when they have <input type="text"> : [Attachment 150220] Fix flaws in checkin to bug 244624, which caused this re
Henry Jia <Henry.Jia@sun.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 245819: Can't get accessibility info from 2 pages in a row, when they have <input type="text"> http://bugzilla.mozilla.org/show_bug.cgi?id=245819 Attachment 150220: Fix flaws in checkin to bug 244624, which caused this regression http://bugzilla.mozilla.org/attachment.cgi?id=150220&action=edit ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Brendan Eich <brendan@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> rs=me, I'm trusting you guys, patch looks ok from the context di...

superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #2
Steuard Jensen <steuard+mozilla@slimy.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit ...

Web resources about - superreview granted: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 316186] patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac - mozilla.dev.super-review

Resources last updated: 12/30/2015 4:53:58 AM