superreview granted: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 315051] use ceil consistently

Robert O'Callahan (:roc) <roc@ocallahan.org> has granted  superreview:
Bug 428458: text input size="n" is too wide with monospace font
https://bugzilla.mozilla.org/show_bug.cgi?id=428458

Attachment 315051: use ceil consistently
https://bugzilla.mozilla.org/attachment.cgi?id=315051&action=edit

------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org>
Looks ok to me but really Stuart should review this
0
bugzilla
4/11/2008 9:11:20 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
364 Views

Similar Articles

[PageSpeed] 56

Reply:

Similar Artilces:

superreview granted: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 316186] patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted John Daggett (:jtd) <jdaggett@mozilla.com>'s request for superreview: Bug 428458: text input size="n" is too wide with monospace font https://bugzilla.mozilla.org/show_bug.cgi?id=428458 Attachment 316186: patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac https://bugzilla.mozilla.org/attachment.cgi?id=316186&action=edit ...

superreview requested: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 316186] patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 428458: text input size="n" is too wide with monospace font https://bugzilla.mozilla.org/show_bug.cgi?id=428458 Attachment 316186: patch, v.0.2, explicitly set Courier to be fixed-pitch font on mac https://bugzilla.mozilla.org/attachment.cgi?id=316186&action=edit ------- Additional Comments from John Daggett (:jtd) <jdaggett@mozilla.com> Based on Smokey's screenshots, setting Courier New as the default monospace font doesn...

superreview granted: [Bug 181712] Menu item for "default font size" (also indicate current text/font zoom value/size?) : [Attachment 237374] r=smorgan patch
Mike Pinkerton <mikepinkerton@mac.com> has granted froodian <stridey@gmail.com>'s request for superreview: Bug 181712: Menu item for "default font size" (also indicate current text/font zoom value/size?) https://bugzilla.mozilla.org/show_bug.cgi?id=181712 Attachment 237374: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=237374&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink. are we sure those getter_addrefs -> dont_addrefs are correct? ...

superreview granted: [Bug 232487] Text identified as lang="sa" (Sanskrit) uses Western fonts, not Devanagari fonts : [Attachment 152111] Fix duplicate line
Christopher Blizzard <blizzard@mozilla.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 232487: Text identified as lang="sa" (Sanskrit) uses Western fonts, not Devanagari fonts http://bugzilla.mozilla.org/show_bug.cgi?id=232487 Attachment 152111: Fix duplicate line http://bugzilla.mozilla.org/attachment.cgi?id=152111&action=edit ...

superreview granted: [Bug 313196] HMAC SHA-384 and HMAC SHA-512 should use 128-byte block size : [Attachment 201801] Proposed patch: add an "input block size" field to the SECHashObject structure, v3
Robert Relyea <rrelyea@redhat.com> has granted Wan-Teh Chang <wtchang@redhat.com>'s request for superreview: Bug 313196: HMAC SHA-384 and HMAC SHA-512 should use 128-byte block size https://bugzilla.mozilla.org/show_bug.cgi?id=313196 Attachment 201801: Proposed patch: add an "input block size" field to the SECHashObject structure, v3 https://bugzilla.mozilla.org/attachment.cgi?id=201801&action=edit ------- Additional Comments from Robert Relyea <rrelyea@redhat.com> sr=relyea. Don't check in until you have r=nelson. Also, I would really li...

superreview granted: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156227] use Grant/Cancel
Blake Ross <firefox@blakeross.com> has granted Steffen Wilberg <steffen.wilberg@web.de>'s request for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156227: use Grant/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156227&action=edit ...

superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #2
Steuard Jensen <steuard+mozilla@slimy.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit ...

superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #3
Daniel Veditz <dveditz@cruzio.com> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> blame says bsmed...

superreview requested: [Bug 181712] Menu item for "default font size" (also indicate current text/font zoom value/size?) : [Attachment 237374] r=smorgan patch
froodian <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 181712: Menu item for "default font size" (also indicate current text/font zoom value/size?) https://bugzilla.mozilla.org/show_bug.cgi?id=181712 Attachment 237374: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=237374&action=edit ------- Additional Comments from froodian <stridey@gmail.com> Pink, this blocks all the menu cleanup work for 1.1, so a speedy sr would be most helpful for me. :) ...

superreview granted: [Bug 53995] using "text zoom" to scale fonts very small makes them come back normal : [Attachment 173253] Possible patch
David Baron <dbaron@mozilla.org> has granted David Baron <dbaron@mozilla.org>'s request for superreview: Bug 53995: using "text zoom" to scale fonts very small makes them come back normal https://bugzilla.mozilla.org/show_bug.cgi?id=53995 Attachment 173253: Possible patch https://bugzilla.mozilla.org/attachment.cgi?id=173253&action=edit ...

superreview granted: [Bug 242346] "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts : [Attachment 147494] Patch
Alec Flett <alecf@flett.org> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 242346: "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts http://bugzilla.mozilla.org/show_bug.cgi?id=242346 Attachment 147494: Patch http://bugzilla.mozilla.org/attachment.cgi?id=147494&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> sr=alecf ...

superreview requested: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156227] use Grant/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156227: use Grant/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156227&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Grant/Cancel is better indeed. ...

superreview granted: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174088] updated patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Hasse <jasajudeju@telia.com>'s request for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174088: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=174088&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Transferring r=db48x as per his comment. ...

superreview requested: [Bug 232487] Text identified as lang="sa" (Sanskrit) uses Western fonts, not Devanagari fonts : [Attachment 143097] update
Jungshik Shin <jshin@mailaps.org> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 232487: Text identified as lang="sa" (Sanskrit) uses Western fonts, not Devanagari fonts http://bugzilla.mozilla.org/show_bug.cgi?id=232487 Attachment 143097: update http://bugzilla.mozilla.org/attachment.cgi?id=143097&action=edit ------- Additional Comments from Jungshik Shin <jshin@mailaps.org> asking for r/sr. smontagu, if you happen to read this email, please feel free to chime in. ...

Web resources about - superreview granted: [Bug 428458] text input size="n" is too wide with monospace font : [Attachment 315051] use ceil consistently - mozilla.dev.super-review

Resources last updated: 12/3/2015 3:38:59 PM