superreview granted: [Bug 422511] "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" : [Attachment 312549] Patch

Christian :Biesinger <cbiesinger@gmail.com> has granted H=C3=A5kan Waara
<hwaara@gmail.com>'s request for superreview:
Bug 422511: "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'"
https://bugzilla.mozilla.org/show_bug.cgi?id=3D422511

Attachment 312549: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=3D312549&action=3Dedit=
0
bugzilla
3/30/2008 11:23:59 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
636 Views

Similar Articles

[PageSpeed] 15

Reply:

Similar Artilces:

superreview requested: [Bug 422511] "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" : [Attachment 312549] Patch
H=C3=A5kan Waara <hwaara@gmail.com> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 422511: "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" https://bugzilla.mozilla.org/show_bug.cgi?id=3D422511 Attachment 312549: Patch https://bugzilla.mozilla.org/attachment.cgi?id=3D312549&action=3Dedit= ...

superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's re
Darin Fisher (Google) <darin@meer.net> has granted Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: docshell/base/nsDocShell.cpp > if (!r...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Brendan Eich <brendan@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> rs=me, I'm trusting you guys, patch looks ok from the context di...

superreview granted: [Bug 313217] document.open('replace') now opens text/plain document where it used to open text/html : [Attachment 200309] Patch to make a type of "replace" mean HTML but not repl
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 313217: document.open('replace') now opens text/plain document where it used to open text/html https://bugzilla.mozilla.org/show_bug.cgi?id=313217 Attachment 200309: Patch to make a type of "replace" mean HTML but not replace https://bugzilla.mozilla.org/attachment.cgi?id=200309&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> (In reply to comment #60) > (From update of attachment 227564 [edit]) > So this w...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> Actually, I'm going to go ahead and check this in on the trunk, since thes...

superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226606] store state in channel, works f
Darin Fisher (Google) <darin@meer.net> has granted Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 226606: store state in channel, works for target= as well as window.open https://bugzilla.mozilla.org/attachment.cgi?id=226606&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: docshell/base/nsDoc...

superreview granted: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 241797] r=smorgan patch
Mike Pinkerton <mikepinkerton@mac.com> has granted froodian (unreliable 10/7-10/12) <stridey@gmail.com>'s request for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 241797: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=241797&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink ...

superreview granted: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 137544] (Gv1b) </mailnews/*>
Seth Spitzer <sspitzer@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 137544: (Gv1b) </mailnews/*> http://bugzilla.mozilla.org/attachment.cgi?id=137544&action=edit ------- Additional Comments from Seth Spitzer <sspitzer@mozilla.org> sr=sspitzer ...

superreview granted: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 137586] (Iv1c) </xpinstall/*>
Daniel Veditz <dveditz+bmo@cruzio.com> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 137586: (Iv1c) </xpinstall/*> http://bugzilla.mozilla.org/attachment.cgi?id=137586&action=edit ------- Additional Comments from Daniel Veditz <dveditz+bmo@cruzio.com> Seems like a lot of gratuitous moving variables around to get rid of one warni...

superreview granted: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 137550] (Mv1) </embedding/*>
Alec Flett <alecf@flett.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 137550: (Mv1) </embedding/*> http://bugzilla.mozilla.org/attachment.cgi?id=137550&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> sr=alecf ...

superreview granted: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 146707] (Qv1) </ipc/*>
Scott Collins <scc@mozilla.org> has granted Daniel (Leaf) Nunes <leaf@mozilla.org>'s request for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 146707: (Qv1) </ipc/*> http://bugzilla.mozilla.org/attachment.cgi?id=146707&action=edit ------- Additional Comments from Scott Collins <scc@mozilla.org> works for me; sr=scc ...

superreview granted: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 146706] (Pv1) </profile/*>
rbs@maths.uq.edu.au has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 146706: (Pv1) </profile/*> http://bugzilla.mozilla.org/attachment.cgi?id=146706&action=edit ------- Additional Comments from rbs@maths.uq.edu.au s=rbs, I had missed this from my review queue. ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 141227] (Av1c) <nsMacMain.cpp>
Serge GAUTHERIE <gautheri@noos.fr> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 141227: (Av1c) <nsMacMain.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=141227&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Keeping { (Av1b) <nsMacMain.cpp> patch 2003-12-20 05:33 PST pinkerton: r...