superreview granted: [Bug 419167] right/left borders don't adopt user-defined color (colour) scheme (untick 'Allow pages to choose their own colors') : [Attachment 305371] patch without the array

David Baron [:dbaron] <dbaron@mozilla.com> has granted	superreview:
Bug 419167: right/left borders don't adopt user-defined color (colour) sche=
me
(untick 'Allow pages to choose their own colors')
https://bugzilla.mozilla.org/show_bug.cgi?id=3D419167

Attachment 305371: patch without the array
https://bugzilla.mozilla.org/attachment.cgi?id=3D305371&action=3Dedit

------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com>
r+sr=3Ddbaron.=0D
=0D
Why don't we just get this one in and I'll worry about converting this code
over later.=0D
=0D
Requesting approval, as this is very low risk; it just corrects the list of
properties that are ignored by this pref to reflect that two of the propert=
ies
were split up into pieces.=
0
bugzilla
3/3/2008 5:58:40 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
496 Views

Similar Articles

[PageSpeed] 46

Reply:

Similar Artilces:

superreview granted: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem)
David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 281783: updated patch v6 https://bugzilla.mozilla.org/attachment.cgi?id=281783&action=edit ------- Additional Comments from David Baron [:dbaron] (less responsive until Septem...

superreview granted: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) #2
David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> has granted superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 282043: updated patch v7 https://bugzilla.mozilla.org/attachment.cgi?id=282043&action=edit ------- Additional Comments from David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> File a bug on the XXX comment in nsBu...

superreview granted: [Bug 262365] document.all is ignoring __defineGetter__ : [Attachment 161245] Don't shadow 'user-defined' document.all.
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 262365: document.all is ignoring __defineGetter__ https://bugzilla.mozilla.org/show_bug.cgi?id=262365 Attachment 161245: Don't shadow 'user-defined' document.all. https://bugzilla.mozilla.org/attachment.cgi?id=161245&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> >+ if (hasAll && helper) { >+ // Our helper's prototype now has a "all" property, remove s/a &...

superreview granted: [Bug 252984] Cannot type in any of the fields
Aaron Leventhal <aaronleventhal@moonset.net> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 252984: Cannot type in any of the fields - forms don't get focus on left-click http://bugzilla.mozilla.org/show_bug.cgi?id=252984 Attachment 154652: Correct patch. In the last one The last patch didn't include the removal of the call to FocusableAncestor() in nsFrame::IsFocusable() http://bugzilla.mozilla.org/attachment.cgi?id=154652&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net...

superreview granted: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 318391] Patch v1.1
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted=20 superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 318391: Patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=3D318391&action=3Dedit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> Thank you, Roc and Katakai-san.= ...

superreview granted: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 317954] Patch v1.0
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 317954: Patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=3D317954&action=3Dedit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.or= g> + if (aState =3D=3D mIMEData->mEnabled) {=0D mIMEData->mEnabled =3D aState;=0D =0D...

superreview granted: [Bug 271955] "empty" table cells don't include borders in size even when 'empty-cells: show' : [Attachment 167169] patch
Robert O'Callahan <roc@ocallahan.org> has granted David Baron <dbaron@mozilla.org>'s request for superreview: Bug 271955: "empty" table cells don't include borders in size even when 'empty-cells: show' https://bugzilla.mozilla.org/show_bug.cgi?id=271955 Attachment 167169: patch https://bugzilla.mozilla.org/attachment.cgi?id=167169&action=edit ...

superreview granted: [Bug 282830] move down 'Other languages' and 'User defined' to the end in the font selection pref. panel : [Attachment 174787] patch
Brian Ryner (IBM) <bryner@brianryner.com> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 282830: move down 'Other languages' and 'User defined' to the end in the font selection pref. panel https://bugzilla.mozilla.org/show_bug.cgi?id=282830 Attachment 174787: patch https://bugzilla.mozilla.org/attachment.cgi?id=174787&action=edit ...

superreview canceled: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has canceled Zack Weinberg <zweinberg@mozilla.com>'s request for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=323226&action=edit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> retracting review request. ...

superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> This proved to be pretty simple to fix, with some caveats. The attached pa= tch passes Hixie's test linke...

superreview granted: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
Johnny Stenback <jst@netscape.com> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview requested: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem)
Robert O'Callahan <roc@ocallahan.org> has asked David Baron [:dbaron] (less responsive until September 17) <dbaron@mozilla.com> for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 278456: updated patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=278456&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> The layout changes need rev...

superreview canceled: [Bug 96041] Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem)
Robert O'Callahan (:roc) <roc@ocallahan.org> has canceled Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 96041: Left or right pixels of 'F' 'J' 'M' 'W' characters overflow and lack hover color (bounding box / font metrics problem) https://bugzilla.mozilla.org/show_bug.cgi?id=96041 Attachment 278456: updated patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=278456&action=edit ...

Web resources about - superreview granted: [Bug 419167] right/left borders don't adopt user-defined color (colour) scheme (untick 'Allow pages to choose their own colors') : [Attachment 305371] patch without the array - mozilla.dev.super-review

Resources last updated: 12/22/2015 7:52:41 PM